Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 10:13:06 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     Frank Jungclaus <frank.jungclaus@esd.eu>,
        linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] can: esd_usb: Make use of existing kernel macros
Message-ID: <20230522-shine-attitude-09ec9aefce64-mkl@pengutronix.de>
References: <20230519195600.420644-1-frank.jungclaus@esd.eu>
 <20230519195600.420644-2-frank.jungclaus@esd.eu>
 <CAMZ6Rq+V4HRLa2bzADnsvaKHuCwi6O5jKo39mhon_+OnMDEJbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2cbxal2xzghzgpqi"
Content-Disposition: inline
In-Reply-To: <CAMZ6Rq+V4HRLa2bzADnsvaKHuCwi6O5jKo39mhon_+OnMDEJbQ@mail.gmail.com>
Precedence: bulk


--2cbxal2xzghzgpqi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21.05.2023 18:16:13, Vincent MAILHOL wrote:
> Thanks for the patch.
>=20
> On Sat. 20 May 2023 at 04:57, Frank Jungclaus <frank.jungclaus@esd.eu> wr=
ote:
> > Make use of existing kernel macros:
> > - Use the unit suffixes from linux/units.h for the controller clock
> > frequencies
> > - Use the BIT() and the GENMASK() macro to set specific bits in some
> >   constants
> > - Use CAN_MAX_DLEN (instead of directly using the value 8) for the
> > maximum CAN payload length
> >
> > Additionally:
> > - Spend some commenting for the previously changed constants
> > - Add the current year to the copyright notice
> > - While adding the header linux/units.h to the list of include files
> > also sort that list alphabetically
> >
> > Suggested-by: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
> > Link: https://lore.kernel.org/all/CAMZ6RqLaDNy-fZ2G0+QMhUEckkXLL+ZyELVS=
DFmqpd++aBzZQg@mail.gmail.com/
> > Link: https://lore.kernel.org/all/CAMZ6RqKdg5YBufa0C+ttzJvoG=3D9yuti-8A=
mthCi4jBbd08JEtw@mail.gmail.com/
> > Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > Link: https://lore.kernel.org/all/20230518-grower-film-ea8b5f853f3e-mkl=
@pengutronix.de/
> > Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>
> > ---
> >  drivers/net/can/usb/esd_usb.c | 40 ++++++++++++++++++-----------------
> >  1 file changed, 21 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/net/can/usb/esd_usb.c b/drivers/net/can/usb/esd_us=
b.c
> > index d33bac3a6c10..32354cfdf151 100644
> > --- a/drivers/net/can/usb/esd_usb.c
> > +++ b/drivers/net/can/usb/esd_usb.c
> > @@ -3,19 +3,20 @@
> >   * CAN driver for esd electronics gmbh CAN-USB/2 and CAN-USB/Micro
> >   *
> >   * Copyright (C) 2010-2012 esd electronic system design gmbh, Matthias=
 Fuchs <socketcan@esd.eu>
> > - * Copyright (C) 2022 esd electronics gmbh, Frank Jungclaus <frank.jun=
gclaus@esd.eu>
> > + * Copyright (C) 2022-2023 esd electronics gmbh, Frank Jungclaus <fran=
k.jungclaus@esd.eu>
> >   */
> > +#include <linux/can.h>
> > +#include <linux/can/dev.h>
> > +#include <linux/can/error.h>
> > +
> >  #include <linux/ethtool.h>
> > -#include <linux/signal.h>
> > -#include <linux/slab.h>
> >  #include <linux/module.h>
> >  #include <linux/netdevice.h>
> > +#include <linux/signal.h>
> > +#include <linux/slab.h>
> > +#include <linux/units.h>
> >  #include <linux/usb.h>
> >
> > -#include <linux/can.h>
> > -#include <linux/can/dev.h>
> > -#include <linux/can/error.h>
> > -
> >  MODULE_AUTHOR("Matthias Fuchs <socketcan@esd.eu>");
> >  MODULE_AUTHOR("Frank Jungclaus <frank.jungclaus@esd.eu>");
> >  MODULE_DESCRIPTION("CAN driver for esd electronics gmbh CAN-USB/2 and =
CAN-USB/Micro interfaces");
> > @@ -27,8 +28,8 @@ MODULE_LICENSE("GPL v2");
> >  #define USB_CANUSBM_PRODUCT_ID 0x0011
> >
> >  /* CAN controller clock frequencies */
> > -#define ESD_USB2_CAN_CLOCK     60000000
> > -#define ESD_USBM_CAN_CLOCK     36000000
> > +#define ESD_USB2_CAN_CLOCK     (60 * MEGA) /* Hz */
> > +#define ESD_USBM_CAN_CLOCK     (36 * MEGA) /* Hz */
> >
> >  /* Maximum number of CAN nets */
> >  #define ESD_USB_MAX_NETS       2
> > @@ -42,20 +43,21 @@ MODULE_LICENSE("GPL v2");
> >  #define CMD_IDADD              6 /* also used for IDADD_REPLY */
> >
> >  /* esd CAN message flags - dlc field */
> > -#define ESD_RTR                        0x10
> > +#define ESD_RTR        BIT(4)
> > +
> >
> >  /* esd CAN message flags - id field */
> > -#define ESD_EXTID              0x20000000
> > -#define ESD_EVENT              0x40000000
> > -#define ESD_IDMASK             0x1fffffff
> > +#define ESD_EXTID      BIT(29)
> > +#define ESD_EVENT      BIT(30)
> > +#define ESD_IDMASK     GENMASK(28, 0)
> >
> >  /* esd CAN event ids */
> >  #define ESD_EV_CAN_ERROR_EXT   2 /* CAN controller specific diagnostic=
 data */
> >
> >  /* baudrate message flags */
> > -#define ESD_USB_UBR            0x80000000
> > -#define ESD_USB_LOM            0x40000000
> > -#define ESD_USB_NO_BAUDRATE    0x7fffffff
> > +#define ESD_USB_LOM    BIT(30) /* 0x40000000, Listen Only Mode */
> > +#define ESD_USB_UBR    BIT(31) /* 0x80000000, User Bit Rate (controlle=
r BTR) in bits 0..27 */
>                                      ^^^^^^^^^^
>=20
> As pointented by Marc, no need for redundant comment with the hexadecimal=
 value.

Fixed while applying.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--2cbxal2xzghzgpqi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmRrJBAACgkQvlAcSiqK
BOgE6wf9EQrIh6qzY5Yb9XkZa4oiqJ5fvfCG3f8pY/pJk2Jr5XqsJE7oC4eoANpG
zoHN/dQoKr7MzRCLJx4rXc47zPuOOF5BertZPX4Q/fnqDOJtLcdVQsbi5Nt0dVMO
m1PU2uf4Ts53L7RQZYV8eZSO5FvZx1HSrw8Dwn9zXtwFENwuqWZ1f1oDfw2DuRvb
ecDvfwvbmde8dxRlVuOS3XrBYN9FerOX19yn/o+yfjLrLjZSOoRtf7ZZ989JDxQP
Qtrti1U/0aUSZEG1uS7kPo59kR71rNPMtvqhrTwlpip2wxyXhkks6QAv18cMsLX5
/pe4a6NeYvS2os2En/JKtxM2+b0d7g==
=4YTh
-----END PGP SIGNATURE-----

--2cbxal2xzghzgpqi--