Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <822d2741-32ff-fc73-28a5-25575ab3cc52@rasmusvillemoes.dk>
Date:   Mon, 22 May 2023 10:44:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] iio: addac: ad74413: don't set DIN_SINK for functions
 other than digital input
Content-Language: en-US, da
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     =?UTF-8?Q?Nuno_S=c3=a1?= <noname.nuno@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Cosmin Tanislav <cosmin.tanislav@analog.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230503105042.453755-1-linux@rasmusvillemoes.dk>
 <27fe41e402ea0d6ef42aa0ac80aa3d1488862cd8.camel@gmail.com>
 <6fcf4997-9d88-7e86-70f7-52f9d296bc6e@rasmusvillemoes.dk>
 <20230506191636.3cff4b24@jic23-huawei>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
In-Reply-To: <20230506191636.3cff4b24@jic23-huawei>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06/05/2023 20.16, Jonathan Cameron wrote:
> On Thu, 4 May 2023 12:08:53 +0200
> Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> 
>> On 04/05/2023 09.28, Nuno Sá wrote:

>>> Can anyone have a working device by specifying that dt parameter
>>> on a non digital channel (or expect something from having that parameter set)?
>>> Or the only effect is to actually have some functions misbehaving?  
>>
>> The data sheet doesn't say that the DIN_SINK should have any effect for
>> other functions, so I'm pretty sure it's only the latter: some functions
>> misbehave.
>>
>>> On the driver side, if it's never right to have
>>> these settings together, then the patch is valid since if someone has this, his
>>> configuration is broken anyways (maybe that's also a valid point for the
>>> bindings)...  
>>
>> Yes, I do believe that it's a broken description (whether or not the
>> bindings specify that), and drivers don't need to go out of their way to
>> validate or fixup such brokenness. But in this particular case, there's
>> really no extra burden on the driver to not put garbage in DIN_SINK when
>> a not-digital-input function has been chosen (the patch is a two-liner
>> with 'git show -w').
> 
> If we can tighten the DT binding to rule out something that should not be
> set than that would be good.  Tightening bindings is fine - we don't mind
> validation of bindings failing on peoples DTs as long as we didn't 'break'
> them actually working.

Well, I'm afraid I don't have any idea how to spell that constraint in
the yaml-language (help appreciated).

And I assume a dt binding update would be a separate patch anyway, so
could you please consider applying this patch?

Thanks,
Rasmus