Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
HMM_SOURCE_IP: 10.64.8.31:56210.1039000333
HMM_ATTACHE_NUM: 0000
HMM_SOURCE_TYPE: SMTP
Received: from clientip-114.242.206.180 (unknown [10.64.8.31])
        by 189.cn (HERMES) with SMTP id 651AF1002D6;
        Mon, 22 May 2023 16:29:30 +0800 (CST)
Received: from  ([114.242.206.180])
        by gateway-151646-dep-75648544bd-xp9j7 with ESMTP id 7db92210a86f4e62a567642a3e628660 for kernel@xen0n.name;
        Mon, 22 May 2023 16:29:33 CST
X-Transaction-ID: 7db92210a86f4e62a567642a3e628660
X-Real-From: 15330273260@189.cn
X-Receive-IP: 114.242.206.180
X-MEDUSA-Status: 0
Sender: 15330273260@189.cn
Message-ID: <d8e7a1ee-317c-6b44-27eb-ea637f8813ec@189.cn>
Date:   Mon, 22 May 2023 16:29:29 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v14 1/2] drm: add kms driver for loongson display
 controller
Content-Language: en-US
To:     WANG Xuerui <kernel@xen0n.name>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sui Jingfeng <suijingfeng@loongson.cn>,
        Li Yi <liyi@loongson.cn>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Christian Koenig <christian.koenig@amd.com>,
        Emil Velikov <emil.l.velikov@gmail.com>
Cc:     linaro-mm-sig@lists.linaro.org, loongson-kernel@lists.loongnix.cn,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Javier Martinez Canillas <javierm@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Liu Peibao <liupeibao@loongson.cn>, linux-media@vger.kernel.org
References: <20230520105718.325819-1-15330273260@189.cn>
 <20230520105718.325819-2-15330273260@189.cn>
 <26fd78b9-c074-8341-c99c-4e3b38cd861a@xen0n.name>
 <73447e35-f4df-9871-6210-b7bf1a3f04fc@189.cn>
 <97fe7af2-0a93-3f28-db6e-40a9b0798d49@xen0n.name>
From:   Sui Jingfeng <15330273260@189.cn>
In-Reply-To: <97fe7af2-0a93-3f28-db6e-40a9b0798d49@xen0n.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,
        FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FROM_LOCAL_DIGITS,
        FROM_LOCAL_HEX,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/5/22 16:09, WANG Xuerui wrote:
> On 2023/5/22 16:02, Sui Jingfeng wrote:
>> Hi,
>>
>> On 2023/5/21 20:21, WANG Xuerui wrote:
>>>> --- /dev/null
>>>> +++ b/drivers/gpu/drm/loongson/Kconfig
>>>> @@ -0,0 +1,17 @@
>>>> +# SPDX-License-Identifier: GPL-2.0
>>>> +
>>>> +config DRM_LOONGSON
>>>> +    tristate "DRM support for Loongson Graphics"
>>>> +    depends on DRM && PCI && MMU
>>>> +    select DRM_KMS_HELPER
>>>> +    select DRM_TTM
>>>> +    select I2C
>>>> +    select I2C_ALGOBIT
>>>> +    help
>>>> +      This is a DRM driver for Loongson Graphics, it may including
>>>
>>> Drop "it may"; "including" should be enough.
>>>
>> 'it may' is more *precise* here, because currently we don't ship with 
>> the support for loongson 2K series SoC.
>>
>> I'm try to be precise as far as I can, we avoid made this driver too 
>> large by ignore loongson 2K series SoC temporary.
>
> That's a good idea! For now the patch is so large that my review reply 
> is said to be dropped by the lists. Focusing on one bunch of similar 
> models first then adding support for the rest not-so-similar models is 
> very friendly towards the reviewing process and will help code quality 
> too.
>
>>
>>>> +      LS7A2000, LS7A1000, LS2K2000 and LS2K1000 etc. Loongson LS7A
>>>> +      series are bridge chipset, while Loongson LS2K series are SoC.
>>>> +
>>>> +      If "M" is selected, the module will be called loongson.
>>>
>>> Just "loongson"? 
>>
>> Yes,  when compile this driver as module,  loongson.ko will be 
>> generated.
>>
>>   drm radeon is also doing so, See drm/radeon/Kconfig.
>>
>>> I know it's like this for ages (at least dating back to the MIPS 
>>> days) but you really don't want to imply Loongson is mainly a GPU 
>>> company. Something like "loongson_drm" or "lsdc" or "gsgpu" could be 
>>> better. 
>>
>> No, these name may have backward compatibility problems.
>>
>> Downstream driver already taken those name.
>>
>> userspace driver need to differentiate them who is who.
>
> IMO this shouldn't be a problem. Let me try explaining this: 
> currently, upstream / the "new world" doesn't have any support for 
> this driver at all, so any name will work; just use whatever is 
> appropriate from an upstream's perspective, then make the userspace 
> bits recognize both variants, and you'll be fine. And the "existing" 
> userspace drivers can also carry the change, it'll just be a branch 
> never taken in that setup.
>
> So, I'm still in favor of keeping the upstream "clean" without dubious 
> names like this (bare "loongson"). What do you think about my 
> suggestion above?
>
No,

there is a 'arm' folder in the drivers/gpu/drm/,  It doesn't say that 
arm is a pure gpu company.

there is a 'ingenic' folder in the drivers/gpu/drm/, ingenic also have 
their own custom CPUs.

there is a 'amd' folder in the drivers/gpu/drm/, these doesn't imply amd 
is mainly a GPU company.

when a folder emerged in drm/, it stand for the GPU related part of this 
company.