Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230516182537.3139-1-osalvador@suse.de> <20230516182537.3139-4-osalvador@suse.de>
In-Reply-To: <20230516182537.3139-4-osalvador@suse.de>
From:   Alexander Potapenko <glider@google.com>
Date:   Mon, 22 May 2023 10:40:55 +0200
Message-ID: <CAG_fn=UJgnLFGgpkXbMeD6axZN_ifEPHvWpy2_oiPyG1a6PXng@mail.gmail.com>
Subject: Re: [PATCH v5 3/3] mm,page_owner: Filter out stacks by a threshold counter
To:     Oscar Salvador <osalvador@suse.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Michal Hocko <mhocko@suse.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Waiman Long <longman@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Marco Elver <elver@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Eric Dumazet <edumazet@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 16, 2023 at 8:25=E2=80=AFPM Oscar Salvador <osalvador@suse.de> =
wrote:
>
> We want to be able to filter out the output on a threshold basis,
> in this way we can get rid of a lot of noise and focus only on those
> stacks which have an allegedly high counter.
>
> We can control the threshold value by a new file called
> 'page_owner_threshold', which is 0 by default.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>

Nack.
We must decouple stackdepot from page_owner as much as possible, not
add extra dependencies by sharing variables between the two.

What you need here is a pair of xxx_iter_start()/xxx_iter_next()
functions in stackdepot.c that will hold the iteration state in a
struct and return the next stack trace.
The threshold value can also be part of that struct.