Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2668486rwd; Mon, 22 May 2023 02:22:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4k9PsIoMzjZ2RdZULSDKYX41uBqbWMcg+L/RnbSn9qZvwXX7HPiZGFTO8iS+rj+lWBTRkA X-Received: by 2002:a05:6a20:2615:b0:10a:be5c:6e2d with SMTP id i21-20020a056a20261500b0010abe5c6e2dmr5814074pze.39.1684747327932; Mon, 22 May 2023 02:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684747327; cv=none; d=google.com; s=arc-20160816; b=bY2Urk3GdAp8mjmVgDq4TF5hW3ZnmX0Zls6qXRIufil0FxazkvETWhXprAB7cnyz0h P9913tEhhx0C3s89sNUdT7VltcYAOEl6ffI42KYIYo92ya73AiRNu5AJYX0PTZh/22zI ylbAfWb0KNmax+1OT4rAs3hMPYf7J0hgOUx0joscV4q8y/gnzgHVsTD5ZJO8HjLhnGO1 kxSk+vhAFq9a2Zmc++FA5Hh70uU6Q/FXBolyEYZeEf6/WzTxEIYN2aEne/w/2WIjDnGJ HxjNH87ztnoOngd6qos+DGoQTOuvnMTxtGjrYAtadSq/5YXSEtvWbMwAIvkEQmjqt6Xw IWiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mvntBB6S4OGDk0cblEN3QofRB9SrGuLJq25V60Cs1QI=; b=U6N8JqmCknIG9MIYBWJs37IleLLCpEqFf9Fc1UhMWjC03MvIXegh4cv9Cgc5CsFwgC Ncd/XEhkcioB4feBioYMSEi+lbwwYnJwZ7o+ZxXJ/G13rXEur5/32xDiyr43dV7u17Qo Sb2YQ/vWY/k8howww0aN8zyqcSFz6TjJA/DzT9jjLidWZRSFfc18Dk4qr2+00NYsqViW EtmPyH0d3BIPTCAgF4bYuj0RoihlYtch46gFbUwZLL2hBiqdY6mfHBPjHUyE/wvu90e3 WJzkpBABaX1+0Y93O454bCPb2sJWC9hH3HDmeVfLysc4p2k1yugKGOBMuZwJw/Pom3ku xtRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=MmzvZFNi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p64-20020a625b43000000b0064667c16883si4489565pfb.100.2023.05.22.02.21.52; Mon, 22 May 2023 02:22:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=MmzvZFNi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbjEVJLl (ORCPT + 99 others); Mon, 22 May 2023 05:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232592AbjEVJLj (ORCPT ); Mon, 22 May 2023 05:11:39 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640C210D for ; Mon, 22 May 2023 02:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mvntBB6S4OGDk0cblEN3QofRB9SrGuLJq25V60Cs1QI=; b=MmzvZFNipp1kcQ8t4CWw8qk3uj rAxuMiyX2e/NPYNHx3fPJC6dNDLeiVudzTnBJcmibbzxBqz+RLOFipZuDl5c/0580AI/AWAHuK/8j c9wSTEpwq97vUFrRmCrQ2HNpwiQ9DKW8sgRTvgERlde0fkjEP/aIR6JUBwG8Ji6YF3UIhrZpy78Av 3yUDgBu2s9i9Twu23WcNCZywloaGYDZ6fVuzkcuyFcqOp24euJ2E9tryvWMKiHXmsqhXFWWp81dXq iWyIciJUGToRipqU5cD6xyOjBALBhG0t7H9MCzuePn5RqyWOe/dvpuFEVkSIC7DX5lvuFOLys71Xh X2AWzpbg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42496) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q11Zb-0006MA-TV; Mon, 22 May 2023 10:11:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q11Zb-0007pE-2p; Mon, 22 May 2023 10:11:23 +0100 Date: Mon, 22 May 2023 10:11:23 +0100 From: "Russell King (Oracle)" To: Claudiu Beznea Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: at91: pm: fix imbalanced reference counter for ethernet devices Message-ID: References: <20230518062511.2988500-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518062511.2988500-1-claudiu.beznea@microchip.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2023 at 09:25:11AM +0300, Claudiu Beznea wrote: > WARNING: CPU: 0 PID: 378 at lib/refcount.c:25 0xc07ffc08 > refcount_t: addition on 0; use-after-free. > Modules linked in: > CPU: 0 PID: 378 Comm: sh Not tainted 6.1.22-linux4microchip-2023.04-rc3+ #7 > Hardware name: Microchip SAMA7 > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] > Function entered at [] from [] There is no point what so ever including the backtrace in your commit message - the hex numbers here are specific to your kernel build and are meaningless for everyone else. Please either convert them to symbolic information so that they are meaningful to other people, or omit them. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!