Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cbec7486-d1dc-8597-3711-a7a3ee3ec517@suse.com>
Date:   Mon, 22 May 2023 11:36:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v8 2/6] usb: ljca: Add transport interfaces for sub-module
 drivers
Content-Language: en-US
To:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org
Cc:     srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
References: <20230511175844.185070-1-xiang.ye@intel.com>
 <20230511175844.185070-3-xiang.ye@intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230511175844.185070-3-xiang.ye@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0RHM3RWZURPNGN0ZXNhdU1LSEY5amlCRFVMOERxZk5mZEtoQTZRQWU4aUg2?=
 =?utf-8?B?NXI0aGFFcWVpbnRId3RFUlplMkxjZHZwcGM3VVJBUlN1bFJOOFJYbEUzTHVx?=
 =?utf-8?B?WWxEZURrSHhOQ1hDYlNEcVMwNk9vSURUNmxVa0pKSUVMakxvYlRLSS8xbHlZ?=
 =?utf-8?B?UG1CczAwS3ByQ1Y4YldEbFdrRTR4OGczanNtcVhVa2pkcThjS3I0dEQ4emhx?=
 =?utf-8?B?N20xNjJ3dTZuZlBISHJiWGRkb2ppdmVRM25hdWx3cXl0UXNtWVJPaVhjbGZT?=
 =?utf-8?B?MFFLTkZTL0k2djNDZUUrQ3A5eXE2M28zODA3R3dhbjl5aGhUNEZBN1pHSmNk?=
 =?utf-8?B?cFVZbnZkYlhWR29Bc0FkUGlERFFtN3lUUFlWeUJYcUtBeHQrdXRpL3RzaUwx?=
 =?utf-8?B?VEJ0V09KR0NpeFFVZEFJd0ovSUJmWGo3a0lzc3AveWZ3K1J6c1QwYlVvZE9t?=
 =?utf-8?B?V0Myd3U1S2huN3RPUVlTNnlHczd1WW8wLzFSMk1jbk9RWTBFTThJM0YxWkVk?=
 =?utf-8?B?ZDZvKzZSMVFHZGQ2bHI1M1JSYyt2UEdEUXF0dFRveUFhSFIraitBU3NDS01U?=
 =?utf-8?B?NmlMNzFOUU1TT2c4c2g2ek5OUVNGL1Z1VFF4MTN4eWdGYnJ6R3NDNXByV1RW?=
 =?utf-8?B?REZzU2N3T3AraXYrMjdaYlZzcFVsWTRhUHZQUENRak9xY1lBbFRrOU9XMk5p?=
 =?utf-8?B?cGFrTWowbS9WRU1zcHVUdUlRQjFYKzBudno2MWhLUTlKMXFpUXUvRTMvZzBL?=
 =?utf-8?B?WHRBTE5NQTBNeTZ4QXRDczJnejFWTXBGNzdTTUZjbUtBUXhLeWlSTnlHd2xR?=
 =?utf-8?B?OXFsOHBTRDUzMnYwdzBiTzROcERGUlJ0R3Z1UlR4aXU0cTdKWUNTaUh6anI2?=
 =?utf-8?B?V0ZaRVdlRWh1dFVnbEFDNGphTWxoQUtzNlg2NFBhWEtNenRmVUE5ejBoY3lv?=
 =?utf-8?B?WDZWSVd0bm14dXFPM1EvanZuWHllN0haK3ZyU0h3QmFhVEJLYzRpR1VhYXEv?=
 =?utf-8?B?bXNwTWVwS05sc1hxRnRES3NhMUpWMDRQdjdLTnF3MUVXdlUyK0pZVlNEV3pD?=
 =?utf-8?B?eDBHUlBvbGM0MGtKQ2hSUzJvYWZnNGg4VXdlbVlyZ2pIZVpnR084OVFYZi8z?=
 =?utf-8?B?Vm9naWt6YjhQYTJuK01qQmZ3aUUyaXZGMnlPVTVGMWM1K1hIV2V1S0swYVNV?=
 =?utf-8?B?U0dmcEl6TDkxWmlaQklGdGFuZkRlYVcrd2N2elFaeEV0MVNzYnRodkF6bXFI?=
 =?utf-8?B?NklQNnFyUkRnempTb3RFNm16S055OGhONFpwUjhTL3A1d2pIWlYxVTV0VkdC?=
 =?utf-8?B?b2hjVi9pZTVvMndKV3V4WG1KbXlDaUZvN3hERkhCM2NVNVZVVitGLzVscHlZ?=
 =?utf-8?B?bk5VUWcrMHFvUjFBQ2E1UFlLMjVTL2M3NlZNQTA3NXJjc2JaSlRrWjcyR0F2?=
 =?utf-8?B?Nms0eGk5S1dLNVNzOUdvbzZ4TVFCd2k5S0taR0RxOEkzaGUwdyt4RzM2Nmdt?=
 =?utf-8?B?STZXdk9aUW5UR3FJbklnbGtOMVAxbGxYRWRzb0FjNnZiSzVpTlBUVkpnaU01?=
 =?utf-8?B?Q2w3NnYrVlBlQWlRWG5kS2l6cEUvNTQvY05tc2ZucmRLcnNXNnN1blV5U1Ir?=
 =?utf-8?B?dmpSQVNYRjZpL2c0aDB1bEttU1dXUGVqbHR6KzNXZXF0VC94QnpSdHRldVc1?=
 =?utf-8?B?WHRONzlqcDhydWh2ZUhGZFMybkJzUlpkb3JMOEZTYzhNSGI4QVVXbEZzMnB3?=
 =?utf-8?B?VnNIZGM2U2NieEdDeldndGhCVmU5N1V2a3V0YWNtMHlrc3hwTmt5RHZSb0or?=
 =?utf-8?B?Y0FtdlBLVkpTSXB6OFFEeEJJSU00WlFRYlFtWU42NnlGTFhhcFEzYm5jK2Jo?=
 =?utf-8?B?SVNHRDJzaEpsTVJWR1VCRm45SWR5UGxiZzdHV0xNbUhRNmgwOGFST0lEaHlq?=
 =?utf-8?B?bXNoR1RrWFAzU2c2NG9SM29HWDY2QkVjSW5SMUQ2M1pVaGtZQzZ5VzZBckJR?=
 =?utf-8?B?d3pIL2R1VzRQVmxXaGY5K0VCRkloTVN2UWIvejVuTFREUnNHVlo3TjlxL0Iz?=
 =?utf-8?B?RklUUmh1TERiSXJEeDJFTVlqRW15d1A1cXVSTzRsRE9waVlJQ0RGMDlsc3dq?=
 =?utf-8?B?SlZyMVJMSzRlU0lpdDdqbWlhdXUzV2ZSUnE2UW1KOHZTRXBScFRyRjFkWStx?=
 =?utf-8?Q?b7ydWdyONScxxR4H8h7K0/4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0dc111c1-330a-4b0d-9c7c-08db5aa7fe96
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 09:36:18.3075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3NY92DKcYR8oKDNd+kfynyf5ln9pXxIJPqlsQJEBb0zkYYbk+OZ5xyvk+peBvmVBn0JjbaFXV7Y1NOODE6+lwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9328
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11.05.23 19:58, Ye Xiang wrote:
> Adds the transport interfaces for various LJCA sub-module drivers
> to communicate with LJCA hardware. The sub-modules of LJCA can use
> ljca_transfer() to issue a transfer between host and hardware. And
> ljca_register_event_cb is exported to LJCA sub-module drivers for
> hardware event subscription.
> 
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> ---

> +
> +int ljca_register_event_cb(struct ljca *ljca, ljca_event_cb_t event_cb, void *context)
> +{
> +	struct ljca_event_cb_entry *entry, *iter;
> +	struct ljca_stub *stub;
> +	unsigned long flags;
> +	int ret;

Uninitialized variable

> +
> +	stub = ljca_stub_find(ljca->dev, ljca->type);
> +	if (IS_ERR(stub))
> +		return PTR_ERR(stub);
> +
> +	entry = kzalloc(sizeof(*entry), GFP_KERNEL);
> +	if (!entry)
> +		return -ENOMEM;
> +
> +	entry->notify = event_cb;
> +	entry->context = context;
> +	entry->id = ljca->id;
> +
> +	spin_lock_irqsave(&stub->event_cb_lock, flags);

You are using GFP_KERNEL a few lines earlier. No need for irqsave

> +
> +	list_for_each_entry(iter, &stub->event_entrys, list) {
> +		if (iter->id == ljca->id) {
> +			ret = -EBUSY;
> +			break;
> +		}
> +	}
> +
> +	if (!ret)
> +		list_add_tail(&entry->list, &stub->event_entrys);
> +
> +	spin_unlock_irqrestore(&stub->event_cb_lock, flags);
> +
> +	if (ret)
> +		kfree(entry);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_NS_GPL(ljca_register_event_cb, LJCA);

	Regards
		Oliver