Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f548084-3739-b0b0-8a18-1384393fbfe1@intel.com>
Date:   Mon, 22 May 2023 17:39:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v2 10/11] KVM: selftests: Add tests for virtual
 enumeration/mitigation MSRs
Content-Language: en-US
To:     Chao Gao <chao.gao@intel.com>, <kvm@vger.kernel.org>
CC:     Jiaan Lu <jiaan.lu@intel.com>, Paolo Bonzini <pbonzini@redhat.com>,
        "Shuah Khan" <shuah@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        "Borislav Petkov" <bp@suse.de>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        "Zhang Chen" <chen.zhang@intel.com>,
        Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230414062545.270178-1-chao.gao@intel.com>
 <20230414062545.270178-11-chao.gao@intel.com>
From:   "Liu, Jingqi" <jingqi.liu@intel.com>
In-Reply-To: <20230414062545.270178-11-chao.gao@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmtwSkEyb3lyQTRDQkRubjhWRUk2MVFGdXIxVGVHNVNYWVRDelhVd3dJbzQ4?=
 =?utf-8?B?OWRCT0lIN3dXelJVM295NXZ4QWg0SmN0M0lEMXRIbXJ3OWRGRFpyYjFISG9Q?=
 =?utf-8?B?d2FTRXNOV2l6dFlieGhFNmQzbGE3eXBERFNZZUxtSlJhRDFQZStYN2xQeSth?=
 =?utf-8?B?SHZqWU11VFAwQkdCYTFGWDliOEZ2SWJudnA3eFdFanhPVy9kMVlYMkhLaVhP?=
 =?utf-8?B?NjRMdzJIYXN1bjluU2VxczNyUllnaldJTlhWazVPTFNQajBFR3dWTkxGVXhV?=
 =?utf-8?B?dU5oYkRQNCszVnMrbEZLaUY5Zm5ZSGhaRWd1a0Vxb3BaeWdLOStZT0pOcFZl?=
 =?utf-8?B?SnB4MEV4b1lrZzlvM1psZlA2WWJCSUt6enVjanBLMmlxOXFMeFZqWE1qYjA5?=
 =?utf-8?B?aE9Gc1k3SktxeWdDOUJicEwxQUZBOGNnSitSc05NQmRaMEZ2SFRQTThFWWRq?=
 =?utf-8?B?bS9mS1dYRE9SVWo5TnV0bVRNOEZzS2ZiY2lSdkYwWW0zOFJXeENBUkdkKzlk?=
 =?utf-8?B?ZlFMeEtjKzdHQ3lJMmZjNTFMQm9hMlFsdE04d3Z1dVgrSWY2TW92T0pudy9J?=
 =?utf-8?B?OGlHbzYydWUxR1g1Vnlvd25TQVdyV20zamhwVDhxYnBGc1ZYcXVuaGJ5VnNU?=
 =?utf-8?B?WklOYzl5WHpwQ0ZFd0FQdUpMTGdCUVRjb0RYTUpFa01ZS3QrV2F0YmxONGt0?=
 =?utf-8?B?RU1mMTU5VUVPSjdRUlQ5WWM2NnJvS2YyU1RYa2hLRElUZnViMUoxbGRHb2V5?=
 =?utf-8?B?QzRUUU9QSFY3eDE3d2hlR2E0VEIrd0ExaFdnL3k5RVNiTzV3dUZLeWJ4a2Ew?=
 =?utf-8?B?eEYyRFJyUFBMNWNrT0xQb0pLeXA0ZGFQS0J5Z1c3NDZGYTdhQ3lJRGNEOHND?=
 =?utf-8?B?ZDZTRC9PZHF2K3RwVzZwUzMyWE5TV0Z5SktKOS9hOXJpcW9MVE1oMWtiRC9M?=
 =?utf-8?B?bVJ0bkhaOWhKNWRySEZjalRzeFJxNGFHOWxlTHZoYU1YZ3VhY0JncmFRTHA0?=
 =?utf-8?B?bC8rZmFSbWREV3pyeHRHK1hZVk9lNldsTExiZXdwVGFpYXZKQkFxWGM3Q2xX?=
 =?utf-8?B?MDJhSHJmaWZ4R3BkQWlvMThhQTdFRkZWYWVSMUpxZmRJbjZMREhrTkhrSTFB?=
 =?utf-8?B?UGhiUktRUGViTnRZcnFPWFV3WGQ5UEFyaTBHUHdyRkVSelZtOUM0TXZmajhw?=
 =?utf-8?B?SGZBWmEzekozK1J5VkZjWnVjZW1iUTJ2QjJSTlpGNjJGekNTTEt1b0lXYUNi?=
 =?utf-8?B?d3dnYW1vZEVOb3FqL2duVjF2bEFNcUdOR3RHK2s3RW1EZVBvRG5kb1hORk5J?=
 =?utf-8?B?ckdIRnp3SXFwcmMzbkxFYmZINURTbmd4cUJlQ1lVdGxEWlhGakpBcEtEc2xJ?=
 =?utf-8?B?cDFrNVc1eTRLMkNhajZqNm0vYmc4QkZCR3ZZd243eElQT1hhWHVwSVNDODN3?=
 =?utf-8?B?dXB5cTJ2WDRGRFpxbTJQZWM3ZTRHOW9IMmJBMnFFOWtlVWdzRGsyV3N6MGxT?=
 =?utf-8?B?SHRQblFtQUFtR3l2b2ZtSFNiMExtYlEzZ0thampPaWdMMiswWUJheWJZY1Zw?=
 =?utf-8?B?d3JXQmFqeTlrT3YrWll4YVp3cmZMRlpRN3dzdmR3RWZyU2UyRFZVbFp0TXRq?=
 =?utf-8?B?VlRldWlzZDJoTHlLOGhaZkk4UVA0b0djWkIrTlFIOHJjZTQ0M2k0Y002Tk1M?=
 =?utf-8?B?NmJRcEw3WmxlZ0k3dVB3dU1QVm5wMlNiclBmSm02ckNua0ZpdmZ0S21GQlFQ?=
 =?utf-8?B?QldwNnJqMEFZVlhyaTFwcGtVajNHNThoaXQrMWhqY0xQbXRnNGpEOE02bUFl?=
 =?utf-8?B?WUk3VWM1aTJ3S05vOVVEUWdkVGRDVFd4cGR2d0E2anVnRExyWUZFOWZiV0hl?=
 =?utf-8?B?TkdMdzZpa3lkMlNjaVdVeXBPeHF5QjYxYk1rLzJLL29YR3VodTBrM1A2Y0Nw?=
 =?utf-8?B?MHk3SWJHSmlkNURXa1dVWXkwRWtxOHpXYitOVVI0cTVmYk9vVTdBbDFoSUFN?=
 =?utf-8?B?SEd1R2NOdyt5Ly82bi9vY3ZUWU93czlxMEFmRG9QOXZ4VnY0bjlVbmtDU3RC?=
 =?utf-8?B?dnJzV1did0t0T1VleSt4cWVqMWxQYVZlaHNPUTd2eEVoYjhqN0VGWHZqR0xn?=
 =?utf-8?Q?mPyqDd1d9qXHbFJ890QuHS2d6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca662926-89a3-44d3-78f8-08db5aa87ea1
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5469.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 09:39:53.2170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l44tPTMY0Rz2oENkK9aMEfnlSoVXnK+uAAQ/MNJm6eHfwxSRJ/8lhQ6AlCEnRE9njsyZkbXiUb4EUlbYZDnBmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4520
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/14/2023 2:25 PM, Chao Gao wrote:
> Three virtual MSRs added for guest to report the usage of software
Seems it's better like below.
s/Three virtual MSRs added/Add three virtual MSRs ?
> mitigations. They are enumerated in an architectural way. Try to
> access the three MSRs to ensure the behavior is expected:
> Specifically,
>
> 1. below three cases should cause #GP:
>   * access to a non-present MSR
>   * write to read-only MSRs
>   * toggling reserved bit of a writeable MSR
>
> 2. rdmsr/wrmsr in other cases should succeed
>
> 3. rdmsr should return the value last written
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> ---
Thanks,
Jingqi