Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a33654a6-71e0-07ac-a612-b1f7aedebb36@suse.com>
Date:   Mon, 22 May 2023 11:50:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver
Content-Language: en-US
To:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org
Cc:     srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
References: <20230511175844.185070-1-xiang.ye@intel.com>
 <20230511175844.185070-6-xiang.ye@intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230511175844.185070-6-xiang.ye@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnI5S0pFNE9XNUFHT09NNG1FTEZPTndOYUF1Q3NUVk91NjlQczVEUmo2S3cy?=
 =?utf-8?B?OG5oNUc4YWFNN3AvRlJvQ1JPREd2OVBqUGZlNUUzSEp3T2ZtcEVFZnU2eWhR?=
 =?utf-8?B?bEZrTERHdHJkeHM0RXp1TUE1bkFrUWF4T05MOXA1eGQzQnRBUml0dTRSVFFp?=
 =?utf-8?B?Y1NVQzB4SUxUTkk2SGVpcjBKSXRyc0VNZ3lIM3ZkUk1OZmZYOU1FMGZoYjFW?=
 =?utf-8?B?QS9sUTFzYWlGeGlsRXRudjUyOUZIZlNoYjFBekl2T2ljSkJnMnNSV2xZb3Q2?=
 =?utf-8?B?V3RMdFZnK0RLeXB3SlJ4aFJWa3FmMks5SEdkaXVvNFBZeWtTcTAyRnpMc2k4?=
 =?utf-8?B?NVYyTS9qWHhiRGVKQTNQMTRsdHFNbmZLNFRhTEgyTlRMZ2x2UGN5WnhCME42?=
 =?utf-8?B?d2Y0NkQ0bnZWYURJdlZXb2ZhUC8rWC9CRkp3djhiSHFUNnJFYXhhU05kQW1P?=
 =?utf-8?B?dEl3RWU2V21QOHFYc0NidkxWSVZFWUdFcDdrR2RyWWlTVDdES041Y1B4VnhH?=
 =?utf-8?B?ZWFCd2JGSlhhZ1AwRFFCWVYzTXB6SXo0NkJoZ3NvTWR6YmhPUEZMKzBFa3pl?=
 =?utf-8?B?UGZtZWZzY3VqdnNtbzQyZllicjN1Uks1VGxmdFhsNmdTT2VlQnlIV0U4a1FY?=
 =?utf-8?B?NEZlRDhSS2RqQmNiR1pzOXk5eVk0bWFob25FMkpUZFBJcUJJVTF3OEZFaTdJ?=
 =?utf-8?B?RTZFZytOeC8wVWh2N2g5cjhhMkc2SnN6UzE0NW5JTDdHdC9hNklqbXM4Ykt3?=
 =?utf-8?B?RWczaWNwczFlNVllWHgvclZGTlR2NXY2YW85K21EUldVQ1UydmdxR3R5dDB2?=
 =?utf-8?B?Z2JPcXJEcjl6SkwzaGFoL0VLU2VhQ21zcHZNeWh2MVhDK2Z0UWVqMUk1RzA2?=
 =?utf-8?B?aFhSa0JoSFpWbDh1UC9hQ1RDZEZhY2pNdlRNeFRIbndycTdlMEhuVnZjRjhP?=
 =?utf-8?B?M3M1TU54VU83Z01UUlQzeFROeFphRFdvcTFwclJ0N1oxMVNFRzNtdjg1d2Z3?=
 =?utf-8?B?d1BjdWl0YWRmdE1HaXdYSDJkK3Z4RnpWdG9CZWM1eTQyL1g4VnZkQXIvUUFM?=
 =?utf-8?B?WUFVMm5KcDl1Q1lMbmswVFJEUnQ4WUpMMmpkOFBkMHRtVyt1UmFDbU9iWjJo?=
 =?utf-8?B?S2p4RDluSCs3SjZ4NGt2cW1tRlI2ZUpaYTNGQ3hYYmUvSFd3ZlV5emlPVHdj?=
 =?utf-8?B?elA3emZudEg0SnZqaUlDc1hHcWRXQTBkQ1JnK0tyZ1lTQTNqTWZLRmdLcFlL?=
 =?utf-8?B?TUdzekN2cTNYUkt5bkZCWTkwVGxYVzVnTmdvYkdsb3BxS0ZSK2ZMMzlHQ0ZZ?=
 =?utf-8?B?TkNHZzl0dHZzYmtJUDl4cnpJZDN6QXMzWWQydHR2N2ZRQ04xZy94d25OQ0Q3?=
 =?utf-8?B?akRqOXdnTWtTSGVFRHU4czEzWXVvRUM4NHpkVHNxV1B3MjV1SDM3Njh1YkNY?=
 =?utf-8?B?Y0ZIbWtVTVhLa09rYkJpTXNJdUZCTTV1NUcrd0dseHN1czNaN29BaTZJZ1k0?=
 =?utf-8?B?RVAycmJtS2RHQlJqaHZ2aDFpbWdIZ0lCbVN1NUpLdW4rZHhBMTIrZStNTkYr?=
 =?utf-8?B?OG8zR0R0WGhLaGg2WnE3cFlSZ0hBbXpQOHcyQlZJNysxanhocWVYaEwrV1Y1?=
 =?utf-8?B?c1VTY3RUL3QzR044TDhiRFdiMmQveWNxS2IwZ3lXNk9IZ3Y4clpJWVZHbmtU?=
 =?utf-8?B?UFJiZXAxSTRQb2JMOHQreG56T0RLV1ZDSHpnc2lHTlJpdWhOUXdhamFvWWgy?=
 =?utf-8?B?bnVNRVBqVmVZVTRTWkErNmN2dklSbC95Nnh0cWhIYnNlV0ZzRnp4a3FOc1dw?=
 =?utf-8?B?anU4T2N2NUcvN1dEOTkxemlwUmg1cmpHWkc4Ri9jSjhaT2RaWEFPcW9JQlZB?=
 =?utf-8?B?aDJublRTWEJQRG1BbGh3VmI4L2xQNHNhbE1rU3RRNFc2aDNjcFpveEZkWXox?=
 =?utf-8?B?QytyWXFpSXM2V2ZUMzZpbGxNdll5blphcjB4OGJiNk9Zcnk1VFpCWGdvL3VH?=
 =?utf-8?B?ODI4Q0FWRWJjYVFxemZOeEpNa0R5VnZEcm02T2xJakNBSmtwTTBreC9udWNN?=
 =?utf-8?B?TGRFRXdOMk9ZdlFSSWhBbktOdDlvRzNaRzZLUC81R3ZUZHpMTlc5ZllXUWkw?=
 =?utf-8?B?ZGpjTm5JZUxaV0Q3V0l2emJ2ZDQ5amNxNHlpbzc4cGIxMlJEYzg1WUU5VzJh?=
 =?utf-8?Q?ZpsDJC9CCV2qcvtHGJXB/Po=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdac58fd-3cda-4c07-bb6e-08db5aa9ec9e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 09:50:07.2066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e1eVfl3h16v6WUaoPq6a9nP2ZEEosAuHBE0fUmPJ8wP80Ag6rIqfQiHl7XO26skWvK8zXwXEhDhGV/JO7yZszA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8596
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11.05.23 19:58, Ye Xiang wrote:
> Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
> named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2c
> module with specific protocol through interfaces exported by LJCA
> USB driver.

> +/* I2C Transfer */
> +struct i2c_xfer {
> +	u8 id;
> +	u8 slave;
> +	u16 flag; /* speed, 8/16bit addr, addr increase, etc */
> +	u16 addr;
> +	u16 len;
> +	u8 data[];
> +} __packed;

Where is this needed?
Why is it defined __packed, yet the internal endianness
is not declared?

	Regards
		Oliver