Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2720239rwd; Mon, 22 May 2023 03:22:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4IB4wX7YA8hN4P27qjQfOlfTnjG1daOIKsa5QtjeZ96QN1lZ31Rb6b3yzi9T8Pl773xZeT X-Received: by 2002:a17:90a:3181:b0:24d:fbaf:e0b1 with SMTP id j1-20020a17090a318100b0024dfbafe0b1mr9435443pjb.19.1684750971862; Mon, 22 May 2023 03:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684750971; cv=none; d=google.com; s=arc-20160816; b=n76XCgkO1VFuXWVqcXAvo0LLoc/dU1bWcmuou2r4H+jlNltYMrrXiVj5q4xn5tKoNP YXF2f6/+PRQXsjxgfQ/TrSx8kHVbTyrijBblSGlj5R9HAbVJl7UOIQF6AOOjPJ5NAsue +Utc1q6qncXt7r6LxRWRpdmJijpA1x9GGGyKS7nYjnsQ1wEW2S2pLU4zrYIA9Ja0eDLG i7Uez+ubY6KY+/RongbBz9oPC1IKWjFnQ9vSDS/ZD3cnUhA0if+eX9+M1NciTAVw4pMW qSWjmHO/fUGw6+ZTor348I4Ko/fNr++tbyzSpdUdd+GDyoEOuXjK/n/HYVlHZ6AWa6iP dTtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=MVzxx737oy6u2gxeyxGx37w11GpVOi1qAeLzN9i/+hI=; b=VBlAX4gnIz3V0alBwUS3pP3qeXmMNLhmEXzmKjwMN3cGayoFPVWSw/gb1OgkD5HuSd 2Kxk+UyAEkcaV4VsZAvykSV0zNED83y4KH49MLniP7MeSrL4kujSJTRYRLO8owW1Bn5D EQJFXSWE3Ts7UWYaNuQcG0GiNeGHzS7hlB1gurio9/gyvXwOVShSKg0044ZuS6AbdWLt kPdYyOVG+DkgQl0jkRFWWy3Rf6JYkNTR9QnCpTP9gPUcNpQkENyNlIK3NOrShKoKhzwV Y2ELhh5fgUpEVQL+zQhELfX4cWVq6By4y8+gZfbNvKqcDYVAZnxgXR7+A6u6/GE/OPOP 6Szw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="m/nB7XH7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o15-20020a63a80f000000b00524eef9225bsi4297745pgf.550.2023.05.22.03.22.39; Mon, 22 May 2023 03:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="m/nB7XH7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbjEVKSx (ORCPT + 99 others); Mon, 22 May 2023 06:18:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbjEVKSp (ORCPT ); Mon, 22 May 2023 06:18:45 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC315DB; Mon, 22 May 2023 03:18:44 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-75b0df7b225so39524885a.1; Mon, 22 May 2023 03:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684750724; x=1687342724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MVzxx737oy6u2gxeyxGx37w11GpVOi1qAeLzN9i/+hI=; b=m/nB7XH7qiO2u9HN6szLdHxp/U70Q0TJwDRaVMZwRzkAHAgNbY0KhigzZeTAGfB/jq LPkC82qMne//O39/cz7kgin4oFL9ECLBDg9WVfORI1V1kaRLJXPUt92vmPaf9Tqfd+T+ EL3YAHlIV5Sc+ZsEtoBenTqnwayI6qZhatmFOaUTBGg9fT7XLskj4LqQSXQ9/jBpG6NF 7EtKkQe/XI4MEMBGGO+ssgGRRRUvrf7tt8RMee6xiLAZ8SFc/FT0KUrIsyuTnXF4Bfk0 Qw3vIcWwCR0xhgl/XFRGcNCpcMCiZaRUStGSahpK72w1sGdMUMyWfNDjvkl9bIJ8WnuR iyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684750724; x=1687342724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MVzxx737oy6u2gxeyxGx37w11GpVOi1qAeLzN9i/+hI=; b=MuioZzAyGfRyB/Ri7wFLcJFwZrM+b1heIXyN4XAeENt0zty9fWl1U+LWdHiU4y4i6i JV+jYhXXoTUC+1SGxJAnNdZ5Ird8WeDbnYzE7eekpUeioVjZp/MqPvMwUUf0emokkLcO NbqDJasN4EAAgxB5Nr9LbNbRvuzMAg2yQmOvQ3x1wV8P6mMXdiBF/3P7VP8o/IOX+1MW XenY6a447oxcOxN+us+H0vWgvYBDrr3CXFmp9Op8gJuLBdpbeTrEtLW8WgnZ16JXlvKQ Q96tVQGpxjd/l8dfM+UuWh+5fOXarkhvr50ynJZr2YW8l6eBoRQxTWv6GD8PKriv9u2l wQ0w== X-Gm-Message-State: AC+VfDzmilRGkRNJ4wwmlFPPXtMMenGDdq1eeEhmEQsNKSzbaUMF4ohu evazfaol5jS65LiNzhyGZ8jJzKIch4t9EbbWuLg= X-Received: by 2002:a05:620a:47b8:b0:75b:23a0:d9ec with SMTP id dt56-20020a05620a47b800b0075b23a0d9ecmr34216qkb.66.1684750723930; Mon, 22 May 2023 03:18:43 -0700 (PDT) MIME-Version: 1.0 References: <20230521225901.388455-1-contact@artur-rojek.eu> <20230521225901.388455-2-contact@artur-rojek.eu> In-Reply-To: From: Andy Shevchenko Date: Mon, 22 May 2023 13:18:08 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] iio/adc: ingenic: Fix channel offsets in buffer To: Artur Rojek Cc: Paul Cercueil , Jonathan Cameron , Dmitry Torokhov , Chris Morgan , linux-mips@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 1:15=E2=80=AFPM Andy Shevchenko wrote: > On Mon, May 22, 2023 at 1:59=E2=80=AFAM Artur Rojek wrote: ... > > + u16 tdat[6]; > > + u32 val; > > + > > + memset(tdat, 0, ARRAY_SIZE(tdat)); > > Yeah, as LKP tells us this should be sizeof() instead of ARRAY_SIZE(). > > > + for (i =3D 0; mask && i < ARRAY_SIZE(tdat); mask >>=3D 2) { > > + if (mask & 0x3) { > > (for the consistency it has to be GENMASK(), but see below) > > First of all, strictly speaking we should use the full mask without > limiting it to the 0 element in the array (I'm talking about > active_scan_mask). > > That said, we may actually use bit operations here in a better way, i.e. > > unsigned long mask =3D active_scan_mask[0] & (active_scan_mask[0] - 1); > > j =3D 0; > for_each_set_bit(i, active_scan_mask, ...) { > val =3D readl(...); > /* Two channels per sample. Demux active. */ > tdat[j++] =3D val >> (16 * (i % 2)); Alternatively /* Two channels per sample. Demux active. */ if (i % 2) tdat[j++] =3D upper_16_bits(val); else tdat[j++] =3D lower_16_bits(val); which may be better to read. > } > > > + val =3D readl(adc->base + JZ_ADC_REG_ADTCH); > > + /* Two channels per sample. Demux active. */ > > + if (mask & BIT(0)) > > + tdat[i++] =3D val & 0xffff; > > + if (mask & BIT(1)) > > + tdat[i++] =3D val >> 16; > > + } > > } --=20 With Best Regards, Andy Shevchenko