Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7fa9ffe0e6cd546b8ff3826379c2cf78e5342b6.camel@gmx.de>
Subject: Re: r8169: disable ASPM during NAPI poll locking changes --> BUG:
 Invalid wait context --> PREEMPT_RT pain
From:   Mike Galbraith <efault@gmx.de>
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Date:   Mon, 22 May 2023 12:41:21 +0200
In-Reply-To: <20230522080604.MgUGcyeU@linutronix.de>
References: <e55be0ae115ad6494ebb48fecd03e5c2fe528230.camel@gmx.de>
         <28727b435c143f15feddffb4c29095fee2500dff.camel@gmx.de>
         <20230522080604.MgUGcyeU@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:8NjwXDj9Ajw=;6hXmc9tYXbQV5is+P+p15s8OZds
 osuXCGr16efZNffEq4Wor+FLJvabhAB2Nqcf5iYCZeCK2LnRcqseVmvoDOnkVkut2S/u8Xdph
 65BtUVs9veBLlgGAG2XFRQJUezxwUY8at+sNeFxJICwr0cCTgltjl2G5Frj5xOSAyRYcq5n/T
 5NM6b7uxd+w74uJnL6v0ivO8Y5/EDGNVnys5rXTvKNsiP1JsUmoS7cYHuI/zeLRGvss3uBuus
 GsUC49s4hCcBf32Z1RvbBiK8dTlWHdNdDx4KuDZ3ZMt/HND5WlRK0U0AQOgmSpa8cl+osBkTP
 8xXgmePm4QcZUu+UN/yBTOLTsJ4UxbTq7/t3E2bdeLefhjmt5ISnSLmlXCCxnRr5Wuu8NPVUb
 KR3KRDX/6JFXNr9zU+rGr3FBb2eYXc7MiM9zppAq5mN8qD03VEuD1MlsTUWGXr3zTh2ZTUFFZ
 nTDrlY6S0mzE75og0s8PUhr5Nj9XUnJrgkDQ/SIW3LWi60MIo4yiKIftIehi6heqsSfdAphuP
 CTu0gj4y34VsFSIMgOsWTK1Je4ZCNZBhGDV+yFghzLFVIzrN67WiGY2L+SsrKBkVkrOWSVwqq
 HEKtksod5CS0lMgD3z6hIA+EgQUu3/17cAvZydhco1cpBRQ2q59sCCbx7NmoAHw7/5ujFyssl
 4yMaFcdbBx9ptKpMrA+oPpyVTG5MKfBzP32Hdw37Q2q+QdK+OziT2C+qY1e7fawS6MREZ/nf3
 bMOclQBPDKtrKqQSbzSZTlW6baFqfKR/yQI3NV9odr7DyP3e8lOTLgS/yMnLaOd7loH8tk9ye
 EJafH/seAyNK+GoHg2Vxbak+DIxIIqgCOqo7Y6goLAcUDUb83079ovOseEN5/9bILVHoJelM+
 bddv9XrIeKg5bThm1FthxxrHRM62T7l4zX5zW/dctjwQuf4eEKZky1S6SRnRRi057D52kEPzH
 9wfRT7Un3gpb41CAGoMSg65+7ME=
Precedence: bulk

On Mon, 2023-05-22 at 10:06 +0200, Sebastian Andrzej Siewior wrote:
> On 2023-05-21 16:27:10 [+0200], Mike Galbraith wrote:
> > On Sun, 2023-05-21 at 08:03 +0200, Mike Galbraith wrote:
> > > Greetings,
> > >
> > > The locks added to prep for $subject induce invalid context moaning =
due
> > > to not being raw locks, but if I do that, the hold time does very ba=
d
> > > things to RT.
> >
> > The locks aren't really 160us horrible. The GPU was enabled (oops),
> > nouveau then makes box horrible for RT (and graphics:).=C2=A0 With GPU
> > turned back off, the largest trace I saw was 77us, which jibes pretty
> > well with new max of low to mid 50s without ftrace running, or up a ta=
d
> > over 20us for this now pretty old commodity i7 desktop box.
>
> So you are saying it is all good?

I wouldn't say good, but not the sky is falling 160us bad.

> I've been looking at the r8169 the other day and it seemed all good
> since it was only scheduling workqueues and NAPI. But now I see this
> mac_ocp_lock + config25_lock which are acquire in hardirq context but
> can't. This needs to be taken care.

I did a patch converting the locks, but didn't post it hoping maybe
those locks weren't really really needed.  It doesn't matter for my
box, as it doesn't do anything but give RT chances to trip over bugs.

	-Mike