Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 13:44:30 +0200
From:   Michal =?iso-8859-1?Q?Such=E1nek?= <msuchanek@suse.de>
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Cyril Brulebois <cyril@debamax.com>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/ofdrm: Update expected device name
Message-ID: <20230522114430.GA15906@kitsune.suse.cz>
References: <20230412095509.2196162-1-cyril@debamax.com>
 <20230412095509.2196162-3-cyril@debamax.com>
 <CAMuHMdW4rZn4p=gQZRWQQSEbQPmzZUd5eN+kP_Yr7bLgTHyvig@mail.gmail.com>
 <5694a9ab-d474-c101-9398-eea55aab29df@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5694a9ab-d474-c101-9398-eea55aab29df@suse.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Apr 24, 2023 at 11:07:45AM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:
> > Hi Cyril,
> > 
> > CC DT
> > 
> > On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois <cyril@debamax.com> wrote:
> > > Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> > > as spotted by Frédéric Bonnard, the historical "of-display" device is
> > > gone: the updated logic creates "of-display.0" instead, then as many
> > > "of-display.N" as required.
> > > 
> > > This means that offb no longer finds the expected device, which prevents
> > > the Debian Installer from setting up its interface, at least on ppc64el.
> > > 
> > > Given the code similarity it is likely to affect ofdrm in the same way.
> > > 
> > > It might be better to iterate on all possible nodes, but updating the
> > > hardcoded device from "of-display" to "of-display.0" is likely to help
> > > as a first step.
> > > 
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
> > > Link: https://bugs.debian.org/1033058
> > > Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
> > > Cc: stable@vger.kernel.org # v6.2+
> > > Signed-off-by: Cyril Brulebois <cyril@debamax.com>
> > 
> > Thanks for your patch, which is now commit 3a9d8ea2539ebebd
> > ("drm/ofdrm: Update expected device name") in fbdev/for-next.
> > 
> > > --- a/drivers/gpu/drm/tiny/ofdrm.c
> > > +++ b/drivers/gpu/drm/tiny/ofdrm.c
> > > @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
> > > 
> > >   static struct platform_driver ofdrm_platform_driver = {
> > >          .driver = {
> > > -               .name = "of-display",
> > > +               .name = "of-display.0",
> > >                  .of_match_table = ofdrm_of_match_display,
> > >          },
> > >          .probe = ofdrm_probe,
> > 
> > Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device
> > name".
> > 
> > https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com
> 
> Sorry that I missed this patch. I agree that it's probably not correct. At
> least in ofdrm, we want to be able to use multiple framebuffers at the same
> time; a feature that has been broken by this change.

How did it work before, though?

We did not have this device name clash, then we did, and it was solved
by renaming the devices to numnered.

Now matching the first device should restore the previously available
functionality, mathing any of the numbered devices would potentially
allow to use multiple devices.

Or am I missing something?

Thanks

Michal