Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next v2 0/6] blk-wbt: minor fix and cleanup
To:     Linux regressions mailing list <regressions@lists.linux.dev>,
        Jens Axboe <axboe@kernel.dk>,
        Yu Kuai <yukuai1@huaweicloud.com>, hch@lst.de, tj@kernel.org,
        josef@toxicpanda.com
Cc:     lukas.bulwahn@gmail.com, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com, yangerkun@huawei.com,
        "yukuai (C)" <yukuai3@huawei.com>
References: <20230512093554.911753-1-yukuai1@huaweicloud.com>
 <2b18e6ed-bce0-44f5-5ec4-8903f3c85cfe@kernel.dk>
 <5d53e634-33c2-e040-3c34-6c36e32eed81@leemhuis.info>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <957c8c91-3d7b-0227-f172-7208558b101f@huaweicloud.com>
Date:   Mon, 22 May 2023 20:12:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <5d53e634-33c2-e040-3c34-6c36e32eed81@leemhuis.info>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2023/05/22 20:00, Linux regression tracking (Thorsten Leemhuis) 写道:
> On 12.05.23 16:58, Jens Axboe wrote:
>> On 5/12/23 3:35 AM, Yu Kuai wrote:
>>> From: Yu Kuai <yukuai3@huawei.com>
>>>
>>> Changes in v2:
>>>   - make the code more readable for patch 1
>>>   - add a new attr_group that is only visible for rq based device
>>>   - explain in detail for patch 4
>>>   - add review tag for patch 2,3,5
>>>
>>> Yu Kuai (6):
>>>    blk-wbt: fix that wbt can't be disabled by default
>>>    blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>>>    blk-wbt: remove dead code to handle wbt enable/disable with io
>>>      inflight
>>>    blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>>>    blk-iocost: move wbt_enable/disable_default() out of spinlock
>>>    blk-sysfs: add a new attr_group for blk_mq
>>>
>>>   block/blk-iocost.c |   7 +-
>>>   block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>>>   block/blk-wbt.c    |  33 +++------
>>>   block/blk-wbt.h    |  19 -----
>>>   4 files changed, 117 insertions(+), 123 deletions(-)
>>
>> We need a 6.4 version of the fix to get rid of the regression. If you
>> want to do cleanups on top of that, then that's fine and that can go into
>> 6.5. But don't mix them up.
> 
> Hmm, it seems nothing has happened here since ten days to fix this
> regression that likely is still present in 6.3. Yu Kuai, did it fall
> through the cracks, or is what Jens asked for more complicated than it
> sounds?

Sorry for the delay, I was waiting for the last patch to be reviewed.
But the regression is only related to the first patch, I'll send it
seperately.

Thanks,
Kuai
> 
> Or was progress made and I just missed it?
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> #regzbot poke
> 
> .
>