Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 20:36:23 +0800
From:   Heming Zhao <heming.zhao@suse.com>
To:     =?utf-8?B?THXDrXM=?= Henriques <lhenriques@suse.de>
Cc:     Joseph Qi <joseph.qi@linux.alibaba.com>,
        ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
        Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>
Subject: Re: [PATCH] ocfs2: fix use-after-free when unmounting read-only
 filesystem
Message-ID: <20230522123623.eozzedrogy4oaj3w@p15>
References: <20230522102506.9205-1-lhenriques@suse.de>
 <a57047d6-8f57-3dde-f15f-b24f63d675cd@linux.alibaba.com>
 <87h6s47dxw.fsf@brahms.olymp>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87h6s47dxw.fsf@brahms.olymp>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?JP5ZkavlDewb3fnVucTCnoU4R9beAsE8HzwoKmZnB7qNbgjQ5dlFgsEZKD?=
 =?iso-8859-1?Q?BK+E/2/WagHOcLEMMjKAk2K/7u142o1vzk/7XeoBMze757ESWBf2cJLkwp?=
 =?iso-8859-1?Q?hCKpfkPr8/7bIveHRYJTZNqcIZzbHx60ifiteN2/MR9Bo9wI507cULHcGX?=
 =?iso-8859-1?Q?LM3p+J7V/Qxev0rp6Yjg71dNXXrKMrvyyWU28Ryaiv8vRkyTxdkRrRKNi/?=
 =?iso-8859-1?Q?W6IVtjyQ9YIXAoZp8scNESLFSOLrV9jgssbwW6UCQiCsD8XtHS87f69IeE?=
 =?iso-8859-1?Q?KxaosYr6M1VWKFRhurkvQUnhNSqfzia1XM4iVdZCethGv51TznmEpXuWgU?=
 =?iso-8859-1?Q?8NNS7m5x2rjo6fafk23xUe+REeyyd5IyMiUEYymGroKX94lTsPg2o26CdO?=
 =?iso-8859-1?Q?ctLYW5R5j/jTIHLpkP28Vl8uoWxIBXEYznFJCHUc7MI6o24F9z9NwQoFJV?=
 =?iso-8859-1?Q?jsEQ8MpUHInLccVrGdLAq5aqS0XKvYuhyu9V9+90FOv8dsXcXwx3l+8vA9?=
 =?iso-8859-1?Q?JYLMTkLme9Pve2xVFK8Vx2yVRAjxjzHNpGEb160Nsw56acREEXvtyVA4rX?=
 =?iso-8859-1?Q?B58Eydwu3u6k11epFv41OjGTtghnUq23sb4dY2pDbznKR+qdMwNbh/Ow7O?=
 =?iso-8859-1?Q?eOn/nmhnw9b+XPbChnoaiL2oW/3Inc5kTsO+qct65JeDnn4iOEu4KK3jKi?=
 =?iso-8859-1?Q?JCQhVM6pL/GDFDAa0dIVjbcmw5V9q1at7RLP+Lm47nDoQJXGyDOWwfiC0U?=
 =?iso-8859-1?Q?WdD9sreff/FEYnktkxYvXFz9o+9HXhuS9v3LkHRYuVjMFaSSltbn8u9u/9?=
 =?iso-8859-1?Q?Ts/+bObMcbyG6M8ZJqQOfU5RYHZoxnV7Hgnr8b8anPfVm+TYwgloYZj35K?=
 =?iso-8859-1?Q?t5YlBgGc/1ynE5jK+LeKJFn+wDdPbC/0XkB9AoURz6ktrAMjIZN7NeUeKr?=
 =?iso-8859-1?Q?hTqKzC6dI7Z6miPMDR4E491jfue0K6cV+AmGqsYXZ1Zfga5Hv6DmX8wZF6?=
 =?iso-8859-1?Q?V9NHHbGmMzDXWvYmya/lrbXBoVEjH9oj0nJRnPtvlBl9StFluoYHN3mir4?=
 =?iso-8859-1?Q?A9p4ll7EjAzLxxTAd5V2djcr9QAgEcanXjKfX36Srci1g/nDalPjIHPWXU?=
 =?iso-8859-1?Q?MxHeV8wVYcwtqwuhijNogDld1GMbAez/sftdAyXVM3/fWCbdATW6By98Ye?=
 =?iso-8859-1?Q?azR2KwNIhqQ/SEaomXjZ8+CVj7Uxxz72wb0EZhwjkTocpzllvi6TSNJyd+?=
 =?iso-8859-1?Q?23w90swxY/wB4P4dMTiFka5MYWFL6XZiFtK88CywkwVZecOG2GoihusXwZ?=
 =?iso-8859-1?Q?sinAT7a65uQAuuwUdcunCYSbW+nh9Jq134+UM28x7O3NOukQ1Qk6hr7OVd?=
 =?iso-8859-1?Q?MMQG8xNfi7TaLUyPhEXVcwqUfF3ZNwfJzU+jVI0Kg6s85Qo4Gox7Pkcy1S?=
 =?iso-8859-1?Q?V+RY1LyfxTRzF7MEK6ZdjcIAFI0St1oW91We5zfrN0fbwXKaQkY9Wgg7bm?=
 =?iso-8859-1?Q?pqG9Ic+rNdYM9TRiu1vPbGLO+pIJ3VtL7+CMlNQc0a6tMzs17argj7k3Pq?=
 =?iso-8859-1?Q?e+VCtid6+AybfFI0GPZilnCe9YMJgVfdAwcmbsA+txXgMm97vlistw1VsL?=
 =?iso-8859-1?Q?tRGoK8/EgJRnCH+RxYJtxiw36NuxirOe5c?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77c7d4c8-5eef-46b6-126b-08db5ac12ab0
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB7990.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 12:36:29.7816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PzWmzEmSNPioN3ElFjPu22ho5mfDNMy3m0CLiChDQPM8ZKpG0eINclsdlWMadQJd/5gqDtjO7kxfhqE9Lslu2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7692
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 22, 2023 at 01:23:07PM +0100, Lu?s Henriques wrote:
> Joseph Qi <joseph.qi@linux.alibaba.com> writes:
> 
> > On 5/22/23 6:25 PM, Lu?s Henriques wrote:
> >> It's trivial to trigger a use-after-free bug in the ocfs2 quotas code using
> >> fstest generic/452.  After mounting a filesystem as read-only, quotas are
> >
> > generic/452 is for testing ext4 mounted with dax and ro.
> > But ocfs2 doesn't support dax yet.
> 
> Right, but I think it's still useful to run the 'generic' test-suite in a
> filesystem.  We can always find issues in the test itself or, in this
> case, a bug in the filesystem.

It looks you did some special steps for 452. In my env, without changing
anything, I could pass this case successfully. 

- Heming

> 
> >> suspended and ocfs2_mem_dqinfo is freed through ->ocfs2_local_free_info().  When
> >> unmounting the filesystem, an UAF access to the oinfo will eventually cause a
> >> crash.
> >
> > In ocfs2_fill_super(), it won't enable quota if is a readonly mount.
> > Do you mean remount as readonly?
> 
> Yes, sorry. Instead of "mounting", the patch changelog should say
> 
>   "After remounting a filesystem as read-only..."
> 
> Cheers,
> -- 
> Lu?s
> 
> >
> > Thanks,
> > Joseph
> >
> >> 
> >> Cc: <stable@vger.kernel.org>
> >> Signed-off-by: Lu?s Henriques <lhenriques@suse.de>
> >> ---
> >>  fs/ocfs2/super.c | 6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> >> index 0b0e6a132101..988d1c076861 100644
> >> --- a/fs/ocfs2/super.c
> >> +++ b/fs/ocfs2/super.c
> >> @@ -952,8 +952,10 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
> >>  	for (type = 0; type < OCFS2_MAXQUOTAS; type++) {
> >>  		if (!sb_has_quota_loaded(sb, type))
> >>  			continue;
> >> -		oinfo = sb_dqinfo(sb, type)->dqi_priv;
> >> -		cancel_delayed_work_sync(&oinfo->dqi_sync_work);
> >> +		if (!sb_has_quota_suspended(sb, type)) {
> >> +			oinfo = sb_dqinfo(sb, type)->dqi_priv;
> >> +			cancel_delayed_work_sync(&oinfo->dqi_sync_work);
> >> +		}
> >>  		inode = igrab(sb->s_dquot.files[type]);
> >>  		/* Turn off quotas. This will remove all dquot structures from
> >>  		 * memory and so they will be automatically synced to global
>