Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42270537-8ed4-636b-3d6a-8dde8b75aae9@linaro.org>
Date:   Mon, 22 May 2023 13:47:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/1] media: camss: set VFE bpl_alignment to 16 for sdm845
 and sm8250
Content-Language: en-US
To:     Andrey Konovalov <andrey.konovalov@linaro.org>, rfoss@kernel.org,
        todor.too@gmail.com
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230518215235.1668871-1-andrey.konovalov@linaro.org>
 <20230518215235.1668871-2-andrey.konovalov@linaro.org>
From:   Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <20230518215235.1668871-2-andrey.konovalov@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/05/2023 22:52, Andrey Konovalov wrote:
>  From the experiments with camera sensors using SGRBG10_1X10/3280x2464 and
> SRGGB10_1X10/3280x2464 formats, it becomes clear that on sdm845 and sm8250
> VFE outputs the lines padded to a length multiple of 16 bytes. As in the
> current driver the value of the bpl_alignment is set to 8 bytes, the frames
> captured in formats with the bytes-per-line value being not a multiple of
> 16 get corrupted.
> 
> Set the bpl_alignment of the camss video output device to 16 for sdm845 and
> sm8250 to fix that.
> 
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> ---
>   drivers/media/platform/qcom/camss/camss-vfe.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index e0832f3f4f25..06c95568e5af 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -1541,7 +1541,11 @@ int msm_vfe_register_entities(struct vfe_device *vfe,
>   		}
>   
>   		video_out->ops = &vfe->video_ops;
> -		video_out->bpl_alignment = 8;
> +		if (vfe->camss->version == CAMSS_845 ||
> +		    vfe->camss->version == CAMSS_8250)
> +			video_out->bpl_alignment = 16;
> +		else
> +			video_out->bpl_alignment = 8;
>   		video_out->line_based = 0;
>   		if (i == VFE_LINE_PIX) {
>   			video_out->bpl_alignment = 16;

Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>