Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 14:50:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Abel Wu <wuyun.abel@bytedance.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Glauber Costa <glommer@parallels.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] sock: Fix misuse of sk_under_memory_pressure()
Message-ID: <ZGtlCdQwKw3tr58f@corigine.com>
References: <20230522070122.6727-1-wuyun.abel@bytedance.com>
 <20230522070122.6727-3-wuyun.abel@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230522070122.6727-3-wuyun.abel@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yUBH0INB6LVODIznKENzbC3L9UFVIuBps+3LfiqTEBmAbg8ni4F7HUeuXoR8?=
 =?us-ascii?Q?CeMGN/AFa8fq5n1giCcOK08XqjH40fx5pVV4P0zyhYKyaOQmApO4zJmw4afz?=
 =?us-ascii?Q?TmcuwH0nec6zk/mswgp0j1fasHnABFKfKRkCpB1AOYPFkxvUqUsXq1QWYmcI?=
 =?us-ascii?Q?wzTqnmgM+Uhf1/W0Nrc29kbpgFscxCfIo4IlJashSjSebVqBFhFXWATKU0Ul?=
 =?us-ascii?Q?DMQTjPbmSwAWtX9+JpdlD61klz/3Ftl5RKX1k2mPiegyyLCK9a1GBQeVzGLE?=
 =?us-ascii?Q?JgZGrCE5ru65JVmeFggeTZKpayh9a01Kcb87gOzskxt6HBileICPWUAHjOPQ?=
 =?us-ascii?Q?i/fesW+Du3zjeJV7Urj+pA4iUNvcmq0aHhvvEkEnyCfoyAkKOPuQNiiPsO5t?=
 =?us-ascii?Q?XSgwI5pwEYU1BFksjdcJkq57y4mM7SjTonTS6OV4D1GIpNQl6544eAZ0RuYh?=
 =?us-ascii?Q?z7EDzi/G9OIBothakPf0GIoLhXU2CHrnj1WasuFQ6qRBUap2dAhazrRbvb9v?=
 =?us-ascii?Q?m6xmCvkEAPm2zHq9X8w4c5vSOFfvEnbL++tFBNQN9zFBUzM+h7HkQlUMw2hR?=
 =?us-ascii?Q?xnFJB86xF31EGnc90Qwn1MJxZj2AyRu2713yzH6NzSdmKBcvqU9YRNQA5xeX?=
 =?us-ascii?Q?BEUcQsLJm/JHzfBWomIq4f8+mJMx/9EtJXOrDdTw7EIn6Jqpti/LZxBy+qN1?=
 =?us-ascii?Q?6O+BFZ7SkDnOmp6KsFrcDdVWrZsn0jxjSe5qVM3+EGw+AVECSG6krFru5tnJ?=
 =?us-ascii?Q?WEdYAMmM9crNXYnU2nfJVU85ku5yvF8zfXCY5V7DET1BazoKt+yAsK9CPwja?=
 =?us-ascii?Q?bIiLCBE5C7iC0p16t9o0bKaSYN+pGFrSMKqvOU1VgTo3kVcTV1IyJxZ9oqAW?=
 =?us-ascii?Q?VazQvAx1rLjYLQt8O3CmqaL658xtetL19cneG1tKhwnv3qBhAetlLVT8u2PR?=
 =?us-ascii?Q?oGWaiv6LPcV5vFR8P1eTU7LdiClU2MPws6MEY+t0HAgs1v3uI3d0I+AXz9Ui?=
 =?us-ascii?Q?xIHa7ukVjTYBJ7nSt3rdMqRnc5tMBwRvwxAz4DFNb8nJod4lbHrGlXIOf6F4?=
 =?us-ascii?Q?2RD6SRwuIUc60xC8k1GoZTwq2Fz2EkCGdfgbftehwDugoTa19BFjUgpUl1V0?=
 =?us-ascii?Q?bmIFekd00aLWK+2PkUblnYWFC7dA9y1dnhqm+i+yIEHrWUgCr9Ps5mV7IWlx?=
 =?us-ascii?Q?1RnDZjOfATFOGlrVOet1I9He2GIFmkfnj/0tndMFaFCbIQshaBKWAjGOP7e+?=
 =?us-ascii?Q?VBZjXfEFKojufmg3x3s75TUBKAIZrwBqmfL5i+yVHITZUZ0a3VsDmoQiuHLG?=
 =?us-ascii?Q?0f+wouuqVV//KZv4vMItQPdHSvqCSy4w0uSvJ7L++FS6IWtgMZ9PlP44n9Pa?=
 =?us-ascii?Q?nlIa03pYjSJ2H3b6BCW0YZftNsI5K7wVT16J3dkpQyn2bEee62eDHCRg8SeI?=
 =?us-ascii?Q?G/JpYD4/z21K06IYOxbSJtf6J5ZIDOXWZ9B/v6rGPPm4wsdDPr5o/j5QlTJK?=
 =?us-ascii?Q?+fXXJPMG4O8cPVeM8GUc/mQvYgNC+BPtlcE/L4REGb6Pg0px6jd5FJCcHqTn?=
 =?us-ascii?Q?fbaFFl+phSPLKxK6Qfyab9h/kgQ6kJftPdwLIbxifMDU1GqBmMfDH2C0Qf4c?=
 =?us-ascii?Q?qJFUyC9w5Z24NxPdSxcfXoKJUpLFPd+AJk2B0dmNs/qF+22YToFdKK2PxHva?=
 =?us-ascii?Q?HIZHow=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 922b56cd-a9d4-4e8f-53f8-08db5ac31ce1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 12:50:25.4011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m8aRFMI77V5xBnzhjbI6i0uiZTNTJdxyqXJQ2EvghrWu92Fi5yiEMWsVuMRNdnq7HajlxQXp0UlQRV99/tj2TthBU+ffwg9VQnJG4cYkvcc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5631
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 22, 2023 at 03:01:20PM +0800, Abel Wu wrote:
> The status of global socket memory pressure is updated when:
> 
>   a) __sk_mem_raise_allocated():
> 
> 	enter: sk_memory_allocated(sk) >  sysctl_mem[1]
> 	leave: sk_memory_allocated(sk) <= sysctl_mem[0]
> 
>   b) __sk_mem_reduce_allocated():
> 
> 	leave: sk_under_memory_pressure(sk) &&
> 		sk_memory_allocated(sk) < sysctl_mem[0]
> 
> So the conditions of leaving global pressure are inconstant, which
> may lead to the situation that one pressured net-memcg prevents the
> global pressure from being cleared when there is indeed no global
> pressure, thus the global constrains are still in effect unexpectedly
> on the other sockets.
> 
> This patch fixes this by ignoring the net-memcg's pressure when
> deciding whether should leave global memory pressure.
> 
> Fixes: e1aab161e013 ("socket: initial cgroup code")

really pedantic nit:

Fixes: e1aab161e013 ("socket: initial cgroup code.")

> Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>

...