Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 14:53:09 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Abel Wu <wuyun.abel@bytedance.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Glauber Costa <glommer@parallels.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] sock: Consider memcg pressure when raising sockmem
Message-ID: <ZGtltclEH1ZTBp8a@corigine.com>
References: <20230522070122.6727-1-wuyun.abel@bytedance.com>
 <20230522070122.6727-4-wuyun.abel@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230522070122.6727-4-wuyun.abel@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zIHbYUTzF7fTDlEMsWOa9pLI3R5Co142LsHuMayCEJQ3EeLbI8ORtV8SQLRW?=
 =?us-ascii?Q?6VK7wWrhK1iB9JTDlpn+6cMFfrsw9f4f63/9L4uw/cjU6HK00h2BzUJIzuoh?=
 =?us-ascii?Q?u/BXjztR7fCerrkWVHg9FDd+AVv7WytHqL11/w4368wLJKEYOBAFc9e/qv6c?=
 =?us-ascii?Q?yR/MWFCtpkaDpnxbbsox5IyGRI9K6TZ0kZPDJTf2wyapIfqeus5P66ntBS4e?=
 =?us-ascii?Q?jESWlt7if42GdSF4kwPqFlWLTEruzbIitccpqLeGVURPrvUdnVXPD/xuVPph?=
 =?us-ascii?Q?ZvW8D8LaJb0BJaMAGOOR7JER2tR6S5Kh92x+7eoMp3JzYKkIJG/dm3V29Mcb?=
 =?us-ascii?Q?yP0HZWGxvyAQ+b6785OFa0uFMLOFYL3afvJVKaOuc6P0NyD0KNNuPtVXvNfe?=
 =?us-ascii?Q?+fvaaO7Cv/K5rQfriKrfJItaSSBnWpQ7RTVCpVCkwBlbwS9IcJ2axLdYhXSs?=
 =?us-ascii?Q?JmZhfH2Lc7AWJod9OfLAoFzIqACJjGZPzZYibqmZoteChAQwJlCptZp2CN9q?=
 =?us-ascii?Q?SBA2FVrttORMQglITdpB9UaiUDCxeYK2w1CFnrFHglUZ/qbo74IBMPEcxvbn?=
 =?us-ascii?Q?sYbujx/nmzSpNxzMfbKeEcFHzHBmB2QCJLRq86n+NDkWxAj3rvBvZnIO2OXY?=
 =?us-ascii?Q?cYvSwzHTY2pDf2q5zbwacK4G9tOsedJaQy/ILPvux+VhgMH0QzrpEB7wTBXc?=
 =?us-ascii?Q?iMfSfyBV2nZemuXHSUyOBmoN4S5e3AfoiUKg5ESBTDBajtK2b+hiJ0nrqLLl?=
 =?us-ascii?Q?cUwQBhydf2vehkgDHiZPKYP+lJQj6eMgYxZluiPNILdqIqtER+PKuavtHH8d?=
 =?us-ascii?Q?Y0Z5ybA4LejYtOnBSKN2rYAohe03cnZdMjisyqpPNq+jfQjN3qUmQSsWch3I?=
 =?us-ascii?Q?p4ND3lVETBx0YlelNqbY8gtDZufwf5J022di4jK1WHmp7LskqTQjaS7wPVpo?=
 =?us-ascii?Q?wygOIPj1obuPZu4twRWmQtmHHiPZJNiV7PnYeRXBsomARxXcmCT+JmOOFLfl?=
 =?us-ascii?Q?0Ad2EufR+sGTdSB12W3yv2CjxipadlTb5qX0zJdAIppTruG0YSXRXDrEgt50?=
 =?us-ascii?Q?ED4fQlo/P8i9rb88RMWJv1EPBO0zTMs9pbWJn+5Dha8tfLNO6neNwp7I/w0Z?=
 =?us-ascii?Q?5be8v1ic+00GgofO+4dAzvBvkTYlqI9lBiwFoEvjNr1l9BW2Pe88i2lAZP2z?=
 =?us-ascii?Q?NmXJqkUfeCrN2+z3HP333u9a+7eujCNhM9h8m/hk2Osl0FjeBa/4L+IPEwuP?=
 =?us-ascii?Q?il3CWbh88RYMqtOfMmnb8VdgALLhfpWcW8EvwpSksytXrewSHU11RHBnlh1w?=
 =?us-ascii?Q?SB99cEyGSdXdenjzOLgoPSNv4Z8wVQxFB5sRwVZIxbWX5+OS7AGd7j076Bnr?=
 =?us-ascii?Q?pLx0i1dSSc3MSnXHu/XIKJ5yHtCvt62/BAZvNaoKmrSOBLm8yH7yAFrPh30p?=
 =?us-ascii?Q?UF6notAJldL9NNCTaPVMVHrEUCv4yeDOjYTJnvrUIwXnxh9rKXm5Gm9a4xVe?=
 =?us-ascii?Q?nvKcqr/KJUfVriZ1Ii4zdl2FBIj06nHyThev5slKBaiuCj6Dw/I1eYK4aIZ4?=
 =?us-ascii?Q?MYFxJpmdXj14lBIoX0dX2AgbcIK0BKCPejTPIenKNZzyequ8cvTZ0scOOZRA?=
 =?us-ascii?Q?JyxhMMQ/08uMpDda9zjBxXTMIR/zV1nQV9baVj2x1fnw0hssAt4M6+rPQ6jK?=
 =?us-ascii?Q?8D0FPw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05afa5b5-5f7f-46cf-d1f5-08db5ac38200
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 12:53:15.0642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n08YOnLVSf26hCZfR7ACG7g9yVSSMmi4tzkahqpag2cALM8wbjNCVAENZQhu7+QSMtI2G6As7815kxNsJCZfen4hyEO7O8rwKjUmabmvY9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5631
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 22, 2023 at 03:01:21PM +0800, Abel Wu wrote:
> For now __sk_mem_raise_allocated() mainly considers global socket
> memory pressure and allows to raise if no global pressure observed,
> including the sockets whose memcgs are in pressure, which might
> result in longer memcg memstall.
> 
> So take net-memcg's pressure into consideration when allocating
> socket memory to alleviate long tail latencies.
> 
> Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
> ---
>  net/core/sock.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index 801df091e37a..7641d64293af 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -2977,21 +2977,30 @@ int __sk_mem_raise_allocated(struct sock *sk, int size, int amt, int kind)
>  {
>  	bool memcg_charge = mem_cgroup_sockets_enabled && sk->sk_memcg;
>  	struct proto *prot = sk->sk_prot;
> -	bool charged = true;
> +	bool charged = true, pressured = false;
>  	long allocated;

Please preserve reverse xmas tree - longest line to shortest -
for local variables in neworking code.

...

-- 
pw-bot: cr