Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 15:19:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Christian Brauner <brauner@kernel.org>
Cc:     kernel test robot <lkp@intel.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>,
        davem@davemloft.net, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Leon Romanovsky <leon@kernel.org>,
        David Ahern <dsahern@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Kees Cook <keescook@chromium.org>,
        Kuniyuki Iwashima <kuniyu@amazon.com>,
        Lennart Poettering <mzxreary@0pointer.de>,
        Luca Boccassi <bluca@debian.org>, linux-arch@vger.kernel.org
Subject: Re: [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD
Message-ID: <ZGtr1RwK42We5ACI@corigine.com>
References: <20230517113351.308771-2-aleksandr.mikhalitsyn@canonical.com>
 <202305202107.BQoPnLYP-lkp@intel.com>
 <20230522-sammeln-neumond-e9a8d196056b@brauner>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230522-sammeln-neumond-e9a8d196056b@brauner>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DNoynbyJ5vefavjP5/8wlopUrMZhxYB+5zC+pS3o1Vwmj8/ktPjSw1dqWmBz?=
 =?us-ascii?Q?yvT0j/hwYBlY748owHI/CfBfyU2ZnmEPE+K1vfajFSoYR6lQCgjAdRNoKjxW?=
 =?us-ascii?Q?vsPDEITWGBHAkasgWcaTpqdyR79VkIi1aDT/ZDP/pxsmjKwzyqhGBS4WPelX?=
 =?us-ascii?Q?n3JzEsmauvC705Q+w5mZbmUQ2dFDBjb5uMqYd0V/NOcdRULOWU5VbQMVXZm/?=
 =?us-ascii?Q?gaosKJJqVTJUSUqKcjf6De6jAf21YO8gk54s6NfvDUO2tIRdhhz4XPEYJkiT?=
 =?us-ascii?Q?F6ih8fj9JgBX1124+LnDLTdHkJr/zfupqed6TD228Odg8z33LjIjzjHLdAXI?=
 =?us-ascii?Q?zaSkHdUUZmgzrpDVh4dTVWdzG0gk1kFmCaLMIvEMkcR7G9LzL4ErugJS2o2P?=
 =?us-ascii?Q?+v35x1qeR2yQAoaIp5DoeEWQAyFsTHfQ6XpLjlmVi2V+yYvMENbvW0/XrjhP?=
 =?us-ascii?Q?5h3w1+c+mC0mZ/lYuTQvOng3BLbQ0E1u4VgMh2Ck727aPaBadE8F9O5p15RS?=
 =?us-ascii?Q?w/FBo/ZRlZLWI0A4FBOSmn0Vnxbx2qyHrGDZujSXA1/17h/bSpDTZvhcHvsz?=
 =?us-ascii?Q?T24TdEG30tjTuUJhodwHHtRyn9QSTFwL1uJoXspg8TCKAal7ss+3Bzd1ZWpE?=
 =?us-ascii?Q?An1GXWjg/IoDPjs1nU4y1e5oBwpTa6ncjQqb88DcyzUCE/pqoGLZEB7hwEUB?=
 =?us-ascii?Q?5BfA2T7mlmd3ACjgvzLQMZnd+NqgYqV48glwY4J8/tJXFjIMWvJzm4GGGa4T?=
 =?us-ascii?Q?R4Kl0wqD0fqwjHxF1EB7FrROA9QP6tuN43gsQERDBGngEUYVXvyx2KolAw6f?=
 =?us-ascii?Q?LrQUbxVfq5aaFZKiykA+KBsy+plBK/1SI+t6wKfX9Ss3aC4f3H8JGSr55fIq?=
 =?us-ascii?Q?rgeJNmUHs/ADMRDDabtvjU0asv3ScusAineGND1xPNFTXaCZwKl7FmbfHBmO?=
 =?us-ascii?Q?+c4zOnJO8LufpBvlH8DWe9LovwAB81SFM0fq2tIcwxM8pMR9oR9sh/ujUpF7?=
 =?us-ascii?Q?dO37NCtJV0MEptMckMmdQDXSHN9QnHV+zidlHmGv18osLanc/p1qxYLnx48y?=
 =?us-ascii?Q?yhC9IGjlqXBKVLWknp9m2jO/QooXXSu++wFBcDPY/pUMQwxUtf3MtOxaEoip?=
 =?us-ascii?Q?gNA4SvplQ+Wq7kMLGs9qXn9LX9W+EUC9Mz/bzJzDp7mSpSUNjdRopTW8kp+v?=
 =?us-ascii?Q?uW2f9BFgltpoP2Er6dDqMcNxV6ZE9xHzy5H7cCQsrbpi1mzlY71ZHYpZhZ8q?=
 =?us-ascii?Q?qtH96fn6RkS6wsJfFLoCsfEMQLpRXsloiF3AvnNnE3xYRSMandWlAplz6iBp?=
 =?us-ascii?Q?uHCiwMRSuSG4unGm8tvN/YlE2dKnaRKDWHVsDOrgdFd5M1eqLF2GIg4FzYRW?=
 =?us-ascii?Q?UjhAOelKu5gLZcZpQrCVuxHC12tuPO762G6jy0tKhFCZPQ7/VUZyDfTHrJgf?=
 =?us-ascii?Q?fW7lhxJFnyoj34RTLbXZpFexlsgAaoA0dbKMbWcN4I5ZPiHn8MmMNKdc8PYY?=
 =?us-ascii?Q?H191Sev5KdfoVB1yItQHIdjocoqdtADfHwgu56a/RDivB+X4AY4wIxkM0ZPi?=
 =?us-ascii?Q?zEMjCJ353C3f0hsAc4Uu2Uf30sX+vk9X8m/s/qvnQ0ZmkXenLU0s67ukAFP1?=
 =?us-ascii?Q?+vAP9CXEUfHDjjtV5TQzF3mXS6XuhWjX6ajhthVyQ6zJTzxs96m5cCDOVw2q?=
 =?us-ascii?Q?fJR1+w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd944fcc-a5f2-49e7-7a5b-08db5ac72986
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 13:19:24.6704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xKwM1vNdocESU4Wbx7emfnMU3RgWgeOMdfs8sgR/IMFpztoqkGlVmsu0GgOnWfJl8vuNoiuKi2Zefa1l27UzvsKsku/T7TCPKkaBADgQs3U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4684
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 22, 2023 at 11:47:08AM +0200, Christian Brauner wrote:
> On Sat, May 20, 2023 at 10:11:36PM +0800, kernel test robot wrote:
> > Hi Alexander,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on net-next/main]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Mikhalitsyn/scm-add-SO_PASSPIDFD-and-SCM_PIDFD/20230517-193620
> > base:   net-next/main
> > patch link:    https://lore.kernel.org/r/20230517113351.308771-2-aleksandr.mikhalitsyn%40canonical.com
> > patch subject: [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD
> > config: powerpc-randconfig-s043-20230517
> > compiler: powerpc-linux-gcc (GCC) 12.1.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # apt-get install sparse
> >         # sparse version: v0.6.4-39-gce1a6720-dirty
> >         # https://github.com/intel-lab-lkp/linux/commit/969a57c99c9d50bfebd0908f5157870b36c271c7
> >         git remote add linux-review https://github.com/intel-lab-lkp/linux
> >         git fetch --no-tags linux-review Alexander-Mikhalitsyn/scm-add-SO_PASSPIDFD-and-SCM_PIDFD/20230517-193620
> >         git checkout 969a57c99c9d50bfebd0908f5157870b36c271c7
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc olddefconfig
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash
> > 
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202305202107.BQoPnLYP-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> > 
> > >> ERROR: modpost: "pidfd_prepare" [net/unix/unix.ko] undefined!
> 
> TLI, that AF_UNIX can be a kernel module...
> I'm really not excited in exposing pidfd_prepare() to non-core kernel
> code. Would it be possible to please simply refuse SO_PEERPIDFD and
> SCM_PIDFD if AF_UNIX is compiled as a module? I feel that this must be
> super rare because it risks breaking even simplistic userspace.

It occurs to me that it may be simpler to not allow AF_UNIX to be a module.
But perhaps that breaks something for someone...