Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b604e39a-9f0c-15b2-1460-7e0bb7e75d19@suse.com>
Date:   Mon, 22 May 2023 15:22:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [syzbot] [fs?] [usb?] INFO: rcu detected stall in vfs_readlink
Content-Language: en-US
To:     Christian Brauner <brauner@kernel.org>,
        syzbot <syzbot+24d1639a31b024b125bd@syzkaller.appspotmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        viro@zeniv.linux.org.uk
References: <000000000000c9c7fa05fc177edf@google.com>
 <20230522-antennen-eislauf-4b5a69a167e3@brauner>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230522-antennen-eislauf-4b5a69a167e3@brauner>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFcwS0U3MUwvYnNHSWx3UFRVeEZlRHhnQTZqb202T25TWWUrRlRvaUZ3TjMy?=
 =?utf-8?B?cXVEeXhCYkIzQ3FhdXRVZWVhbitqQUUxdmRDZFpBcHZvaGNIT2RObGRzejBT?=
 =?utf-8?B?WERHRXZZN29wbXowWmErSTZTdmhBYnQ2N0R4SC9QQklXWEg0aXFRUDdZTWo2?=
 =?utf-8?B?anFUSkxaSVVyT2R4NjBzdmpMTGxzbDJseVBtSVlZSCtQaUNMUEltMWFmdFdQ?=
 =?utf-8?B?eHowQmNMSTVwOVNEdUFVQzloeUdPR05Ubzk5cFdqaTBQNXJoL1lOdC92Ym83?=
 =?utf-8?B?bmF2K25ZSGFlSHQzcUMwaFQ4b3FoaWhHbkxES0x3aTVJaTN6Nk9JWER1anBM?=
 =?utf-8?B?YU9rUExydWs2RGZqNjQ1QkZWNHZ0VHg0V01VeHFVTnFUSkdYajZQeCtjU1NG?=
 =?utf-8?B?eHZ1c2Q1b21JRmdEVlUvQ2NOWURzZXBIaUR0Qkl3K1NzaWN1U1B5VFdCQnJh?=
 =?utf-8?B?Uzd6YUdLbDByZmV3bTMwNmVNdFUzRzlQTmVLSjRPUW92cHN3TnAvcWQycUJq?=
 =?utf-8?B?R2thM2dEcFo2eFNxOHpkNVhrcjBnRDZFdEVncjNybjJFRUIwMlUxelRYTWtv?=
 =?utf-8?B?Wm5taC9QY3RoSDJwUzdNeHRLNlcwZktaVE96bkZBTzhtK0JKUFJyM3BZaUo2?=
 =?utf-8?B?emI4TktUN1VXWnA1OENHeHdXeC80TjFZTnNQa241MzRLMVkxbnpoMTNuSFYw?=
 =?utf-8?B?MTkxdW5ocHRiejBIblNmVHpNeTlsNysxWm42aUFEUGk4VEtzZStQblU3ckdD?=
 =?utf-8?B?dHBXSi9sUnZkcTFmWmJHakc1NHliVXluSTNEdlFwQWFBRXpGaWJFZmQ1dzZ4?=
 =?utf-8?B?SVViamdkMFVrN1IraDdPZjB1MndFNTZweVVDek1sRFQxanlZVTgxVUo3UWNZ?=
 =?utf-8?B?QUhTZlQ0RlVRempJajFpZzB2YVRQUzRhRmhrRDZ4MkR0RnNqUXNQaEpnYjVx?=
 =?utf-8?B?NGQxMVNvNmRQSksvM00rTHZ2QkxUWFF3eDNqMFdXV2FZekNOVlRWNlVKbmlm?=
 =?utf-8?B?eVVPUWczRGlxcXZBWkw5VStpNkgvQkpIcEljWERzVE5RQVZWeFJjdzhqUEw4?=
 =?utf-8?B?Y0NQR3RHWFN2ellMeU1ORGZXd1BjSVhJMlZqV0tQNFZpYWgwTFRRN0tWdmpi?=
 =?utf-8?B?SzdxMENRanJ0NVJiaUpRT002OUJxaEEzQ0FWRXZRdXVKTUxQMzlUYy84eVAv?=
 =?utf-8?B?amgwQit2WGtXQTRYKzhLOU1MUm5uRGZObnJkcUVQMTBXcU9kdDlYWVF4UFZw?=
 =?utf-8?B?VXdqNjlPcHlaV2l6RnJzMHBkbWorREhVUDNlcENnTUhucVljSks0QVlSd2No?=
 =?utf-8?B?bWdBSmVaY1EwQkg0MmhOSEJUcWt2LzZacmVQK09EbXg3K0FLZ29nMDI3b1cx?=
 =?utf-8?B?ZU4wZTAya3lXcCtaVVlBZURyYWorOGgyNTFNK2FDNytFSGNTTFRTM0ZiZ1BG?=
 =?utf-8?B?cnM3QjJoMTZTZHNlY0JNVGZtd0dKWUpkNTRQVytBakxETmdNK21WNDJvNEF5?=
 =?utf-8?B?Zjlud3ZIYWt4TTI2a2hUVXhmUE83WitLN3dCc0Ywb1VkMTA5WmhXUUlKUUlD?=
 =?utf-8?B?eUhBUE5FRVJLaHN3R3BEYVBnMk1WK1pISEN1YmFNNDEwdTBvUUszeXpBYnhD?=
 =?utf-8?B?bjBxZUlKT2J3aWppQTVFOUpXbWk0R0RZVERoekRsOTgxOCtLZytCTE10aHpI?=
 =?utf-8?B?dHdISjJaaTdmMk9rLzhXMUtMT2grcXZoQUJvSlRIOEtOUTZ1aEZ1NUcyRDlq?=
 =?utf-8?B?QUFSVjZaaGhZOGNRL09Xem54MmpHa3RqTzNleFZqWG1XUWpla1RvSFhHVmtw?=
 =?utf-8?B?dWRXdkM4RklXOU40T3lhNkI4a1Q3SENna0cyVERTcjZTVmk1UlNnSWk3STl6?=
 =?utf-8?B?SkhobEdGOVFqZnU2b1p0ZWt5N2NNVEV3TDdadGJiRzdFS3Z6emt0RFpUZ2ZO?=
 =?utf-8?B?TzVqM1RZU3FXbE9na1plMUFZWm9Tc2ZWZkpNc0VnMXJ1WFlFVi9PSFRBb1U1?=
 =?utf-8?B?REhtUTAxQndOVlhyUWFQNHBuM1hlRXFrLzdjbzJqNWxuZDZFMytOUGZab3pE?=
 =?utf-8?B?T2I2R1B0ZTQrdm5BNk9ScXFLU2R0em1UTVpzTUc4aVE5QWVTT1pDLzBjR3Uw?=
 =?utf-8?B?TFZ1d2RvT1NqdGZpRGo4bG1RMGZtMlBEMFUrbjU0Qml3dWlFRWxLZGYvclpt?=
 =?utf-8?Q?74OX/VXf9aBFr08c8U8RG24=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37928fca-7120-49e7-f6bc-08db5ac7a2b1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 13:22:47.9986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /XxEpOO/WIN9yIf5mgNx7VNowy75xDZr7wJyPRezNj4m4Bis1nUHGALy90z+Ssx9gEVaSOK25wllZh1T+IXGWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6892
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 22.05.23 15:01, Christian Brauner wrote:
> On Fri, May 19, 2023 at 08:18:45PM -0700, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:    a4422ff22142 usb: typec: qcom: Add Qualcomm PMIC Type-C dr..
>> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
>> console output: https://syzkaller.appspot.com/x/log.txt?x=10ce218e280000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=2414a945e4542ec1
>> dashboard link: https://syzkaller.appspot.com/bug?extid=24d1639a31b024b125bd
>> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137d4c06280000
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17b758a1280000
>>
>> Downloadable assets:
>> disk image: https://storage.googleapis.com/syzbot-assets/414817142fb7/disk-a4422ff2.raw.xz
>> vmlinux: https://storage.googleapis.com/syzbot-assets/448dba0d344e/vmlinux-a4422ff2.xz
>> kernel image: https://storage.googleapis.com/syzbot-assets/d0ad9fe848e2/bzImage-a4422ff2.xz
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+24d1639a31b024b125bd@syzkaller.appspotmail.com
>>
>> imon 1-1:0.0: imon usb_rx_callback_intf0: status(-71): ignored
>> imon 5-1:0.0: imon usb_rx_callback_intf0: status(-71): ignored
> 
> I have the strong suspicion that the usb drive is removed or some such
> nonsense. Doesn't seem an fs bug.


It hasn't been removed. On a real system it would likely be.
The device keeps returning only -EPROTO. As we are dealing with virtual
hardware that is fast enough to cause a livelock from the error
handling retrying the IO without delay.

Handling this nicely would need a real error handler with a workqueue
and some delays and evetually more drastic action like resetting the
device.

	Regards
		Oliver