Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <44988709-f04c-6ccc-1d8f-eed939a643ac@kontron.de>
Date:   Mon, 22 May 2023 15:29:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow
 to meet spec
Content-Language: en-US, de-DE
To:     Fabio Estevam <festevam@gmail.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>, Marek Vasut <marex@denx.de>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Frieder Schrempf <frieder@fris.de>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Sam Ravnborg <sam@ravnborg.org>
References: <20230503163313.2640898-1-frieder@fris.de>
 <20230503163313.2640898-3-frieder@fris.de> <2225400.iZASKD2KPV@steina-w>
 <CAOMZO5AiWM64tZgArUL89q5spuLD91R-pnURbfqPU9O0w54sQQ@mail.gmail.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <CAOMZO5AiWM64tZgArUL89q5spuLD91R-pnURbfqPU9O0w54sQQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3BZNFBSSzlpWVE0akxwNXhtb29CZERSeUduLzdPRWk4RnpuNjNMRUF3VHdr?=
 =?utf-8?B?QTB5ak9kZG9HTUdRNjU4bjRqaHk5YnhNSUFLY1hvTXplbFp3Q0Z1Qm1vWWo4?=
 =?utf-8?B?VWkzVHQrN0MwZ2RMYW1jbmc0U3lvTkJ6UFF6enY5NUhzN0l0MmVSZXpUZU9F?=
 =?utf-8?B?dE5aVFVqSWROUGFIWThjY25FYzYvU29za1ZsQThTNEdFY3AzbTBQVEYrOWR5?=
 =?utf-8?B?Nlloem5uSjhYZ05UVnpKbDJPK0lURzU1L0YrbXZwbXhoSjBPRkFPRkdPSk1P?=
 =?utf-8?B?aFlERkpsUkRjdUJOejZXT3BhcmNHdGx0dTNhenRGaVN6VFUyejlIeUF3SWF3?=
 =?utf-8?B?dXhqaU1CMTlBSjBqRzg2U2VFQWtwSTFINTRWWEFUQWk3TWR2emovNTNWTGlo?=
 =?utf-8?B?aEg5SG9uRTltYVh3TFdxb3V3U0YzQXRQQUpzTGVlNCtuKzhZMzNpU1cxK1pU?=
 =?utf-8?B?QndJWFVVUm9weTFLNUdWV0VQT0M3YitOTHozRHBKSVNWemttYk1Qd0VzS0xN?=
 =?utf-8?B?K1dDRUVkN3phZitKVzMrSjRXeDk2aUNHMTQxaDkyS0RSa3NhclFOMW5LL1h1?=
 =?utf-8?B?M09KRzVlVlpGREVDYm5PR0l2ODlxVjF2SDY3NWRzbUsxMEFKNVZKdGZ1a1h5?=
 =?utf-8?B?bGxKZXk3eElSNG1sRGJocEl5Zng1SzRYditCWUlQNVFEZVMxMHhLbUQwb0li?=
 =?utf-8?B?d2dmVFdVc092VUFWbXd2dm5RRDU3djN3dW5TcW9EemQ0TGVSNFozdWNURHQ0?=
 =?utf-8?B?ZmN5MDZBV0NrYXFEN1ZEN05zcGtNRXA2dHhyb2l3MEkvNVI2RnVERld0dU81?=
 =?utf-8?B?UXhFSFhqVmJPMi94UnRQVXlVV21aUHlKN2Z6MlRYYThEWFpmK2YrVVNEUDNk?=
 =?utf-8?B?TGtWYzRrNE9FZmFYdHhoWnFTUmpGallqalNoc3hQU1NRMWV3U1ppTHJCcy91?=
 =?utf-8?B?TkRhc1JxMEdsYzNlUlVNdHdHZ1hHS2FsUTRFRTBhTUpNLyswaUx1QXkxRkhw?=
 =?utf-8?B?azNMQXdwOXg2RVZ1MjgvREZlbXJURW5YWVpKbWJpcGdtdjhZOVhlNElBQzF4?=
 =?utf-8?B?OFYzeFlNUjluUTZUQzdzQWxhM2daSlVMWmtscDVpbjJ0M2lac2RuZXpUckJD?=
 =?utf-8?B?MHpKc2owQ0RHdzFjWHNpc0dEeE1Yc29ZdlB1YUI5NWZENDdRL0E2ZDhhQTl4?=
 =?utf-8?B?Y3hjUnRPK2MzeHA3UXM4Z3lsRHVTWUgzenNWK2gyY2ZHekVHNTczOWtabStQ?=
 =?utf-8?B?MHVlclRsdnRMd2RvMUczb2grY3NtMk1TQmdZcCtoc1A0dkJvNWY1bWtqajZa?=
 =?utf-8?B?MW9uYkFNcC94QUpHZkZiRUNxVksyREJYdG9ENSs5SUNuMjJvRTdIeUJzT09T?=
 =?utf-8?B?OUl6Qy9neTNJMGdMditzNU9jd2RmVUMwNnVqQklGWUU2MElJUEx3RTNmR1E3?=
 =?utf-8?B?SjJKd3RJQnBUWkJ2cjA2bGI4SlhKL0lVNmRjWWZVandJcTc1bzg5dXRKT1F5?=
 =?utf-8?B?bC9JVzFVRUpXVk9jTllVNHBUVllKWG1ublZ1M0g0UHdKZERncGIxRlJwRDNH?=
 =?utf-8?B?WHpHWFJ3SUkySzdtOUpKN0VUTTE4WnY5THViWW9Tbml5ZTRGcWw4K2h0dTF2?=
 =?utf-8?B?UnYrbjlaanlhOUJEWU1sUzFMTGR4d2wySkxmWVdRbk9IMWFvSWJzOEZ5YVkw?=
 =?utf-8?B?czBEM3hRSlBzL2puRE1XT2Q4dWgvZmVtenlXekhFU2Zac0Q4Q25rSndHQm5W?=
 =?utf-8?B?YlpTblc4UVgrZGVVNUlab3FabUZ6aUM1VXpvelRDK0RzS3ZSN3c0QWt5SGJC?=
 =?utf-8?B?K1A0b3hCblBxcmIvS0FmS2Nzd3FXbVNlL2NJclJjTG5zTW9RRlcxc05MZzhq?=
 =?utf-8?B?Uy9zSjI0Y3JONUFTbFlYaXU2UFczazJidWF4L1BFZmsxVUxyMGZPWlRxYTZO?=
 =?utf-8?B?UzIwSWRVMTZMZG9OLzJiaHhYNzluLzNVUWs2RzhwT09Jam1mRkNnWUdRbUwv?=
 =?utf-8?B?TDFLLytLSFZSUnRoeEFveVlTZ29mQ05EUmx0WURRSkIxMHhMNXp6OEw0YmFS?=
 =?utf-8?B?ZWg1Zm9HaTVZaUR3WDNjODJSSVdxNmJSb1YrR2tQUnEvMUZRam1acDcxZCt5?=
 =?utf-8?B?OHRrY3gyY0E4TTFxdjVxek5pUGpWWG0yRVl5bE9nazlWaGIrOUovL01JbWhW?=
 =?utf-8?B?Umc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 53b2ab8e-5f28-4d80-0392-08db5ac8861f
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 13:29:09.4524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GejC6qP7GpB1c5JnsMfaZyv434+fafxYAqW2cWD2Qdmnioj/lU+VLRXsZV8iC9ZHW2+4D7aVuGTkS4s9EM+jUS74/ED3UdKK042m5wWx0zo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR10MB6983
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17.05.23 00:22, Fabio Estevam wrote:
> On Thu, May 4, 2023 at 6:12 AM Alexander Stein
> <alexander.stein@ew.tq-group.com> wrote:
>>
>> Am Mittwoch, 3. Mai 2023, 18:33:07 CEST schrieb Frieder Schrempf:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> The datasheet describes the following initialization flow including
>>> minimum delay times between each step:
>>>
>>> 1. DSI data lanes need to be in LP-11 and the clock lane in HS mode
>>> 2. toggle EN signal
>>> 3. initialize registers
>>> 4. enable PLL
>>> 5. soft reset
>>> 6. enable DSI stream
>>> 7. check error status register
>>>
>>> To meet this requirement we need to make sure the host bridge's
>>> pre_enable() is called first by using the pre_enable_prev_first
>>> flag.
>>>
>>> Furthermore we need to split enable() into pre_enable() which covers
>>> steps 2-5 from above and enable() which covers step 7 and is called
>>> after the host bridge's enable().
>>>
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> #TQMa8MxML/MBa8Mx
> 
> Should this have a Fixes tag so that it could be backported to stable kernels?

As this depends on the support for the pre_enable_prev_first flag,
currently the only candidates for backporting would be 6.3 and 6.4.

I can't tell if there are DSI host drivers which already implement the
proper init flow and would benefit from a backport.

Anyway, it shouldn't be a problem either so I guess the proper tags
would look like:

Cc: <stable@vger.kernel.org> # 6.3.x, 6.4.x
Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
SN65DSI84 driver")