Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5effd41a-81c3-4815-826d-ba5d8f6c69b4@intel.com>
Date:   Mon, 22 May 2023 15:48:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Intel-wired-lan] [PATCH net-next 07/11] net: page_pool: add
 DMA-sync-for-CPU inline helpers
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Jesper Dangaard Brouer <hawk@kernel.org>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        <netdev@vger.kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Michal Kubiak" <michal.kubiak@intel.com>,
        <intel-wired-lan@lists.osuosl.org>,
        "Paolo Abeni" <pabeni@redhat.com>, Christoph Hellwig <hch@lst.de>,
        Magnus Karlsson <magnus.karlsson@intel.com>
References: <20230516161841.37138-1-aleksander.lobakin@intel.com>
 <20230516161841.37138-8-aleksander.lobakin@intel.com>
 <20230517211211.1d1bbd0b@kernel.org>
 <9feef136-7ff3-91a4-4198-237b07a91c0c@intel.com>
 <20230518075643.3a242837@kernel.org>
 <0dfa36f1-a847-739e-4557-fc43e2e8c6a7@intel.com>
 <20230518133627.72747418@kernel.org>
 <77d929b2-c124-d3db-1cd9-8301d1d269d3@intel.com>
 <20230519134545.5807e1d8@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230519134545.5807e1d8@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVE2Zk1oOEVuYUMzY24xWnU0bmM3ZmhSZlhUdGZaaHNYQUcvRFlVWDJPZFFl?=
 =?utf-8?B?cEI2UkxuNW1PaFpXMmpvVlprSy8xdE5ZZDZIMU9GZEdZLzNlTVZyMHdMQy9w?=
 =?utf-8?B?d1BEQVk3UkM0VDA3Tms2M1Y1SUpqWkZmSlNzbGJlenZHQ3k2T3l0ekhqMTlQ?=
 =?utf-8?B?T25vQlpQS3dWYVoyVzdaNHBjdEhML1BzR0haSG9FczUxanR1dnZTcnNwc0FR?=
 =?utf-8?B?R2N2amRuWmM3TnQvM3JINzRodUxqeEs3ck16ejU4K1NqRlpnVkhKNEVXMnJN?=
 =?utf-8?B?SGd3REo3eFkybXFyNUhVdFFWSGNjUzk2Ty8zQ0FNYmNtVnhiRzk3N1MzaHlt?=
 =?utf-8?B?NCtNTWM3RWFPZy9ZeGlZK09nR1FseXdPZmJjNlJEeGNaSndoRUkvci9oaU9X?=
 =?utf-8?B?ZllsbTJKQTJoVVc1VzVwWnA0d3ZPbENKcmxPbGliQ1JCY2syRmZLdkhBbFZX?=
 =?utf-8?B?T3BLa0N6SU8yT3Q1OUZNSUp0M1A2R3BtdUFyamJ3ZUZmYVEvakJ0dUtYVnlU?=
 =?utf-8?B?ZWIrdVJvZitrNGs3WkM0WVE0Zk55T3pkZWtzbUovdlNDZmJUbW5Ialp0dGZt?=
 =?utf-8?B?Sk16MW9Oa1dsQkt4d09BR1lkclVVc1hHbzVDeUIvQnVtY3lubzUvVEhHZ3NR?=
 =?utf-8?B?V1VCeWovREpRank2RkVXeFBtc0tvQnU3NnJ3TXdDeGQ4VTFBN01wditDNVdS?=
 =?utf-8?B?NWFEb0xQdGIvWkM2SWRHRnZOdXMvWHZrR1R2cDBMVCtrT08vUnBIOWtpSUxl?=
 =?utf-8?B?L1lPa3RBZi9tMmNYZDZPdENNYTJZWFEvcm52Qnp0T1NYMVNtc1ppQlBJUDQy?=
 =?utf-8?B?ZXZOMWtLVXk0Ly9EclVTMWhEMnFheXh2QzIxeUNlOG13ckFSZG1UZDZBcXdN?=
 =?utf-8?B?NVI2dzJuemUzTmoyVkVWMmxIODc4dENjYnpwdzdnMG12bzZKdGtkVjhkMVlq?=
 =?utf-8?B?cFV6Nm9ZbTZQSEp6QmZWNGo0bzJHb1MxaGtPbmhhSW5yWHg1K2hxQjErRG53?=
 =?utf-8?B?aVc0dFNvTkFBMlBrYWVwSGNXQ012UEhERXl4WE8zTGRCQWNwanRUK05jWE9Z?=
 =?utf-8?B?L1RNS0JndXo1T0lZeUtBc2ZaSmpiTTlDNnFFWTVTSVpUd0hhalFGRFc4S2VU?=
 =?utf-8?B?ZGV6KzFUWUlrc1lTMnFMaGsxNDFHSGhWQUdZV3ZPUVgzL3k2UUk1ckRLb2ds?=
 =?utf-8?B?OGw5bXlHbDI0WmxZcjF2c0c3MzBqZVIzZDV6NVFmcUlkMTc1MXYzOWtpUlI2?=
 =?utf-8?B?QUdhNWZqYno2ZHNPR1BJVXplQlpyNWltM2FoSE5taG5RZ1p3MFNXbUllbXF0?=
 =?utf-8?B?c0lMTWttVHkwMTFIRXV6NTNtWU96QTByUnhST1hRS3hURTN3aTRnUCtZNWs2?=
 =?utf-8?B?REl6ODBWYzJpYW5VZkpveXlpVng2MUJQMHRZa3dYaTlweVN1WTg0Z2I0ZHo0?=
 =?utf-8?B?aUw5aVZtQUFpT21YemRUU3E0OFVSbjJ0ZkVzYTlPVElMSFFiOUhUZU5FMzJl?=
 =?utf-8?B?VC9ad0M3cldFQlFwSXhVRlJoZG5xY2pGVW9aVUhxcDk3c2EyS1BuYlFkRm5J?=
 =?utf-8?B?V0hxc045RWYyb2MxaW93Y2oxZ0tndUNzZ0o5YTJkSDNoNm04V1lFOUNaMjNs?=
 =?utf-8?B?TGZKZmNyOTgvN2hUem5ITEZFMzMydnhubkJTY1dIUUlVbW1td2EyWGpsVUhi?=
 =?utf-8?B?Um53U2FHZm80U2N5N2tPZzlja2Z5aVl4M1pDenlGMFA1WVJDenNxRGJ6aEk2?=
 =?utf-8?B?ak05MmVoeUhiN1FOdHhIVDRPYmhJUXBxY2kyRUc1Q1lNQnJ6SzRNRk1Ham9u?=
 =?utf-8?B?alI0WTRIWHBBMzROUzUzeHJsRlpOb3VnWkFrTFc1c3VYdWgrREFsQngrNXF5?=
 =?utf-8?B?c2d2Um5LUDJtTXRSYVVCemI4UU1HUzZxUWxnZWZDQ3EvbUpvZGFvWUY5ODFR?=
 =?utf-8?B?b3ZhaWR1b2tuaVlNOWtNMHZtNkFzL2VhNXo1QTNQREt1VUJhVHNvRjVvNnZs?=
 =?utf-8?B?UUQwZStJK3I5dmIzeU1OSHdyTnAyWHJqTXFmcVE1Vjh3UlpPWVhiMXZLZlBx?=
 =?utf-8?B?M1B0SjJDZ0hIMkhzOHBGbGJQUUFQLzh4K3M4Z3cxa2pCejJZT0hLMTZXTkM5?=
 =?utf-8?B?dWF1YUJlbXZ2ZCtnWU14V0kvdjQ3cTlQb3lMR1VvUTBXVmt2MzlHckw3dzhr?=
 =?utf-8?B?RGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de4f5dba-c2ad-45f5-ed11-08db5acb7eb0
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 13:50:25.6134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: em01oYZ1euMAPWFAqWlKj2BrzqlrrzwAjBh2MRwaTo5m498Q+4xGzXhoBU/82fFEAfQtFS4hCUfbGfvsk97dzmwz12Vm7okGHPkc3xmvOFg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7081
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 19 May 2023 13:45:45 -0700

> On Fri, 19 May 2023 15:56:40 +0200 Alexander Lobakin wrote:
>> From: Jakub Kicinski <kuba@kernel.org>
>> Date: Thu, 18 May 2023 13:36:27 -0700

[...]

> Ack, not saying that we need to split now, it's just about the naming
> (everyone's favorite topic).
> 
> I think that it's a touch weird to name the header _drv.h and then
> include it in the core in multiple places (*cough* xdp_sock_drv.h). 

Hahaha, I also thought of it :>

> Also If someone needs to add another "heavy" static line for use by 
> the core they will try to put it in page_pool.h rather than _drv.h...
> 
> I'd rather split the includes by the basic language-level contents,
> first, then by the intended consumer, only if necessary. Language 
> level sorting require less thinking :)
> 
> But none of this is important, if you don't wanna to do it, just keep 
> the new helpers in page_pool.h (let's not do another _drv.h).

Ack, will just put there. It doesn't get included by the whole kernel
via skbuff.h anymore (in v2), so new inlines won't hurt.

Thanks,
Olek