Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3036481rwd; Mon, 22 May 2023 07:51:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vxss3PPxMpzGeyASnlOd65FajBi62e4+7RfhTULy/bpfpNfJlhkGoYV0JMqeAlDVPBhEo X-Received: by 2002:a05:6a20:3d8a:b0:10c:1a3d:6b97 with SMTP id s10-20020a056a203d8a00b0010c1a3d6b97mr1404687pzi.49.1684767077125; Mon, 22 May 2023 07:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684767077; cv=none; d=google.com; s=arc-20160816; b=MSnWL7WqpsqyAQWmEo/sS9DYfFl0rZAHBBh9RR4hN2bpwo2eVmd+mKikTkLBDsFz+b wIQdtQtWHhyo4G790LWs394upTKME/AxhjZxM7Bal9gLuxgEosd9BHzTs2NCyBemLQX8 7A2yMeMTC5SLsIgrzD26XQHL/xW0AF5VHGHraw83GU6oQNZISEOPQc6E8wKYOFNYq2aF uB7YuHhRSCK0tJ/euiZ5GmPwPclxj5nvB18bgoEAoMw3wIVAaB5Hrc5svD8UcLp79URT AYioJpgvNmXwqwtE8Exdth75H/GKF+0Kf56ixKWlotpe+Bx2xKozVv5jgUblCfI+Thox Y2SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=pV80mT0QOPTPWR9sa1G1o2qCJDifEVS332QOzwreKG0=; b=N8aWzjTN9DApvSEklP6Mcog/hYiEjMm6f08qXwrvs9GgJ3ML6QodqxI7omeC45JPkd T0t/CPjZZknMaat0NIDTdTE4XdRIrRkReySvARND8ZI8X1DGah9Y6O70Of9JzVKXySMy uPq4ltlT3KlyW47emk3NQXgQQVSX+q1AmTIHVCCN5CMhxlwHKJMibWGyAyrI66roTfCj n10L4EdSr7OK0vo2YxfWbDnIpQn2L69i/V1RhMGY5gNN/PVkC55skbQnBkwTugt6TlEd P+gQg5ORqIvZ8jCq4QqCfDEYOFb45QhqUv0D3/Ji/cou8ORMgm6P04Gz2R2cUmo4PEoo N78A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jDVHlnjF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w186-20020a6382c3000000b004fb95253a18si4662045pgd.376.2023.05.22.07.51.02; Mon, 22 May 2023 07:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jDVHlnjF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233325AbjEVO3R (ORCPT + 99 others); Mon, 22 May 2023 10:29:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233252AbjEVO3O (ORCPT ); Mon, 22 May 2023 10:29:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D70F1; Mon, 22 May 2023 07:29:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8D8561941; Mon, 22 May 2023 14:29:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D752C433EF; Mon, 22 May 2023 14:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684765748; bh=zgCnm5TdeQsdNTt7uR7RGxg7lgqFPJstgSHr/HbAaXM=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=jDVHlnjF0rqQELoJVNmHIPqbgVZhfGBJ9NtExUdj0z1a7gYBtCFEZobwLoBmxUqvk bV+1EJHndfa69dIGZsSCIAmYu5ruYExSoh2mr2tmNuTCZnXtVxmLGOTsWCzqBLK94g L/wnNKPOWnE8nwGeHvAIqVeDdVWztybsTJD3u+Lts45mQD/ECxqDRYnhCcBr84fX/3 msn1SEIiAIjr7uDb3rhEV3KbAzEysuFVVxLy+mFrhvgnJEMdOaSPOqaXP/aTFxWy6c ZqarZL/9bksysjb4ClL/p0C2beAZPmkzguLceysPOeqxY0PXGoriAsN2poekkRbDfF CZ4qlt1NMwQ8A== From: Mark Brown To: Charles Keepax Cc: srinivas.goud@amd.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com In-Reply-To: <20230518093927.711358-1-ckeepax@opensource.cirrus.com> References: <20230518093927.711358-1-ckeepax@opensource.cirrus.com> Subject: Re: [PATCH v2 1/2] spi: spi-cadence: Interleave write of TX and read of RX FIFO Message-Id: <168476574697.614040.7701862190333374068.b4-ty@kernel.org> Date: Mon, 22 May 2023 15:29:06 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-bfdf5 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 May 2023 10:39:26 +0100, Charles Keepax wrote: > When working in slave mode it seems the timing is exceedingly tight. > The TX FIFO can never empty, because the master is driving the clock so > zeros would be sent for those bytes where the FIFO is empty. > > Return to interleaving the writing of the TX FIFO and the reading > of the RX FIFO to try to ensure the data is available when required. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/2] spi: spi-cadence: Interleave write of TX and read of RX FIFO commit: 6afe2ae8dc48e643cb9f52e86494b96942440bc6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark