Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 17:02:21 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, ramon.nordin.rodriguez@ferroamp.se,
        horatiu.vultur@microchip.com, Woojung.Huh@microchip.com,
        Nicolas.Ferre@microchip.com, Thorsten.Kummermehr@microchip.com
Subject: Re: [PATCH net-next v2 6/6] net: phy: microchip_t1s: add support for
 Microchip LAN865x Rev.B0 PHYs
Message-ID: <ZGuD/dqpQl/2wpRY@corigine.com>
References: <20230522113331.36872-1-Parthiban.Veerasooran@microchip.com>
 <20230522113331.36872-7-Parthiban.Veerasooran@microchip.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230522113331.36872-7-Parthiban.Veerasooran@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1RZQW5WNGQxTTBQRnVrZUUwSytIdUVjb2NrVHJvVVhjOHhTMlAzZjlLRVpy?=
 =?utf-8?B?N3dJaC9JZWFWdmtRc25kalBJSGdDcGpsZTRiNUF6NkFoQzYrZ0VDUjMxWjIv?=
 =?utf-8?B?WFE3bVpQSXd2RDdSMDdHVmdhVlF0SkZjVHUyMEp1NXRiL1lQMnhLejJ3M01R?=
 =?utf-8?B?eVpzQXRBRysxODB3QXdQdDMxVHRveHIzOUd3ZmluU3R4UnVGYklxa25WOHVP?=
 =?utf-8?B?UkVZd3J5cWI2RjFmUldENTFNbGsxcmg1VVNrd0RCYk14RE51TWYzbEJUV3Bo?=
 =?utf-8?B?Yy81cXpDYU0ya210VUpXaHVFTnJNVWtQeTFaSUxpT2dLNExHclZ2Y0NkNHJi?=
 =?utf-8?B?dzVOL2R3QXZ1amJ5dmlEYjJKWGYwSU0ydHE3cVFyU0hPTDd1VjlNWER1R3pQ?=
 =?utf-8?B?YWRPU0tBYXFUengyWlhwdEpJazQzVllSVDdhdVhxOHN0WjZCS1lmRXRFL2tK?=
 =?utf-8?B?cmllTUo5azJxQzArUk56S3NaejZWYkNPc2NkbHdLTnNTZTlPeExRM2UyNjBE?=
 =?utf-8?B?Nk55c2VTbVRDeEhFVG82TG9wb0w4QTJIQmRaR0ZwWjdNaUI3a0U3dmRKa241?=
 =?utf-8?B?VWpuNytyWHJCbTc4L0swSlJpQStMZ0xBRk9ya0JNMGNIQi9pZ0swdDM0ZzJN?=
 =?utf-8?B?RTFrNk53ZVpGQjN3Q0x6WVYyTjFkdUZqZ2t0bDNuckFaZEdOTWx0YmtCT3h5?=
 =?utf-8?B?T1lrV3RBOFFISVdSZmQ4T04vemh5d3lmMDM2REJFVG1nWmtHRUVVVFU3SWQ4?=
 =?utf-8?B?TytvNERWbmNaUWFiaTJsSDdYUHlyTnZxV1dkY0ZnTUxMR2tuRlhRa1NqOExQ?=
 =?utf-8?B?eUY5d2RpRVpBdmE5MVp6OXVpeEMvbWtTTCtwZjE2TnNreW81TUp3bFpQcWdR?=
 =?utf-8?B?VkF5SHRrTzVmYVFIUXJjSzlxbmhOcmhiVE1aZkFIdFVHZUljeC9Iend2Y3pw?=
 =?utf-8?B?NHVpdjYzNjJRQll3YWFvc1FtMjVITEk3Njl4ZVh4aWhOLzlLNzFsZmJ1SUo1?=
 =?utf-8?B?cHJBNWx5Zlc1RDJJN0haRW5CdzlxRnY4dU9ITi9aWXZxaWQxUXBxYlNTOWd4?=
 =?utf-8?B?Z0F6U0xzem91MitLWHhqUm9GMG45ZU5nbHg2QWl0eU9GYkRxSVFrV0krSENo?=
 =?utf-8?B?aFdReHlZT1o0QkUvdktiS3NCeXUwaUNSenRsZlZySndScW1kRE1aSndUMXBM?=
 =?utf-8?B?NzlzZmw4RFdsdDg2QUtDT2hVeFRHZi9lN0Y3Z3cyblloUXBoOGVMa0hYTm5E?=
 =?utf-8?B?RmxvOHJwV1lBNm5MT0xrU1BlYm03WUkwbHVNcU1TQUlseVo2Vk9SemxvQ01t?=
 =?utf-8?B?M3dVbno0TlpJaFdwem5wMk5UNVJrMlIxT0tzLzNyQUVNdkRZOGJadGMyczlX?=
 =?utf-8?B?TjN6RjhmclBkWWM3aW05SS8zQVdTejJkVmI0Uk1vME1nL3Vob21LSThmNVdv?=
 =?utf-8?B?UnpDODBockxJYnNVR205Yzl0RFlSalB6N3hDYVhSRTM3VWRQVkIxN29mUGp0?=
 =?utf-8?B?Qlo5bGlVNHB1MytRY1cyblJNMlNRenFZK21EOTlaaXFocmVWKzFzbWQzaWpi?=
 =?utf-8?B?NnBnOHFPcDhQQ1NVT0NWQ1AyeTYyYk9nTUtXSmlRY1lrQkpGeHpJNDVYd2ZU?=
 =?utf-8?B?a25NYVBHenIxTDNyOCtqbUhMekhzOGQ4MVhrdzV3YXFkTDU0WHlwZCtHbWFn?=
 =?utf-8?B?Z1BCVURuaWJVeERwSmE4LzFPV3RnWnpCTUhUb1VBdGVoNm5sUmVRODFQLytH?=
 =?utf-8?B?NXVwUXdOeWZNbGRoWHJyb2xsTldKVFRSNnFIdWlvcW1kcHZZWUs1MjhCQVJh?=
 =?utf-8?B?QlJUOVNLQkQxb3hpM3k1T0RuQTNpeVdvbnM0blo4dVdCclJPVVZ6MnVxQStU?=
 =?utf-8?B?NlFab1hmNVZkaklWMEQwTm5YSWxOVFZ1eldPWHBpUVpPMDZLTDVvcUZwYUNh?=
 =?utf-8?B?Rk4rcGZvcURDbVUyaXdhSmUyK3gwdWd6NFljNzEvV0NSclg5bGhjQzU4UjAw?=
 =?utf-8?B?UUJOMkxVbWpaNXVBMFY1aGJqd2dGR3BXQUVia0tyQVIwODQ0WHZtWGlDUmlF?=
 =?utf-8?B?RzFOOVZhb2RaVjJXUWhWUWs5WCtiOEJKSzFmSmNwUEZkVmhJSW05S1JvZ1hh?=
 =?utf-8?B?SXlPdmtLMG0wb2ZZU25hZC9FY0VuV2Z3MHZTM1NvQitFeXlCL2dkL3d1a0RN?=
 =?utf-8?B?NW9wY2RYM3IrNWhQRXRHRTBnZ2hiejVZUDd3UnRpcnBmSW56N1hjbU5VU1FV?=
 =?utf-8?B?QTROMzNWZWd5L08xWThOYTB0eDlnPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec88e6e-e8d7-461c-af74-08db5ad590b6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 15:02:30.8032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bt6mys/uaCdDlXxB8UU9cGWWZucT5vBcqg/rXQSOOgelEuSbTlWlZqoWyqNZe9GDTkdGeOzxS9ig+oelqyTbGYSZFmdVgdHfx+lwREyOF6Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3705
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 22, 2023 at 05:03:31PM +0530, Parthiban Veerasooran wrote:
> Add support for the Microchip LAN865x Rev.B0 10BASE-T1S Internal PHYs
> (LAN8650/1). The LAN865x combines a Media Access Controller (MAC) and an
> internal 10BASE-T1S Ethernet PHY to access 10BASE‑T1S networks. As
> LAN867X and LAN865X are using the same function for the read_status,
> rename the function as lan86xx_read_status.
> 
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>

Hi Parthiban,

thanks for your patch.
Some minor nits from my side.

...

> +/* This is pulled straigt from AN1760 from 'calulation of offset 1' &
> + * 'calculation of offset 2'
> + */

nit: s/straigt/straight/

> +static int lan865x_generate_cfg_offsets(struct phy_device *phydev, s8 offsets[2])
> +{
> +	const u16 fixup_regs[2] = {0x0004, 0x0008};
> +	int ret;
> +
> +	for (int i = 0; i < ARRAY_SIZE(fixup_regs); i++) {
> +		ret = lan865x_revb0_indirect_read(phydev, fixup_regs[i]);
> +		if (ret < 0)
> +			return ret;
> +		if (ret & BIT(4))
> +			offsets[i] = ret | 0xE0;
> +		else
> +			offsets[i] = ret;
> +	}
> +
> +	return 0;
> +}

...

> +static int lan865x_setup_cfgparam(struct phy_device *phydev)
> +{
> +	u16 cfg_results[5];
> +	u16 cfg_params[ARRAY_SIZE(lan865x_revb0_fixup_cfg_regs)];
> +	s8 offsets[2];
> +	int ret;

nit: Please use reverse xmas tree order - longest line to shortest -
     for local variable declarations in networking code.

...