Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230522123013.1065975-1-trix@redhat.com>
In-Reply-To: <20230522123013.1065975-1-trix@redhat.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 22 May 2023 11:10:58 -0400
Message-ID: <CADnq5_Pc+3YNT0Ymf77zPDKt9Nr2mBYgxgcyqT4PZLQhrD+iRA@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: remove unused variable num_xcc
To:     Tom Rix <trix@redhat.com>
Cc:     alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        Hawking.Zhang@amd.com, le.ma@amd.com, lijo.lazar@amd.com,
        tao.zhou1@amd.com, shiwu.zhang@amd.com,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Mon, May 22, 2023 at 8:30=E2=80=AFAM Tom Rix <trix@redhat.com> wrote:
>
> gcc with W=3D1 reports
> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:2138:13: error: variable
>   =E2=80=98num_xcc=E2=80=99 set but not used [-Werror=3Dunused-but-set-va=
riable]
>  2138 |         int num_xcc;
>       |             ^~~~~~~
>
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/am=
d/amdgpu/gfx_v9_4_3.c
> index e5cfb3adb3b3..63718cf02aa1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -2135,9 +2135,6 @@ static void gfx_v9_4_3_ring_emit_gds_switch(struct =
amdgpu_ring *ring,
>  static int gfx_v9_4_3_early_init(void *handle)
>  {
>         struct amdgpu_device *adev =3D (struct amdgpu_device *)handle;
> -       int num_xcc;
> -
> -       num_xcc =3D NUM_XCC(adev->gfx.xcc_mask);
>
>         adev->gfx.num_compute_rings =3D min(amdgpu_gfx_get_num_kcq(adev),
>                                           AMDGPU_MAX_COMPUTE_RINGS);
> --
> 2.27.0
>