Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 17:35:33 +0200
From:   Francesco Dolcini <francesco@dolcini.it>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Francesco Dolcini <francesco@dolcini.it>,
        Praneeth Bajjuri <praneeth@ti.com>,
        Geet Modi <geet.modi@ti.com>,
        "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Dan Murphy <dmurphy@ti.com>
Subject: Re: DP83867 ethernet PHY regression
Message-ID: <ZGuLxSJwXbSE/Rbb@francesco-nb.int.toradex.com>
References: <ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com>
 <e0d4b397-a8d9-4546-a8a2-14cf07914e64@lunn.ch>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="/zTa0TOsm9Yb+E2A"
Content-Disposition: inline
In-Reply-To: <e0d4b397-a8d9-4546-a8a2-14cf07914e64@lunn.ch>
Precedence: bulk


--/zTa0TOsm9Yb+E2A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 22, 2023 at 05:15:56PM +0200, Andrew Lunn wrote:
> On Mon, May 22, 2023 at 04:58:46PM +0200, Francesco Dolcini wrote:
> > Hello all,
> > commit da9ef50f545f ("net: phy: dp83867: perform soft reset and retain
> > established link") introduces a regression on my TI AM62 based board.
> > 
> > I have a working DTS with Linux TI 5.10 downstream kernel branch, while
> > testing the DTS with v6.4-rc in preparation of sending it to the mailing
> > list I noticed that ethernet is working only on a cold poweron.
> 
> Do you have more details about how it does not work.
> 
> Please could you use:
> 
> mii-tool -vvv ethX

please see the attached files:

working_da9ef50f545f_reverted.txt
  this is on a v6.4-rc, with da9ef50f545f reverted

not_working.txt
  v6.4-rc not working

working.txt
  v6.4-rc working


It looks like, even on cold boot, it's not working in a reliable way.
Not sure the exact difference when it's working and when it's not.

> in both the good and bad state. The register values might give us a
> clue.

Thanks for your help,
Francesco


--/zTa0TOsm9Yb+E2A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="not_working.txt"

Using SIOCGMIIPHY=0x8947
eth0: negotiated 1000baseT-FD flow-control, link ok
  registers for MII PHY 0: 
    1140 796d 2000 a231 05e1 c5e1 006f 2001
    5806 0200 3800 0000 0000 4007 0000 3000
    5048 ac02 ec10 0004 2bc7 0000 0000 0040
    6150 4444 0002 0000 0000 0000 0282 0000
  product info: vendor 08:00:28, model 35 rev 1
  basic mode:   autonegotiation enabled
  basic status: autonegotiation complete, link ok
  capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
  advertising:  1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
  link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control

--/zTa0TOsm9Yb+E2A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="working_da9ef50f545f_reverted.txt"

Using SIOCGMIIPHY=0x8947
eth0: negotiated 1000baseT-FD flow-control, link ok
  registers for MII PHY 0: 
    1140 796d 2000 a231 05e1 c5e1 006d 2001
    5806 0200 3800 0000 0000 4007 0000 3000
    5048 af02 ec10 0000 2bc7 0000 0000 0040
    6150 4444 0002 0000 0000 0000 0282 0000
  product info: vendor 08:00:28, model 35 rev 1
  basic mode:   autonegotiation enabled
  basic status: autonegotiation complete, link ok
  capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
  advertising:  1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
  link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control

--/zTa0TOsm9Yb+E2A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="working.txt"

Using SIOCGMIIPHY=0x8947
eth0: negotiated 1000baseT-FD flow-control, link ok
  registers for MII PHY 0: 
    1140 796d 2000 a231 05e1 c5e1 006f 2001
    5806 0200 3800 0000 0000 4007 0000 3000
    5048 ac02 ec10 0000 2bc7 0000 0000 0040
    6150 4444 0002 0000 0000 0000 0282 0000
  product info: vendor 08:00:28, model 35 rev 1
  basic mode:   autonegotiation enabled
  basic status: autonegotiation complete, link ok
  capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
  advertising:  1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
  link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control

--/zTa0TOsm9Yb+E2A--