Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74679c26-19b1-65fc-a986-8b4a20794327@intel.com>
Date:   Mon, 22 May 2023 17:32:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Intel-wired-lan] [PATCH net-next 10/11] libie: add per-queue
 Page Pool stats
Content-Language: en-US
To:     Paul Menzel <pmenzel@molgen.mpg.de>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        <netdev@vger.kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        Michal Kubiak <michal.kubiak@intel.com>,
        <intel-wired-lan@lists.osuosl.org>,
        "Christoph Hellwig" <hch@lst.de>,
        Magnus Karlsson <magnus.karlsson@intel.com>
References: <20230516161841.37138-1-aleksander.lobakin@intel.com>
 <20230516161841.37138-11-aleksander.lobakin@intel.com>
 <6bebe582-705c-2b7a-3286-1c86a15619f2@molgen.mpg.de>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <6bebe582-705c-2b7a-3286-1c86a15619f2@molgen.mpg.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjZvWHVBbnNOVGNHL2d3Z2FqMElvMngzZXExQjRWdlhKWE9BL2d3N3dVdzlt?=
 =?utf-8?B?WVRiWGkyM08wZTNmRUxLQTZsbldDUzBYaVFNeFpTV2JvbmNORG5ISjYxVGMw?=
 =?utf-8?B?VzUwcnZKMjBZMDB5SGJCNnFhYkZuWGpkWDJDdW10ZHB1ekxXbmw3bjBHZVR2?=
 =?utf-8?B?MXBYaEJ6endNQW1CUnVmQXpsOWtTUHRURFlUemVOSHhQNXpIQkl6aWpDVTNC?=
 =?utf-8?B?My9QL1BwMXVwaEVjTHpkZ3lhNUExZTJIVUNxUlk5N21Hb1Jnd3FuRGtiUXNI?=
 =?utf-8?B?UE5HWmp1K0dRZHZCS2Y4d09aUWJRWWdCaFl1bm1NbXhwc1hhc1FWRWh0bVI3?=
 =?utf-8?B?Q0hCSGtpOXRyWXAxZkt0OHpLTWUzV2lnMlR0K0gveGw0eUUwb2JVRHlSZnZY?=
 =?utf-8?B?bm0vL01jVCt4emlva2tiQ2dmZDVFOENGNnRSTlFXT0NJRklFV0xhVysyTnV0?=
 =?utf-8?B?Q1hNcWt6Z0dLb0JIRndrdVNaWGlhUDcySDNhZkw2Ykd5M1paaVczc3JIaHYx?=
 =?utf-8?B?d1lhOGFEOU5WeVQ5aDV2TERFd2o4U0FneTI5SW5zN2srYVNrM0NWZmVkQWVz?=
 =?utf-8?B?M1pndWRWeFJ3V3dtbHpyU2szYzdCbFpnRHFZVC9jS1UzN0QrbFpnRndLUmZi?=
 =?utf-8?B?YnRkMitKcDdlZGdtT1dlSjd5b1R0YWZFR0JlOGtUUEptTkx1T3VQenhzSk5x?=
 =?utf-8?B?UUgxTTcvRTRGUVBtRCtuVlNzbUo0a21GREd2UzdPVDBjMkFzdmlMUWFVSlNt?=
 =?utf-8?B?alJhN0JLRzJBWE03T0p2S3NqMmY5K1IwcW5GOE9mVmwvcWpvSVJ0N01aTkt6?=
 =?utf-8?B?QjRtdVZURDBPdWkwNFRKbUdXNzMxdnJ4U2twWGQzZS8zUmFzVmZ6MHdGczUy?=
 =?utf-8?B?cmoyWURIUEwvQklla2YzbllkbWZXMElpOUgrRGpkakM0NlRrTTVXUWgyOURa?=
 =?utf-8?B?ejl6QUlUU2FKb2Q1NmpxSmdnODI0UzNWa01qQWYvOHZkQjlxbU1vd0RvMzJN?=
 =?utf-8?B?YWhrdG5VOGs1bUxDTXhNMVdxVXpYcHZqSmtVNmlwMUFwK2RULy9DYmJxYUZL?=
 =?utf-8?B?aksvTVZKUTJOYVlLTUJZMHZaNHM4L3VScVJGbGRIeTFXMU50ZXp4WUJpaVZ2?=
 =?utf-8?B?VGZlSGFxNGpURHpiTHRxWlZFU1Z0RWw2eEFLanBpM3Y1aFUrR0hpaFQwdWVH?=
 =?utf-8?B?eDdmWTZ2emhDUFdsKy9BbUlNdkhMWE82ZndyMm5DVnVDUUV0azRubm9USzJ2?=
 =?utf-8?B?ZkpnTXB5Y3pYeVpHWnpXS0s4YTljUkdhME92ZkV5V01WbjJCWkNvTlJSalNt?=
 =?utf-8?B?MEVRTmtUaWxQS3lWOHMvLzZOMlVVb25rMGRRQ1oya3Mwc1JwZjF4YWdZelcy?=
 =?utf-8?B?aUtWd3JtSklzSEtuRHJNQWphb25Tc280b0svZ09ZcThSV0g0SFFMK1NndzdD?=
 =?utf-8?B?dDZtVUVJSUxCbTNwSlVSWnBvcXowS3VhMXlmcjJHVENxdXRZQ2lqV3VVVDBo?=
 =?utf-8?B?TzRoRHNvTGt6UU1iNzByWFUyLy96MjNaUG00MEFacitZdjdLTHFDb1pZTnc3?=
 =?utf-8?B?RlZGSFAwMVNhQlJFekxyRFNSTjRwd1pwdnhROVZGZ3ZEVURJKzdUT1QzMWYx?=
 =?utf-8?B?czQrNjZvVW1PYkwxdGZoU2RiRnRNVTh4eHNrWWZ1RlZxbFVNamhISHI1TlRp?=
 =?utf-8?B?WHRGSUFYWFpPZTRlMEhUakV0a3pnUFp1ZTVUb1RveXFKOHh6cnRKcFJTQWFh?=
 =?utf-8?B?TDdRa2JJaUtUYyt0c3BYeXpxQk1DUi8vRGtIK2hVQVJtak1xVElBVGlzTUFn?=
 =?utf-8?B?MldvbERJMUV6T2tkdDVTSWIzdGFJeGtMcTl5NmV5UVIycDNHNmJsaFRhcW9U?=
 =?utf-8?B?N2JtckpCeFNFMk9rcnFQZzZFTlRORWJIWjBNV0NObEcyZFRIbmZRcjJLUDN2?=
 =?utf-8?B?RWZ4REw2NDFlWVBCbHM4Nkd0RWpIRHNWUnJHS0I5R1B2d1hDR0pUck1uUWZ1?=
 =?utf-8?B?VHZlQ21tOWVPS2NrSVVqQTdYYVErQWlmR3IvOGJBZVBqYkk2eFlNOEhkaFVt?=
 =?utf-8?B?b094ZE9NdnMyUmlsRU9xb3JFQWlyMkdsaUhrR3hjT0lldGw0WUMyMXhJdUhh?=
 =?utf-8?B?VjhjQ3VEK0pKUEZQWElKSU83amJuaXJCNFpxQUpTVFg4bXA5b1o3WkFEbVRK?=
 =?utf-8?B?b1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 67d35398-f093-4cc1-1654-08db5ad9fa4d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 15:34:05.8778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Nan0X2Ip+1WfSIY/ERixJfYp47Ho05Ft4JuXI1wLuuuyT51qcRRWwHIaicB+kibXQSp9c31j4ADJjPYEIfmBy3cC96gbgRRIzfXpmtXBUk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8569
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Paul Menzel <pmenzel@molgen.mpg.de>
Date: Mon, 22 May 2023 17:05:28 +0200

> Dear Alexander,
> 
> 
> Thank you for your patch.
> 
> Am 16.05.23 um 18:18 schrieb Alexander Lobakin:
>> Expand the libie generic per-queue stats with the generic Page Pool
>> stats provided by the API itself, when CONFIG_PAGE_POOL is enable.
> 
> enable*d*

Oof, nice catch, thanks! I rely on codespell and checkpatch too much,
but from standalone-word-spelling PoV everything is fine here :s :D

> 
>> When it's not, there'll be no such fields in the stats structure, so
>> no space wasted.
>> They are also a bit special in terms of how they are obtained. One
>> &page_pool accumulates statistics until it's destroyed obviously,
>> which happens on ifdown. So, in order to not lose any statistics,
>> get the stats and store in the queue container before destroying
>> a pool. This container survives ifups/downs, so it basically stores
>> the statistics accumulated since the very first pool was allocated
>> on this queue. When it's needed to export the stats, first get the
>> numbers from this container and then add the "live" numbers -- the
>> ones that the current active pool returns. The result values will
>> always represent the actual device-lifetime* stats.
>> There's a cast from &page_pool_stats to `u64 *` in a couple functions,
>> but they are guarded with stats asserts to make sure it's safe to do.
>> FWIW it saves a lot of object code.

[...]

> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul

Thanks,
Olek