Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <21522575-f6ef-5c8b-4a0a-0f2c208afa66@intel.com>
Date:   Mon, 22 May 2023 17:36:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH RESEND bpf-next 01/15] ice: make RX hash reading code more
 reusable
Content-Language: en-US
To:     Larysa Zaremba <larysa.zaremba@intel.com>
CC:     <bpf@vger.kernel.org>, Stanislav Fomichev <sdf@google.com>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        "KP Singh" <kpsingh@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Anatoly Burakov <anatoly.burakov@intel.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        "Magnus Karlsson" <magnus.karlsson@gmail.com>,
        Maryam Tahhan <mtahhan@redhat.com>,
        <xdp-hints@xdp-project.net>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230512152607.992209-1-larysa.zaremba@intel.com>
 <20230512152607.992209-2-larysa.zaremba@intel.com>
 <0c40b366-cdb5-f868-00c3-d8f485452cce@intel.com> <ZGuEWl/LwtXxYgkE@lincoln>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZGuEWl/LwtXxYgkE@lincoln>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1FUeWVxaEs2bThOK2NWZlhoSm5qcmpqNWdrdDZCeEdzUHUvMzJybFVsYncv?=
 =?utf-8?B?NWFoVS84UGU4cnR1Z2pPMWFrTy94YTVBWlhXbWVucVF3eFd6akdPSFFBZlZ0?=
 =?utf-8?B?V2hsZ056aXROZHJJajRIM1cxOHNNK1B6VkNnNGhrcEd1WGIvMzhqcUo2akdk?=
 =?utf-8?B?UVNXeHR1RWpKSmUwdmpOM2N1YnpEdzgvSmZWRVNrZ3BvSGt5b3hwT3BqRWQw?=
 =?utf-8?B?andLRzY2QXVhSGp5UllvVzZsSElhSzh1U3FuODA1TmtUd0pDM3Z3ZGgrbmQx?=
 =?utf-8?B?NjhTb1I3eE1vVDlkUUNQL2tldVNmb3hRc2djdXNySkordlh1Rnhtcmk4NWx4?=
 =?utf-8?B?S2xZK3MxUnF2YmlSSVFEL3FKai9EeHJkcE9Gc1ZrMjR0YTFVdjlma1l5bzYy?=
 =?utf-8?B?ekNKRHBwNDVWbUhoRjJPUmJpcWhNNEJqV1RCWkVKQ3RFbWFzc0JuNE10WEtZ?=
 =?utf-8?B?eUk4Wk9teUo0YUxjdmg0L3FSMWg5bU53akZGamhEM0tpemMwd3JqMTRDZkVM?=
 =?utf-8?B?czBXS09LWGV6RW11RXJxbXRiTkM5QURTODcvVzFVRnQ1T3daV2owa0JYcUxY?=
 =?utf-8?B?Nlg1aXh3UHVxdHovZWI2WHdNdUIxLytLRk12cmsxY3Z1aGo0d0lzZWFaMlVL?=
 =?utf-8?B?ZllvTklPMk5XcU5WaHR2ZjlkWTNqM0NXQnlmaXlXSEMwVm9kZEdFczVqMTZN?=
 =?utf-8?B?OFV4clVNRVlpSGp3N1M2Z284YkFFQXcwek0rZGdFVGwwVDJ3cEpGTTdoUGxm?=
 =?utf-8?B?eHY1RnBXdHd1dVBKclZwbGFld2ZMRUNqWUhrTU5UWCttMVBDbEVoN0NZSmk4?=
 =?utf-8?B?VzdheW96UWt1UTRYNzdidVpIWU1ZNVVWZEhtWTEvNEZBaDFsMUNTU2dlWFFv?=
 =?utf-8?B?N3Ryc3d2a2t4UGlYL2VhQnpGZnMwSHI0S2dBT29zWTM5SzZzRVhBUFVDODVp?=
 =?utf-8?B?Sngzc3VnQ0ZvazZMcFFMakJ5NHprdmxXOFJVS05vRzBmbkVmSGxjSHI5bjcv?=
 =?utf-8?B?M0RXeUhGTTRlRUg4OFhzVXpWR1hIcjFkYmx3OTNrWmVMTDIyUGt0UlRQUUR0?=
 =?utf-8?B?MnJyWDB6T2NCNHJNREk4M0Vkc1VIVU0zM3hZY1NoQkFiOHUwa0JDbEdBY25N?=
 =?utf-8?B?d25DcDdKaFZSdXM3eUJUeXJCZldCZVBlYVhrcmtmV1dnWk1yeUNkaXgrbUIz?=
 =?utf-8?B?cUExamp4NnBxZ1hrallQdStST1FJT1FqT3BFdFRFYjJ3aDVWaDBhbW5icDZm?=
 =?utf-8?B?eFlGT1JGUnliMFk5TVo4Z3VLWlFqYlJtSFpVaWJHM3FuNHE5V1FTdC9jck1O?=
 =?utf-8?B?UTJteU1TWENtc0pZd1hYdWJJekhPSXZtdGlSOXBncWEzdEpaSUhxMzh6YVhn?=
 =?utf-8?B?ZmxhWjNkRlpzdXh2VkxzNnI5eTMwdXgvY0RVdWd2REtRTDE3L3JHWDZZYzBQ?=
 =?utf-8?B?ZTljSThOUURaZDNmOGFselprenpoYjczSEVCZzIvVnUzT1h3N1hvODJydW9C?=
 =?utf-8?B?SXZCdHRSYUNTaTZCNzNQUGlVakFvZzRLRzdKd2lEWVFJZ0tjOVJnQWkxZXFh?=
 =?utf-8?B?TytnLzgrTGV2WVF6bEhTeXNNQ2FqMVRjRnQ3eDk2WmdHendQL3o0OHp2KzZq?=
 =?utf-8?B?dzFtYXdQRjZ5QUdFazN0SEcxWDFqYVhIT3ZmUmloK2dsU3p6c2VLbUVBVXEr?=
 =?utf-8?B?QWsxWWtPVDQ3dm9lOHVnS1FhcSt3SGxvNTNOOEVTTWppM2wyUHpHVThFa0px?=
 =?utf-8?B?YnREanZXa2NlL3V6STVEQVJBZGpjaTVpejFWVEpuRjZvc2JhVDZIa3RINFh6?=
 =?utf-8?B?dkNCZldoWmJnWHp1MXdMenQrUDdGLzBjUVFOaVA2OTduL09Gc25tREhWaWVl?=
 =?utf-8?B?TG9aWlVOYjJObmVDZzg4ZVR0amNKaDJjcDVsYU9pSHFKSExXSVl5YTdjZmlv?=
 =?utf-8?B?OVRwYm51RHBHSjkxOFNqd1lJYlhjVHNJUXBHWGVNL0IzRjQ3ek5ScEYzMEFD?=
 =?utf-8?B?djUzWG11R0ttdzVWQSs0MjRCYlMvRWpiNTVjQ21wSk5oQU9WWUFjaml0eGdC?=
 =?utf-8?B?STJCRzJyYjVMek9TSjk4aG5Gd25rY0dnMFhqTm45aC82cFlDbWZ6Q21zWXFn?=
 =?utf-8?B?SE8wTzdaREQyTFVBSjZLc3c3NDNUMGFGMTE0TjF1M01HWHdZR3BUbnc1c1pW?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a9e02455-556b-4659-5db5-08db5ada936d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 15:38:22.9066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jKkmTRG2QqWGkNoG6e2Jic672U8y4n4qp23ZC+KvVa3WmIG9SqgQI0+0O+UiP8b/cBNvRnDozJp2QUFGBDCC0/Ji/tXUciVStZFBecN0IME=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8569
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Larysa Zaremba <larysa.zaremba@intel.com>
Date: Mon, 22 May 2023 17:03:54 +0200

> On Fri, May 19, 2023 at 06:46:31PM +0200, Alexander Lobakin wrote:
>> From: Larysa Zaremba <larysa.zaremba@intel.com>
>> Date: Fri, 12 May 2023 17:25:53 +0200

[...]

>>> +	nic_mdid = (struct ice_32b_rx_flex_desc_nic *)rx_desc;
>>> +	*dst = le32_to_cpu(nic_mdid->rss_hash);
>>> +	return true;
>>
>> You can just return the hash. `hash == 0` means there's no hash, so it
>> basically means `false`, while non-zero is `true`.
> 
> Agree about both hash and timestamp.
> 
> Taking this comment and the earlier on into account, I'll name functions like
> that:
> 
> ice_get_rx_hash()
> ice_get_vlan_tag()
> ice_ptp_get_rx_hwts_ns()

Sounds good to me!

[...]

Thanks,
Olek