Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Luca Weiss <luca@z3ntu.xyz>
To:     linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht
Cc:     ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Matti =?ISO-8859-1?Q?Lehtim=E4ki?= <matti.lehtimaki@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matti =?ISO-8859-1?Q?Lehtim=E4ki?= <matti.lehtimaki@gmail.com>
Subject: Re: [PATCH v2 4/4] ARM: dts: qcom: msm8226: Add IMEM node
Date:   Mon, 22 May 2023 18:11:17 +0200
Message-ID: <4828763.31r3eYUQgx@z3ntu.xyz>
In-Reply-To: <20230520121933.15533-5-matti.lehtimaki@gmail.com>
References: <20230520121933.15533-1-matti.lehtimaki@gmail.com>
 <20230520121933.15533-5-matti.lehtimaki@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On Samstag, 20. Mai 2023 14:19:33 CEST Matti Lehtim=E4ki wrote:
> This enables userspace to signal the bootloader to go into the
> bootloader or recovery mode.
>=20
> The magic values can be found in both the downstream kernel and the LK
> kernel (bootloader).
>=20
> Signed-off-by: Matti Lehtim=E4ki <matti.lehtimaki@gmail.com>

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> ---
> Changes in v2:
>   - Always enable IMEM node
>   - Move reboot-mode magic numbers to platform,
>     those should be always the same
> ---
>  arch/arm/boot/dts/qcom-msm8226.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>=20
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi
> b/arch/arm/boot/dts/qcom-msm8226.dtsi index 8644540f5aae..284b7c666fea
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -641,6 +641,20 @@ smd-edge {
>  				label =3D "lpass";
>  			};
>  		};
> +
> +		sram@fe805000 {
> +			compatible =3D "qcom,msm8226-imem", "syscon",=20
"simple-mfd";
> +			reg =3D <0xfe805000 0x1000>;
> +
> +			reboot-mode {
> +				compatible =3D "syscon-reboot-mode";
> +				offset =3D <0x65c>;
> +
> +				mode-bootloader =3D <0x77665500>;
> +				mode-normal     =3D <0x77665501>;
> +				mode-recovery   =3D <0x77665502>;
> +			};
> +		};
>  	};
>=20
>  	timer {