Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 17:20:40 +0100
From:   "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To:     Shenwei Wang <shenwei.wang@nxp.com>
Cc:     Sherry Sun <sherry.sun@nxp.com>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] tty: serial: fsl_lpuart: Check the return value of
 dmaengine_tx_status
Message-ID: <2023052225-slimy-struggle-6fee@gregkh>
References: <20230522025111.3747-1-sherry.sun@nxp.com>
 <PAXPR04MB918546704F3DB435675B747A89439@PAXPR04MB9185.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PAXPR04MB918546704F3DB435675B747A89439@PAXPR04MB9185.eurprd04.prod.outlook.com>
Precedence: bulk

On Mon, May 22, 2023 at 02:45:12PM +0000, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Sherry Sun <sherry.sun@nxp.com>
> > Sent: Sunday, May 21, 2023 9:51 PM
> > To: gregkh@linuxfoundation.org; jirislaby@kernel.org; Shenwei Wang
> > <shenwei.wang@nxp.com>; ilpo.jarvinen@linux.intel.com
> > Cc: linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> > <linux-imx@nxp.com>
> > Subject: [PATCH] tty: serial: fsl_lpuart: Check the return value of
> > dmaengine_tx_status
> > 
> > Coverity reports the Unchecked return value (CHECKED_RETURN) warning:
> > Calling dmaengine_tx_status without checking return value.
> > 
> > So here add the return value check for dmaengine_tx_status() function to make
> > coverity happy.
> > 
> > Fixes: cf9aa72d2f91 ("tty: serial: fsl_lpuart: optimize the timer based EOP logic")
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  drivers/tty/serial/fsl_lpuart.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> > 92a3bd0f4158..f2a47a8c5b85 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -1286,13 +1286,19 @@ static void lpuart_dma_rx_complete(void *arg)
> > static void lpuart_timer_func(struct timer_list *t)  {
> >  	struct lpuart_port *sport = from_timer(sport, t, lpuart_timer);
> > +	enum dma_status dmastat;
> 
> Should be reverse Christmas tree order.

Not a requirement at all, please don't force it.

thanks,

greg k-h