Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 17:35:37 +0100
From:   Lee Jones <lee@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Martin Kurbanov <mmkurbanov@sberdevices.ru>,
        Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, kernel@sberdevices.ru
Subject: Re: [PATCH v4 2/2] leds: add aw20xx driver
Message-ID: <20230522163537.GR404509@google.com>
References: <20230517195238.34069-1-mmkurbanov@sberdevices.ru>
 <20230517195238.34069-3-mmkurbanov@sberdevices.ru>
 <CAHp75VdEc9x=v-NU4wqrg-S0vEjqc27JPqZAK0TJsNUc37ZTmg@mail.gmail.com>
 <20230522071426.GP404509@google.com>
 <CAHp75VdG6nSHgzmp9yA2aAwvzWuaYf2Q71tz2ruDPnwb=h=hiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75VdG6nSHgzmp9yA2aAwvzWuaYf2Q71tz2ruDPnwb=h=hiQ@mail.gmail.com>
Precedence: bulk

On Mon, 22 May 2023, Andy Shevchenko wrote:

> On Mon, May 22, 2023 at 10:14 AM Lee Jones <lee@kernel.org> wrote:
> > On Thu, 18 May 2023, Andy Shevchenko wrote:
> > > On Wed, May 17, 2023 at 10:52 PM Martin Kurbanov
> > > <mmkurbanov@sberdevices.ru> wrote:
> 
> ...
> 
> > > I would do
> > >
> > >   i = 0;
> > >
> > > here and drop the assignment in the definition block to be more robust
> >
> > "here" where?
> 
> > You've removed all context.
> 
> That's not true. The below line exclusively defines the location in
> the code that I'm talking about. Note, Martin understood that AFAICT
> and addressed in the new version.

I'd expect the author to have a solid understanding of the code.  I
found this difficult to read as-was and had to go look at the patch to
understand it.

No biggy.  Just something to bear in mind.

> > > against sudden reuse of i in between.
> > >
> > > > +       device_for_each_child_node(dev, child) {
> > >
> > > > +               i++;
> > > > +       }
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenk

-- 
Lee Jones [李琼斯]