Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 18:11:58 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Feng Tang <feng.tang@intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, paulmck@kernel.org,
        rui.zhang@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org,
        bin.gao@intel.com
Subject: Re: [PATCH RFC] x86/tsc: Make recalibration default on for
 TSC_KNOWN_FREQ cases
Message-ID: <20230522161158.GA3330346@hirez.programming.kicks-ass.net>
References: <20230522033018.1276836-1-feng.tang@intel.com>
 <87h6s4ye9b.ffs@tglx>
 <ZGssENXFKmOk/zL7@feng-clx>
 <87zg5wwppa.ffs@tglx>
 <ZGtnUQJy+1Nrazhy@feng-clx>
 <87pm6swi7z.ffs@tglx>
 <ZGuIL6tyzzZP3kyR@feng-clx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZGuIL6tyzzZP3kyR@feng-clx>
Precedence: bulk

On Mon, May 22, 2023 at 11:20:15PM +0800, Feng Tang wrote:

> And I don't understand the commit log: "On Intel GOLDMONT Atom SoC
> TSC is the only reliable clocksource. We mark TSC reliable to avoid
> watchdog on it."
> 
> Clearly the Denventon I found today has both HPET and ACPI_PM timer:
> 
>   [root@dnv0 ~]# grep .  /sys/devices/system/clocksource/clocksource0/*
>   /sys/devices/system/clocksource/clocksource0/available_clocksource:tsc hpet acpi_pm
>   /sys/devices/system/clocksource/clocksource0/current_clocksource:tsc
>   
> The lscpu info is:
>   
>   Architecture:                    x86_64
>   CPU op-mode(s):                  32-bit, 64-bit
>   Address sizes:                   39 bits physical, 48 bits virtual
>   Byte Order:                      Little Endian
>   CPU(s):                          12
>   On-line CPU(s) list:             0-11
>   Vendor ID:                       GenuineIntel
>   BIOS Vendor ID:                  Intel(R) Corporation
>   Model name:                      Intel(R) Atom(TM) CPU C3850 @ 2.10GHz
>   BIOS Model name:                 Intel(R) Atom(TM) CPU C3850 @ 2.10GHz  CPU @ 2.1GHz
>   BIOS CPU family:                 43
>   CPU family:                      6
>   Model:                           95
>   Thread(s) per core:              1
>   Core(s) per socket:              12
>   Socket(s):                       1
>   Stepping:                        1
> 
> Maybe this cpu model (0x5F) has been used by some type of platforms
> which has met the false alarm watchdog issue.

It has them; but they are not *reliable*.