Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c14fedc0-26f6-d4be-8e8b-b1dbefdf50c7@wanadoo.fr>
Date:   Mon, 22 May 2023 19:24:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] cpufreq: intel_pstate: Avoid initializing variables
 prematurely
Content-Language: fr, en-US
To:     Fieah Lim <kweifat@gmail.com>, srinivas.pandruvada@linux.intel.com,
        lenb@kernel.org, rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230520133249.22689-1-kweifat@gmail.com>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20230520133249.22689-1-kweifat@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 20/05/2023 à 15:32, Fieah Lim a écrit :
> all_cpu_data struct is pretty large,
> we should avoid assigning it around when the function has a chance
> to bail out earlier before actually using it.
> 
> The same idea applies to the
> this_cpu of notify_hwp_interrupt
> and
> the hwp_cap of intel_pstate_hwp_boost_up,
> which are also initialized prematurely.
> I think it also qualifies as a micro-optimization.
> 
> While at it, tidy up all the cpu_data initialization,
> for the sake of consistency.
> 
> Signed-off-by: Fieah Lim <kweifat@gmail.com>
> ---

[...]

> @@ -2638,9 +2643,7 @@ static int intel_cpufreq_cpu_offline(struct cpufreq_policy *policy)
>   
>   static int intel_pstate_cpu_online(struct cpufreq_policy *policy)
>   {
> -	struct cpudata *cpu = all_cpu_data[policy->cpu];
> -
> -	pr_debug("CPU %d going online\n", cpu->cpu);
> +	pr_debug("CPU %d going online\n", policy->cpu);

An answer has already been done, but just in case, this change does not 
look equivalent.

CJ

>   
>   	intel_pstate_init_acpi_perf_limits(policy);
>   
> @@ -2649,6 +2652,8 @@ static int intel_pstate_cpu_online(struct cpufreq_policy *policy)
>   		 * Re-enable HWP and clear the "suspended" flag to let "resume"
>   		 * know that it need not do that.
>   		 */
> +		struct cpudata *cpu = all_cpu_data[policy->cpu];
> +
>   		intel_pstate_hwp_reenable(cpu);
>   		cpu->suspended = false;
>   	}