Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 18:39:32 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Neil Armstrong <neil.armstrong@linaro.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible
Message-ID: <20230522-childhood-eastbound-06a5f02f1f4a@spud>
References: <20230522-topic-sm8550-upstream-pm8550-lpg-v1-1-f016578d9e63@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="1qfQUUVRK2UvHwkM"
Content-Disposition: inline
In-Reply-To: <20230522-topic-sm8550-upstream-pm8550-lpg-v1-1-f016578d9e63@linaro.org>
Precedence: bulk


--1qfQUUVRK2UvHwkM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 22, 2023 at 06:26:01PM +0200, Neil Armstrong wrote:
> The PM8550 PWM modules are compatible with the PM8350c PWM modules,
> document the PM8350c PWM compatible as fallback for the PM8550 PWM.
>=20
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

I suppose you picked "items/enum", rather than "items/const" to reduce
future churn?
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  .../devicetree/bindings/leds/leds-qcom-lpg.yaml    | 30 +++++++++++++---=
------
>  1 file changed, 18 insertions(+), 12 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/=
Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 6295c91f43e8..fa378ee05c16 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -16,18 +16,24 @@ description: >
> =20
>  properties:
>    compatible:
> -    enum:
> -      - qcom,pm660l-lpg
> -      - qcom,pm8150b-lpg
> -      - qcom,pm8150l-lpg
> -      - qcom,pm8350c-pwm
> -      - qcom,pm8916-pwm
> -      - qcom,pm8941-lpg
> -      - qcom,pm8994-lpg
> -      - qcom,pmc8180c-lpg
> -      - qcom,pmi8994-lpg
> -      - qcom,pmi8998-lpg
> -      - qcom,pmk8550-pwm
> +    oneOf:
> +      - enum:
> +          - qcom,pm660l-lpg
> +          - qcom,pm8150b-lpg
> +          - qcom,pm8150l-lpg
> +          - qcom,pm8350c-pwm
> +          - qcom,pm8916-pwm
> +          - qcom,pm8941-lpg
> +          - qcom,pm8994-lpg
> +          - qcom,pmc8180c-lpg
> +          - qcom,pmi8994-lpg
> +          - qcom,pmi8998-lpg
> +          - qcom,pmk8550-pwm
> +      - items:
> +          - enum:
> +              - qcom,pm8550-pwm
> +          - const: qcom,pm8350c-pwm
> +
> =20
>    "#pwm-cells":
>      const: 2
>=20
> ---
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
> change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d
>=20
> Best regards,
> --=20
> Neil Armstrong <neil.armstrong@linaro.org>
>=20

--1qfQUUVRK2UvHwkM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGuo1AAKCRB4tDGHoIJi
0p6EAQDTIZTlFFa55WeO6xB3Ese2p9pWCG0HVK0S/9lsyT/vQgEAqmnB1lZVPXFo
H7E/qCropV1xS+Vq+mRyzXy6AflNGA0=
=QH2B
-----END PGP SIGNATURE-----

--1qfQUUVRK2UvHwkM--