Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230521160426.1881124-1-masahiroy@kernel.org> <20230521160426.1881124-7-masahiroy@kernel.org>
In-Reply-To: <20230521160426.1881124-7-masahiroy@kernel.org>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 22 May 2023 11:23:04 -0700
Message-ID: <CAKwvOd=rV7gR9kpS3-qCH_H30PurGhoz5OmF5R3b7KvWBpqVCg@mail.gmail.com>
Subject: Re: [PATCH v6 06/20] modpost: unify 'sym' and 'to' in default_mismatch_handler()
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, May 21, 2023 at 9:05=E2=80=AFAM Masahiro Yamada <masahiroy@kernel.o=
rg> wrote:
>
> find_tosym() takes 'sym' and stores the return value to another
> variable 'to'. You can use the same variable because we want to
> replace the original one when appropriate.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
>  scripts/mod/modpost.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 6ac0d571542c..7848bacd4b42 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1166,11 +1166,10 @@ static bool is_executable_section(struct elf_info=
 *elf, unsigned int secndx)
>
>  static void default_mismatch_handler(const char *modname, struct elf_inf=
o *elf,
>                                      const struct sectioncheck* const mis=
match,
> -                                    Elf_Rela *r, Elf_Sym *sym,
> +                                    Elf_Rela *r, Elf_Sym *tsym,
>                                      unsigned int fsecndx, const char *fr=
omsec,
>                                      const char *tosec)
>  {
> -       Elf_Sym *to;
>         Elf_Sym *from;
>         const char *tosym;
>         const char *fromsym;
> @@ -1178,8 +1177,8 @@ static void default_mismatch_handler(const char *mo=
dname, struct elf_info *elf,
>         from =3D find_fromsym(elf, r->r_offset, fsecndx);
>         fromsym =3D sym_name(elf, from);
>
> -       to =3D find_tosym(elf, r->r_addend, sym);
> -       tosym =3D sym_name(elf, to);
> +       tsym =3D find_tosym(elf, r->r_addend, tsym);
> +       tosym =3D sym_name(elf, tsym);
>
>         /* check whitelist - we may ignore it */
>         if (!secref_whitelist(fromsec, fromsym, tosec, tosym))
> @@ -1214,7 +1213,7 @@ static void default_mismatch_handler(const char *mo=
dname, struct elf_info *elf,
>                               "You might get more information about where=
 this is\n"
>                               "coming from by using scripts/check_extable=
.sh %s\n",
>                               fromsec, (long)r->r_offset, tosec, modname)=
;
> -               else if (is_executable_section(elf, get_secindex(elf, sym=
)))
> +               else if (is_executable_section(elf, get_secindex(elf, tsy=
m)))
>                         warn("The relocation at %s+0x%lx references\n"
>                              "section \"%s\" which is not in the list of\=
n"
>                              "authorized sections.  If you're adding a ne=
w section\n"
> --
> 2.39.2
>


--=20
Thanks,
~Nick Desaulniers