Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230517195238.34069-1-mmkurbanov@sberdevices.ru>
 <20230517195238.34069-3-mmkurbanov@sberdevices.ru> <CAHp75VdEc9x=v-NU4wqrg-S0vEjqc27JPqZAK0TJsNUc37ZTmg@mail.gmail.com>
 <20230522071426.GP404509@google.com> <CAHp75VdG6nSHgzmp9yA2aAwvzWuaYf2Q71tz2ruDPnwb=h=hiQ@mail.gmail.com>
 <20230522163537.GR404509@google.com>
In-Reply-To: <20230522163537.GR404509@google.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 22 May 2023 21:52:58 +0300
Message-ID: <CAHp75Ve4EAAj+6VTtYPS-5n+RSobN6ZcwS61kHFaGzHQ-8YhYw@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] leds: add aw20xx driver
To:     Lee Jones <lee@kernel.org>
Cc:     Martin Kurbanov <mmkurbanov@sberdevices.ru>,
        Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, kernel@sberdevices.ru
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 22, 2023 at 7:35=E2=80=AFPM Lee Jones <lee@kernel.org> wrote:
> On Mon, 22 May 2023, Andy Shevchenko wrote:
> > On Mon, May 22, 2023 at 10:14=E2=80=AFAM Lee Jones <lee@kernel.org> wro=
te:
> > > On Thu, 18 May 2023, Andy Shevchenko wrote:
> > > > On Wed, May 17, 2023 at 10:52=E2=80=AFPM Martin Kurbanov
> > > > <mmkurbanov@sberdevices.ru> wrote:

...

> > > > I would do
> > > >
> > > >   i =3D 0;
> > > >
> > > > here and drop the assignment in the definition block to be more rob=
ust
> > >
> > > "here" where?
> >
> > > You've removed all context.
> >
> > That's not true. The below line exclusively defines the location in
> > the code that I'm talking about. Note, Martin understood that AFAICT
> > and addressed in the new version.
>
> I'd expect the author to have a solid understanding of the code.  I
> found this difficult to read as-was and had to go look at the patch to
> understand it.

I see your point.

> No biggy.  Just something to bear in mind.

No worries, and thanks for the remark. I'll try my best to satisfy
others and not only the author of the code in the future reviews.

> > > > against sudden reuse of i in between.
> > > >
> > > > > +       device_for_each_child_node(dev, child) {
> > > >
> > > > > +               i++;
> > > > > +       }


--=20
With Best Regards,
Andy Shevchenko