Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3420184rwd; Mon, 22 May 2023 13:32:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7EF7/W2VL7x5XtaKsEPfQa7vr+fwPCHsWRZwNZjhQnNV1LQlX/22UZT4GC2gSzB/82PZbJ X-Received: by 2002:a17:902:ced0:b0:1af:b9ed:1677 with SMTP id d16-20020a170902ced000b001afb9ed1677mr3058574plg.2.1684787418315; Mon, 22 May 2023 13:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684787418; cv=none; d=google.com; s=arc-20160816; b=p/sL03nZmmwDUfnA7aGz2dpyylCMOGp7GuPwvQgVtTYdlP1zbF+CSKcdiz5CdItyb1 kOvaI/6rEDxlI8kJPv95a7UvYvmA4vjyQpdHc/Eo4+ceTw0mTYCPgzM75WqtXOZiVhBX QQCb0usFyu9XHuSv18YTTJKkk5DyDfD66kDdpgbQdqnNigS8rtAVFMhDIOff/d5IzQPs KTVJs1AgH6nqoQqeIU2tKzVOvOm/ftgAEWIc8kzK3tqSYd1ZV8S1AwMNdzBRF8DQoXPr Swb0Pz91ILAV1EEdsNQeXcNWJ1EdGYgO0wYRHCXiZn5FBpLXS5qyMoMO5QJ/MYL0ZnBc o5EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Wy70a+mVez3Qz0LaapqBVkB3rmaOufaFy8lIMjudB8I=; b=jdn+1DR5t2i/gOv6CXmicrTfBHL6aAJNdc9+0jQc+WNmFIxkmb7WJyTxzLwfe78IoO 4vb9v6oJRPIEHVMop3/WQycAO0Az4bTlFMMyh4VwJeRTYXX3/mn/k7mQ3FFShKXKwQpH 1ePifNMsEouEGpwdJmk7eIv9nt3nap1qN1pBZFwqN9Ye79lYxefxaMuDdtRCNjDRTyHu fv1ISavvEnqXIeCOzumNFxVYe9zLQ3ZEeSHOZ8s80Wc8Qk0+ZYLI5GOit360FtO1VlZM XsBfwuI7sHu4xahub8b/8w7mageKbYezajjgMQnHqigkNoDtmYl8rvB7Jxqe+2uJg/UZ XBgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XF7Ky8Rm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a17090301c500b001adec0d4391si5285756plh.48.2023.05.22.13.29.33; Mon, 22 May 2023 13:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XF7Ky8Rm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232921AbjEVUM5 (ORCPT + 99 others); Mon, 22 May 2023 16:12:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbjEVUM4 (ORCPT ); Mon, 22 May 2023 16:12:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0A2A9; Mon, 22 May 2023 13:12:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6F1262B86; Mon, 22 May 2023 20:12:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADAA2C433EF; Mon, 22 May 2023 20:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684786374; bh=X+V0TTDz8Mqt3pN5GJ6h4caGEtPDpRHhQ5Zzn6UlqkA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XF7Ky8RmlfTLRxNETe3aUKuftCpz32Gu97nKEXJiCHaV6nJ1QMnFGNWcCfIyZg0U9 XmCHT1jFc3GoFeIPRoqwVU1gm9MhgRttrCsYJV7nJHGzVNXLkKTwRougMI1A4EygSp RWfLvjJBnKnIzNZLq/Ct5ZqOeMjsN/Q8XFVktp6eyW5j8YOfJEkzHlA8C2IgDyraaj IdsH7QPe2PqeOna8dpqhw2ZueiS1Ajun96fA0zEXVZEmin32hpTkv6+3MC56MiZkee s+HGjRjexEtnTi5OUrclbykxTqRkHAghgsHueF11wWfQTlHoWaDBo4AjLJM4DwIvgm IlIz1i0OJbSdQ== Date: Mon, 22 May 2023 13:12:52 -0700 From: Jakub Kicinski To: Simon Horman Cc: Christian Brauner , kernel test robot , Eric Dumazet , Alexander Mikhalitsyn , davem@davemloft.net, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Paolo Abeni , Leon Romanovsky , David Ahern , Arnd Bergmann , Kees Cook , Kuniyuki Iwashima , Lennart Poettering , Luca Boccassi , linux-arch@vger.kernel.org Subject: Re: [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD Message-ID: <20230522131252.4f9959d3@kernel.org> In-Reply-To: References: <20230517113351.308771-2-aleksandr.mikhalitsyn@canonical.com> <202305202107.BQoPnLYP-lkp@intel.com> <20230522-sammeln-neumond-e9a8d196056b@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2023 15:19:17 +0200 Simon Horman wrote: > > TLI, that AF_UNIX can be a kernel module... > > I'm really not excited in exposing pidfd_prepare() to non-core kernel > > code. Would it be possible to please simply refuse SO_PEERPIDFD and > > SCM_PIDFD if AF_UNIX is compiled as a module? I feel that this must be > > super rare because it risks breaking even simplistic userspace. > > It occurs to me that it may be simpler to not allow AF_UNIX to be a module. > But perhaps that breaks something for someone... Both of the two options (disable the feature with unix=m, make unix bool) could lead to breakage, I reckon at least the latter makes the breakage more obvious? So not allowing AF_UNIX as a module gets my vote as well. A mechanism of exporting symbols for core/internal use only would find a lot of use in networking :(