Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Chao Yu <chao@kernel.org>
Cc:     martin.petersen@oracle.com, jejb@linux.ibm.com, hch@infradead.org,
        bvanassche@acm.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq17ct0nijm.fsf@ca-mkp.ca.oracle.com>
References: <20230310123604.1820231-1-chao@kernel.org>
        <b53321ab-679d-e007-6407-6bd00149948e@kernel.org>
Date:   Mon, 22 May 2023 17:51:20 -0400
In-Reply-To: <b53321ab-679d-e007-6407-6bd00149948e@kernel.org> (Chao Yu's
        message of "Wed, 17 May 2023 11:49:03 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oPRbteob8oGdSMkn9aklvFT3ZjnmRnLihgn1HVfiKLAZcQ0T5qe2/49FOHF1?=
 =?us-ascii?Q?l0ZkiJZWpN5gBn3vieMAUeSs3PVAw/z+hSXrtB296UHSIxY7nVTeSuVe1bxw?=
 =?us-ascii?Q?leGa1g6+4RjNieWdfkX1BsGzphqO3CB9Vv/TucL7XLH+cDHuS8CO/EosJhtR?=
 =?us-ascii?Q?p1xlo+Ht25awxRRN9YvgtyK+YoXkmG47+QK/6ywcg2YI6gGXavvAOQz9dwDX?=
 =?us-ascii?Q?HLpFrGkWKQ8fdoNj2K/fw1TUpDGtYSjRPv03ZFyl7TxRd0hLzMYaIMM61JSm?=
 =?us-ascii?Q?nFLeIRL1z8DSJR+a6zmBJyPq/bd2bi8JSQLCOJWFj2kXXn28X1Hnh5R6f0jt?=
 =?us-ascii?Q?DxhvhPgTWGemHflbv9t/Ad1AYXcF/f1tGq4HEAoZAynqN5e++IyaS4I+wgCJ?=
 =?us-ascii?Q?G8tnIMB3QCztz+/R07aAeYBc0PQIf3bYtw4gBRwM5Ckk48GC1MurJZNeaQYy?=
 =?us-ascii?Q?wsKM0LsAU/QhJpE5czbtuImjwyHN+kTG8LA7tPw+HRlwRCK6Ma2XeGNiDhZj?=
 =?us-ascii?Q?Yg/UPwOTv8Qq5Ly0X4zjF8kPg3tcHzBdpcXUyHEkAmfgeDnB7H/+XphS0wic?=
 =?us-ascii?Q?iKFbZPSxuMrvVlekzONh7KH+rXETthWJs9k6ldnnpqTsEjGw/TyaokIp0moZ?=
 =?us-ascii?Q?LYbPFyo+YBlLipoDEr0wLRAZiXt+xmrx0NZy21R1tMzsaXXJatelEAPwe1VW?=
 =?us-ascii?Q?mEo93p230AF5PxmootXRrul+JJpo+ayTxF/g3PfkLs23feCULYZ4NicM3zS5?=
 =?us-ascii?Q?YO9HfNZEpHOtGDVOObTTLtlVOhtjUE0tlKUQLxOq1kijVJKkbBYDKgeF82iB?=
 =?us-ascii?Q?eCALZ/nIXq35Vc2J9fdO7+hPsUiBTly0vvNAVclOmSYdgxGtDdFlitsnvIop?=
 =?us-ascii?Q?mtG8twN+uV7KEmb80vE2+Wre/1/fLirNfc6Oyfp2BG+FjU9kkG1yHHdb2s+v?=
 =?us-ascii?Q?DSIyl6WBlhH3XvWnxuYmugfN6PsIHAw1uggCepJXhxedK8hv09WG2NRayd72?=
 =?us-ascii?Q?cYr6IYUTtqXEiJub0CQoeRXSkugBvHQDCHgBc6naqM8tmSyZV79jetoFHB2U?=
 =?us-ascii?Q?w5EOq+Ga9QWwzcVgSmscks6uNzIEPZMIKvbPUWyg9HnwqoEqyxzkKGqoq7TL?=
 =?us-ascii?Q?RLhDDumCQD1ul3ujgO+m3cjmseNY2UzhP5IAkBJ9MCkAX63tVegcKkCHhOC6?=
 =?us-ascii?Q?Vynt2ambWoDBQCJ8hF6+3BXTCKQz3qPgvhCUKzjoRR/QKhHFrTlZ+lnEeNTp?=
 =?us-ascii?Q?qEIVU5XVtw2h/OKxDeTPEtEPs2ADp4L6MnRF/omsN9WA3/mszgGinsK/Qdgg?=
 =?us-ascii?Q?LAMnkkRii4x5AHi0mkDyomFTrndvl3qyu6Hq63D1Q0buFDbKIyx0Aw2dqTox?=
 =?us-ascii?Q?EKjZbMgL6JHRaJAOyoJE70OHv4XSEV4Cnlic9m9NBbcL0hnh4KBDhxQaWEE9?=
 =?us-ascii?Q?sg8oojsOsyFwNkByr4L7axR/rlTLYWNZ43sT90Ve+k+U/7xqLYRo9oi1GOra?=
 =?us-ascii?Q?Hyts3nlZiQ7P8qeZ+j8jm2WAFNr5f9o6fFcQxAao8hVWIF5oABEFesaW7a3a?=
 =?us-ascii?Q?2n+VRuxT3VPaatuVxQOa3KfayspKw0qSDrT22WDS3rAWBHECuX+p4eyEFx7u?=
 =?us-ascii?Q?XA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ja7jeZOSxmegoN0lCPRo3/hC03Q7rcVjGLy7EZfiV8Wqs0nZyflNDhDYKWKy9aNz6fFDsx4vbF7Q2qGYJDJGH9toU6pZ5HzRUGWcl5w4y8+n71+d+DJkKurU/ymI9Cizoe/lt9fd25gu5KLb0NkSDG0ZLkO4zXKWr80bMePnBQf2MkTLkCHlqIZwWm8tE5JceLaMdRdcMvl4gybsCQC4Hm36hx26EAGYY6dpNljUf/6XgMRLNeJQ/6rmEbN+Z/ISL9rjYaAeiBY2qpI9QejcAfCWCEW/cclm3YRae7O/5MM0rFvTARyXb7wcha81dvFHmuBIWcITicITrUH2+VyGMn3ZuZLOzJmMZi4ItxNHXphTBePk6NAgHuff/CQd6iYleZKDkbMcfWo37gqU2pCc5ufXpe+gmYW9ne+QNpQMkLUBQP/NPhRtBaw6cpjVSkz+tnSoNxO5ni+/EDn3UQc/2salOzBObTXQA8/APzYlY+NjeVfxQqwbHev4pWPGQCluRM1NAlGxXEi8bA9OpforIvITxfR6HaDhBL9oaSQXZ8z50IHMlBGSBNZDsvXDvfSn6IFiUPaqE5iz8jaD9rv1ltbIF0qisYPE+hqBgh+DkH1mBHwZ8lcNYEF3FVInf/R9xywb4gQACMg2eKYtEmyLSi4BEBlQjdYR3OOO0O+AMVnmqF68CvJ00yTIfcF1/0sjD3c9cWaW/KIJQyGcUDJ9A5hyh9AYeFN8Tlzk0bSvOsW7UAi9XTXP66G+19aQF3wDgci5vK1jRsAr7aycNk/2t65SJNAx6dV3wqEEY2mCs+4xDeiaoj8IQ4lt0K52rLP9pUL2pNXz6PTCmIwMHwBjGTMGADKGLST4/y37XS2NRRJp51Z1LFl3tmR41ApOeYjd
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f9c2ed9-a26d-4669-68c7-08db5b0eb14f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 21:51:26.6830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BBdF6Sl8uGJYicZr8gzMJboWOjdFMy8bY3UbAQrb8db68LkNdUrFoju9Brl6fKNLzLsqqvUD9Zor1WZ1XLlbjWTWdBlQ6FtayUH22o80cmM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6678
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-22_16,2023-05-22_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=754 phishscore=0
 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305220185
X-Proofpoint-ORIG-GUID: sGE48ekHTT47J6u2uzA9qC-3vG05VCSY
X-Proofpoint-GUID: sGE48ekHTT47J6u2uzA9qC-3vG05VCSY
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Chao,

> SCSI maintainers,
>
> Any comments on this patch?

I have an updated version of your original multi-segment UNMAP support
queued in a discard topic branch that I intend to submit shortly.
Without the UFS HPB bits.

-- 
Martin K. Petersen	Oracle Linux Engineering