Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iad51458e:Fastmail
Date:   Mon, 22 May 2023 15:05:25 -0700
From:   Boqun Feng <boqun.feng@gmail.com>
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Brian Foster <bfoster@redhat.com>,
        Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v2] locking: SIX locks (shared/intent/exclusive)
Message-ID: <ZGvnJZYQfAmgdsqr@boqun-archlinux>
References: <20230522171314.1953699-1-kent.overstreet@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230522171314.1953699-1-kent.overstreet@linux.dev>
Precedence: bulk

On Mon, May 22, 2023 at 01:13:14PM -0400, Kent Overstreet wrote:
[...]
> +/*
> + * bits 0-26		reader count
> + * bits 26-27		write_locking (a thread is trying to get a write lock,
> + *			but does not have one yet)
> + * bits 27-28		held for intent
> + * bits 28-29		nospin - optimistic spinning has timed out

Still reading to understand the design (and try to find where are the
first five locks ;-)), but this comment seems to be wrong, because..

> + * bits 29-30		has read waiters
> + * bits 30-31		has intent waiters
> + * bits 31-32		has write waiters
> + */
> +
> +#define SIX_LOCK_HELD_read_OFFSET	0
> +#define SIX_LOCK_HELD_read		~(~0U << 26)
> +#define SIX_LOCK_HELD_intent		(1U << 26)
> +#define SIX_LOCK_HELD_write		(1U << 27)
> +#define SIX_LOCK_WAITING_read		(1U << (28 + SIX_LOCK_read))
> +#define SIX_LOCK_WAITING_intent		(1U << (28 + SIX_LOCK_intent))
> +#define SIX_LOCK_WAITING_write		(1U << (28 + SIX_LOCK_write))
> +#define SIX_LOCK_NOSPIN			(1U << 31)

^ NOSPIN is the 31st bit.

Regards,
Boqun