Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9804c558-124d-aca4-c534-158c0457b7bf@quicinc.com>
Date:   Mon, 22 May 2023 15:35:13 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] drm/msm/dp: enable HDP plugin/unplugged interrupts at
 hpd_enable/disable
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>
CC:     <robdclark@gmail.com>, <sean@poorly.run>, <swboyd@chromium.org>,
        <dianders@chromium.org>, <vkoul@kernel.org>, <daniel@ffwll.ch>,
        <airlied@gmail.com>, <agross@kernel.org>,
        <marijn.suijten@somainline.org>, <quic_abhinavk@quicinc.com>,
        <quic_jesszhan@quicinc.com>, <quic_sbillaka@quicinc.com>,
        <freedreno@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1684791092-1822-1-git-send-email-quic_khsieh@quicinc.com>
 <20230522220555.7ood44kavjzzg3lv@ripper>
 <c4d6e019-1582-c94f-d56d-271c420d72ea@linaro.org>
Content-Language: en-US
From:   Kuogee Hsieh <quic_khsieh@quicinc.com>
In-Reply-To: <c4d6e019-1582-c94f-d56d-271c420d72ea@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


>>>   -static void dp_display_config_hpd(struct dp_display_private *dp)
>>> -{
>>> -
>>> -    dp_display_host_init(dp);
>>> -    dp_catalog_ctrl_hpd_config(dp->catalog);
>>> -
>>> -    /* Enable plug and unplug interrupts only if requested */
>>> -    if (dp->dp_display.internal_hpd)
>>> -        dp_catalog_hpd_config_intr(dp->catalog,
>>> -                DP_DP_HPD_PLUG_INT_MASK |
>>> -                DP_DP_HPD_UNPLUG_INT_MASK,
>>> -                true);
>>> -
>>> -    /* Enable interrupt first time
>>> -     * we are leaving dp clocks on during disconnect
>>> -     * and never disable interrupt
>>> -     */
>>> -    enable_irq(dp->irq);
>>
>> ...we need dp->irq enabled for handling the other interrupts, otherwise
>> e.g. AUX transfers will time out.
>>
>> I added enable_irq(dp_priv->irq) to the EV_HPD_INIT_SETUP case below,
>> just for testing, and with that the patch seems to be working fine.
>>
>>
>> Is there any reason why we need to delay its enablement to after we
>> unmask the HPD interrupts?

my though is aux transaction should happen after plugin interrupt detected.

can you please let me know what did you do to trigger aux timeout?

It does not happen on me at my test.

>
> As I wrote, I'd probably prefer to see enable_irq() and disable_irq() 
> calls gone.

ok, i will move enable_irq() out of here.


>>
>> Regards,
>> Bjorn
>>
>