Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230515143023.801167-1-robdclark@gmail.com> <da1f7aa1-f560-31f4-6114-e400f35d325b@linaro.org>
In-Reply-To: <da1f7aa1-f560-31f4-6114-e400f35d325b@linaro.org>
From:   Dave Airlie <airlied@gmail.com>
Date:   Tue, 23 May 2023 10:17:17 +1000
Message-ID: <CAPM=9tyc+N0i+vXkZ-8Mf6kBN5BJHeL=tvbnp=LKCW6T5gPGfg@mail.gmail.com>
Subject: Re: [PATCH v4 0/9] drm: fdinfo memory stats
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Akhil P Oommen <quic_akhilpo@quicinc.com>,
        Lijo Lazar <lijo.lazar@amd.com>,
        open list <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Michel_D=C3=A4nzer?= <mdaenzer@redhat.com>,
        YiPeng Chai <YiPeng.Chai@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Rob Clark <robdclark@chromium.org>,
        Guchun Chen <guchun.chen@amd.com>,
        Shashank Sharma <shashank.sharma@amd.com>,
        "open list:RADEON and AMDGPU DRM DRIVERS" 
        <amd-gfx@lists.freedesktop.org>,
        Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>,
        "open list:DRM DRIVER FOR MSM ADRENO GPU" 
        <linux-arm-msm@vger.kernel.org>, Sean Paul <sean@poorly.run>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Elliot Berman <quic_eberman@quicinc.com>,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Maximilian Luz <luzmaximilian@gmail.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Peter Maucher <bellosilicio@gmail.com>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Christopher Healy <healych@amazon.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        freedreno@lists.freedesktop.org,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 21 May 2023 at 10:03, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 15/05/2023 17:30, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Similar motivation to other similar recent attempt[1].  But with an
> > attempt to have some shared code for this.  As well as documentation.
> >
> > It is probably a bit UMA-centric, I guess devices with VRAM might want
> > some placement stats as well.  But this seems like a reasonable start.
> >
> > Basic gputop support: https://patchwork.freedesktop.org/series/116236/
> > And already nvtop support: https://github.com/Syllo/nvtop/pull/204
> >
> > I've combined the separate series to add comm/cmdline override onto
> > the end of this, simply out of convenience (they would otherwise
> > conflict in a bunch of places).
> >
> > v2: Extend things to allow for multiple regions other than just system
> >      "memory", make drm_show_memory_stats() a helper so that, drivers
> >      can use it or not based on their needs (but in either case, re-
> >      use drm_print_memory_stats()
> > v3: Docs fixes
> > v4: use u64 for drm_memory_stats, small docs update and collected
> >      Tvrtko's a-b
> >
> > [1] https://patchwork.freedesktop.org/series/112397/
> >
> > Rob Clark (9):
> >    drm/docs: Fix usage stats typos
> >    drm: Add common fdinfo helper
> >    drm/msm: Switch to fdinfo helper
> >    drm/amdgpu: Switch to fdinfo helper
> >    drm: Add fdinfo memory stats
> >    drm/msm: Add memory stats to fdinfo
> >    drm/doc: Relax fdinfo string constraints
> >    drm/fdinfo: Add comm/cmdline override fields
> >    drm/msm: Wire up comm/cmdline override for fdinfo
> >
> >   Documentation/gpu/drm-usage-stats.rst      | 101 ++++++++++----
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c    |   3 +-
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c |  16 +--
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h |   2 +-
> >   drivers/gpu/drm/drm_file.c                 | 147 +++++++++++++++++++++
> >   drivers/gpu/drm/msm/adreno/adreno_gpu.c    |  24 +++-
> >   drivers/gpu/drm/msm/msm_drv.c              |  15 ++-
> >   drivers/gpu/drm/msm/msm_gem.c              |  15 +++
> >   drivers/gpu/drm/msm/msm_gpu.c              |   2 -
> >   drivers/gpu/drm/msm/msm_gpu.h              |  10 ++
> >   include/drm/drm_drv.h                      |   7 +
> >   include/drm/drm_file.h                     |  51 +++++++
> >   include/drm/drm_gem.h                      |  32 +++++
> >   13 files changed, 378 insertions(+), 47 deletions(-)
>
> What is the expected merge plan for this series? msm-next? drm-misc?

I'm fine with this going via drm-misc,

Acked-by: Dave Airlie <airlied@redhat.com> if that is the plan.

Dave.