Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230522063725.284686-1-apopple@nvidia.com>
 <ZGuFu0VwRfZszABB@arm.com>
User-agent: mu4e 1.8.10; emacs 28.2
From:   Alistair Popple <apopple@nvidia.com>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, robin.murphy@arm.com,
        will@kernel.org, nicolinc@nvidia.com,
        linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
        kvmarm@lists.cs.columbia.edu, jgg@nvidia.com,
        John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH] mmu_notifiers: Notify on pte permission upgrades
Date:   Tue, 23 May 2023 09:52:55 +1000
In-reply-to: <ZGuFu0VwRfZszABB@arm.com>
Message-ID: <871qj7apgp.fsf@nvidia.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OS4EIRLciq5J5mZQbFaUcJuhyRB0F+pPCAr+LQlgOAUvlNqJtAoiV84SzQ4H?=
 =?us-ascii?Q?0W9nA1d8ZZZ/3K1Lw5i2uVIeCHqoEnZcOHfte4R934cXqSY7qGhwjjoVin+1?=
 =?us-ascii?Q?M5JibU+rkweB6vRuIdFT1+JuWNSWXkq5LpzLvM1QO9WpqnRHnztPcTl2KW6d?=
 =?us-ascii?Q?TvwMrMinXdOk8ojewlnm9Zrwm+ZUtd4uusdatYEFvSDVuHAHP77rDZJ6+dyO?=
 =?us-ascii?Q?fr5yV7LgYnKdHTtwMIWkHYDaX79hNXjuk0bSRfBW91osjo/628jDj/+w85k5?=
 =?us-ascii?Q?pZAU6a0XR5BBpcXzJAKI/y4H5JdKWh5fqHvMEQ2FDv7MVTOQ0J9ShLGtGbFm?=
 =?us-ascii?Q?kd3UxyigS6q4MsmWb4DyMhwa2UuXDcsD6uaaqFOvlIZcAEf0BWms2FaelINx?=
 =?us-ascii?Q?1ilLz5h+cNwXDL0vMzuHJcl0nqjAqcShEQxVxegEm1DhLJoG11ZQFaBXchhU?=
 =?us-ascii?Q?zQELpHG+n3lnUA5oyGP/HsyAxJRFYmUNATlNstB8ozQSB/hIDNtkp6lXpA9R?=
 =?us-ascii?Q?RDO+4uOXMWOWFCyZY++3/dIS8ivo9opBDZ0upBtddlWwyHPJ7Wz6WqjbI/1t?=
 =?us-ascii?Q?fONZL+PUYZVbXur3mM1gbF0oglOTstqWoMk34mxuT7GVdS96sWRIghdT8bvo?=
 =?us-ascii?Q?mQhxrzK5GA0WzZM3tAXaYcfT5aHqemfYqMAEkUQo0GSOrSfxcxqseL57AAQv?=
 =?us-ascii?Q?S2pc8d49YOy5pdHNMLvOO0X6rdKsqnDE0b8ziSqJdVBMRRTjUOi2KPmxxupO?=
 =?us-ascii?Q?9uIKSP3LDCr7ZIw0eG74UugMgcrr7qFpJn9FTQpg3i+PR4YR8wMIgARJ7Jmo?=
 =?us-ascii?Q?qrmlcd608Dw+2Qm7jtzOXYdwTGpxXva9QB1hj/y6VUsVtxBx8rqoWZl0m4LU?=
 =?us-ascii?Q?soBq0fHL9tJE7blgDGrHwNDU9t8FMLUCzj6X31SGvrkUtDC9pcRsNoo/iAoa?=
 =?us-ascii?Q?grlUlExpKZF+tI0fwA4Zp+mblUBxP78AX+K/kYD2AK7a5QJ4B7ZB+xtg2uOa?=
 =?us-ascii?Q?w9RXcl4L67GNbfQSGZyWVD2PkWxFTldf9xMhmu9u8UZ/InsunNMcy8vY1PNE?=
 =?us-ascii?Q?C0SUpg3FCnoMHj2biopCq7grU/2eZKFM8uhOgS+RRDnbcJaXh7F0F7MOwvzB?=
 =?us-ascii?Q?yqBnENtLSKsT5+QKrEQJHfZEpBTIayf76S6Hg2y5+0J0x1YqCGEZ98ajtfIh?=
 =?us-ascii?Q?TU4iu5xAd8d9IafRxGIHAA00V4c6QRmnStxV9/m11kaSsLGINB5N7I/qvxN5?=
 =?us-ascii?Q?mqP8hF1/q5d08PAwMylyUQxCE9ws8ipSHAao4XdhPFq/uJvflQDb25XTaajm?=
 =?us-ascii?Q?OLEUOAEOFa8/db+t1BQW50OBN35cyalrCveDs2Oya+Vpq3Znc1RBvhEdhgPF?=
 =?us-ascii?Q?AvfyVDmlNVlwJL1YhVhKjmu/yHvVm9DZcB7MBJcxsuP26u0LNwSP3ZpIISO5?=
 =?us-ascii?Q?OhJXrjByqoaj3F6aqxDIPQ8HQAAqIT4Jmbe212W4Z+jiJGtkBttteTNmajDa?=
 =?us-ascii?Q?a2sC92ctTWWb5rw2K5SYyjOaJqT14gpSCllRLvq4KwtaBvOGaQcx0Lpeh3Um?=
 =?us-ascii?Q?R6jmAovWwGRKNoYzW0EyPlcD4PkxWfdEcuQrq0FQ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a146b54-823d-46e3-a57c-08db5b206b33
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 23:58:20.0251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 10tYqOu8apmS8QW1IgqFW62Tg1P1Ah8sPUiY2HzypjslRMKjnIncV7ziDn9ITB4Eo34typB5uIzJCwdIiQ4DlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5376
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Catalin Marinas <catalin.marinas@arm.com> writes:

> On Mon, May 22, 2023 at 04:37:25PM +1000, Alistair Popple wrote:
>> diff --git a/mm/memory.c b/mm/memory.c
>> index f526b9152bef..0ac78c6a232c 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -2098,6 +2098,7 @@ static vm_fault_t insert_pfn(struct vm_area_struct *vma, unsigned long addr,
>>  	struct mm_struct *mm = vma->vm_mm;
>>  	pte_t *pte, entry;
>>  	spinlock_t *ptl;
>> +	bool changed = false;
>>  
>>  	pte = get_locked_pte(mm, addr, &ptl);
>>  	if (!pte)
>> @@ -2120,8 +2121,10 @@ static vm_fault_t insert_pfn(struct vm_area_struct *vma, unsigned long addr,
>>  			}
>>  			entry = pte_mkyoung(*pte);
>>  			entry = maybe_mkwrite(pte_mkdirty(entry), vma);
>> -			if (ptep_set_access_flags(vma, addr, pte, entry, 1))
>> +			if (ptep_set_access_flags(vma, addr, pte, entry, 1)) {
>>  				update_mmu_cache(vma, addr, pte);
>> +				changed = true;
>> +			}
>>  		}
>>  		goto out_unlock;
>>  	}
>
> I haven't checked all the corner cases but can we not have a
> ptep_set_access_flags_notify() that handles this (and the huge
> equivalent)? It matches the other API like ptep_clear_flush_notify().

Good suggestion, thanks! I can make the implementations architecture
specific too which helps with filtering on platforms that don't need
it. I had assumed the invalidate_range() callbacks could sleep and
therefore couldn't be called under PTL. However
ptep_clear_flush_notify() already calls invalidate_range() under PTL, so
we already assume drivers don't sleep in the invalidate_range()
callbacks.