Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 09:18:23 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, <paulmck@kernel.org>,
        <rui.zhang@intel.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <bin.gao@intel.com>
Subject: Re: [PATCH RFC] x86/tsc: Make recalibration default on for
 TSC_KNOWN_FREQ cases
Message-ID: <ZGwUXzGcMgbcZVnf@feng-clx>
References: <20230522033018.1276836-1-feng.tang@intel.com>
 <87h6s4ye9b.ffs@tglx>
 <ZGssENXFKmOk/zL7@feng-clx>
 <87zg5wwppa.ffs@tglx>
 <ZGtnUQJy+1Nrazhy@feng-clx>
 <87pm6swi7z.ffs@tglx>
 <ZGuIL6tyzzZP3kyR@feng-clx>
 <20230522161158.GA3330346@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230522161158.GA3330346@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5jkAFBYUHSNC7JGoYM0XDuP6O10jvt11p8mps5TsPyxwaUOvNE4aWt9j37Ey?=
 =?us-ascii?Q?H3kJNw0/JWHfQintZA8WGu9OhGp86IwCfEFIJgcvMab3mMxx3odvFJsRll7w?=
 =?us-ascii?Q?98FcuS9D57v1QvGTHUI/5tWu2bfCnjWkB5mq09V2lEFIun6fZ3IG5xb6NLFl?=
 =?us-ascii?Q?AXEnZDUDFOo3dSgtEuRNkD0roKWwPaAQIo0R+JUAdWxtbtpZCxAQajSbZjWl?=
 =?us-ascii?Q?xR7tH2SOFfYwEAJbA/3XgayQbj8DYVMmFKvvWShFRjYfD1hoAyieiSJ+XZRh?=
 =?us-ascii?Q?HFm+4pftDJY0dsQKJrbt9JCS72X+mIW4qAkFa9O9jNVlia0eGNSkbRZFFS0i?=
 =?us-ascii?Q?pXtpxi0NajcjQk3Msvn3F8hXy9Owsbol7jp3Zfz3fHm+bv4ozEFRQ9nph+uX?=
 =?us-ascii?Q?OkSsY8RjbXnhjyY6urDd176WQGs7zte5XoDCMCAH2qVz4STkmT3zbmYa+URR?=
 =?us-ascii?Q?gn86/XiqRVa94F2+FFeqsLotCSii762STr6u4b8XGHkY2I3reTPQUmX2pfRw?=
 =?us-ascii?Q?pu9/GXtbbx4924Wtg+VGyRwpHgoTyQO2u0Q0BODUV1bTwlQz1LIW2yqFQXwW?=
 =?us-ascii?Q?o45Uid6SlHOZn2esN03UgLChFPKyKq6XpNbCiJDI/F5R8M0+ZS+PDctojCYw?=
 =?us-ascii?Q?LKX1GEwpp1DzIeYlOhvVKtjQYqcAw8z+kIxAJVdCjwOEtwiMnf6SiJuoIKXn?=
 =?us-ascii?Q?qmUj4NpDPK1xNK2OVnyjaSj7FYuDbhok0Q6T+rtq8SckC6MN1eAyDQ4kJSgw?=
 =?us-ascii?Q?RhTgem+BPrxZ5C5P0JN954sOP5glcYYddS4saeOCbGAsdYzfYbZRSeJ5pJEz?=
 =?us-ascii?Q?0K6Q2sGvmxlpHwSqOMCIgOJ2ELABahs4pxx7Y4bx1WSqSmQKCnfd1SXlfMDh?=
 =?us-ascii?Q?fbzpLuoo8KNcx6xk3sw7O2S06DgCNUnbXJSCfMdF1K9SJzpAeztEhtM261eP?=
 =?us-ascii?Q?WTN3fzSuJuzx1UN0Wc+YoKt7LTirSXPMe2mKM6Cbq1lBovGfd+JhUPBZQq7G?=
 =?us-ascii?Q?AkhOgpqNWHvk8prYPsMxDL+/Dp6+ls0SK8Frj/wOwYOk8OW321yV/pw6ILs+?=
 =?us-ascii?Q?BVCcOtqav/G7inwCzldd5EXKrF/fl6cgCJxfsynWIp7G4/GUHwVbGPzsfMtQ?=
 =?us-ascii?Q?mLcMKmZJ3k0UlYrZiY1gZSsOULWx/wsARcEK57IoIRws+LN9kQZ5il1BNNwk?=
 =?us-ascii?Q?+iC4+TEBUteGNTfRxIoJeMQZfl8Wt7IyqQIC/ihR0xB9irUsRVEJukL8e+zi?=
 =?us-ascii?Q?hBneeJldlrcAwA9a5V51iw4oxDZOTZ1CFlhxxaH08fHWal2Vd2Vjqg5Lqah0?=
 =?us-ascii?Q?A48ySjfesj2jMsi3y2cPbWASO6giPrRjR6Kp6JSQz0NGHo0Os33LOjhwNgJ/?=
 =?us-ascii?Q?u5sCBD5IgaIM3uWYjTvZWBg/s1MWzqYUQREcnPHgLVL5WdaOB9+6zu1ipeYd?=
 =?us-ascii?Q?9eN9YIxCh6Dk8eJrdktwckOXSdilKiOBs8x1y9LHI/GV6RD8/8ddDLqkiY3n?=
 =?us-ascii?Q?6qDqu5Td2z0chtiC/xo7wWCyOE5ylqO9AmnFrp8l/CyTZld1R9SD3+FfAxdD?=
 =?us-ascii?Q?5GDb1Y538zT/cMLhnsaIZt4CCNZIQggTv6kjRGA0?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f4ba3ce9-1c5c-4b37-d18e-08db5b2c8ed2
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 01:25:14.1281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FBjXjzDYKBnlyHF33In4ftHJ1wfhpEmA2YLj/ESziuY5ihpkru/P4M9BeN/pRfdQJLshTO95SyFWR7Wzk3LR1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6300
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 22, 2023 at 06:11:58PM +0200, Peter Zijlstra wrote:
> On Mon, May 22, 2023 at 11:20:15PM +0800, Feng Tang wrote:
> 
> > And I don't understand the commit log: "On Intel GOLDMONT Atom SoC
> > TSC is the only reliable clocksource. We mark TSC reliable to avoid
> > watchdog on it."
> > 
> > Clearly the Denventon I found today has both HPET and ACPI_PM timer:
> > 
> >   [root@dnv0 ~]# grep .  /sys/devices/system/clocksource/clocksource0/*
> >   /sys/devices/system/clocksource/clocksource0/available_clocksource:tsc hpet acpi_pm
> >   /sys/devices/system/clocksource/clocksource0/current_clocksource:tsc
> >   
> > The lscpu info is:
> >   
> >   Architecture:                    x86_64
> >   CPU op-mode(s):                  32-bit, 64-bit
> >   Address sizes:                   39 bits physical, 48 bits virtual
> >   Byte Order:                      Little Endian
> >   CPU(s):                          12
> >   On-line CPU(s) list:             0-11
> >   Vendor ID:                       GenuineIntel
> >   BIOS Vendor ID:                  Intel(R) Corporation
> >   Model name:                      Intel(R) Atom(TM) CPU C3850 @ 2.10GHz
> >   BIOS Model name:                 Intel(R) Atom(TM) CPU C3850 @ 2.10GHz  CPU @ 2.1GHz
> >   BIOS CPU family:                 43
> >   CPU family:                      6
> >   Model:                           95
> >   Thread(s) per core:              1
> >   Core(s) per socket:              12
> >   Socket(s):                       1
> >   Stepping:                        1
> > 
> > Maybe this cpu model (0x5F) has been used by some type of platforms
> > which has met the false alarm watchdog issue.
> 
> It has them; but they are not *reliable*.
 
Yes, that's possible. I tried to CC the author Bin in case he can
provide more background or information for his statement, but his
email address is unreachable now.

Thanks,
Feng