Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
MIME-Version: 1.0
Subject: Re: [PATCH] kernfs: fix missing kernfs_idr_lock to remove an ID from
 the IDR
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <ZGu9v3OA0wkhff7g@slm.duckdns.org>
Date:   Tue, 23 May 2023 10:17:04 +0800
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6D4D62D0-FD5D-4065-8D7F-C6E220186DE6@linux.dev>
References: <20230516034536.25548-1-songmuchun@bytedance.com>
 <ZGu9v3OA0wkhff7g@slm.duckdns.org>
To:     Tejun Heo <tj@kernel.org>
Precedence: bulk


> On May 23, 2023, at 03:08, Tejun Heo <tj@kernel.org> wrote:
>=20
> On Tue, May 16, 2023 at 11:45:36AM +0800, Muchun Song wrote:
>> @@ -655,7 +660,7 @@ static struct kernfs_node =
*__kernfs_new_node(struct kernfs_root *root,
>> return kn;
>>=20
>>  err_out3:
>> - idr_remove(&root->ino_idr, (u32)kernfs_ino(kn));
>> + kernfs_idr_remove(root, kn);
>=20
> Good catch but I'd just open code the locking here.

OK. I'll send v2.

Thanks.

>=20
> Thanks.
>=20
> --=20
> tejun