Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3738840rwd; Mon, 22 May 2023 19:58:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6pbHPpy6VsU/tResWGlI55y6Nq0DlHREeWT+dWMwzDBdkM7U0EM2fVpov1PhsXpW2n4uqp X-Received: by 2002:a17:903:441:b0:1ac:4735:45d7 with SMTP id iw1-20020a170903044100b001ac473545d7mr11588154plb.6.1684810718307; Mon, 22 May 2023 19:58:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684810718; cv=none; d=google.com; s=arc-20160816; b=vaTIEtiLlVWGvoDALDF+rMMTc7aW5pZOXJFZA5w30pDVtDLx7grcOdj1gzf0l6AcPY Uof/7v2nwSRmCmC7BQr+fM1JqXijS9s74uI70WCyKoIU5R3uvr0TJXrmAPyvpnb6S1s6 4SwWjerQH2INgclnVTHZ9uPXHXyb/p7913vJoT4zz0+gXm2VZQTromq78kkz1mQ01e5T 4e1Pg3m6d2wU6eQGd2yaaVQfq2YYinDiPrSgG4hnaBnZP/ALJEfZauV7/6NN36KuMg2r Y1S2WoEAmaZwUEa357Mqu6duf7tN/zIM2SQxM8y+QUAHICPWjXFXr7gyuD/W5PlsSKEl o6kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=GwvpwVxtF6IMtlvqhueSz34lEXXjDUBtDVPr+ojaxvw=; b=xK5f9DnbLn/3cNwkUW970y4yY3Xt3jwt0WO0IwD9Ny3cPGRFEUSBVugE0JWYC+ZTVY kJlohtRxJyEZkUvQn5FirhsqAYUotOencErsG/DTSof+cCaGzE7wvU0Rt0m3OqoUISZA 4OoygvfVm/Sp6D99M786GqwT1Sn6GgjFEgAUzNnd2U/tapQezMAzswo9rZqP+6vsAiiV DbfhmhJVln3cPRCIJ/5lpkJrs8RtQbcDysyCJ7giOfeA0D+e8pAgv7EAEzw7QMNhJeZo U/gzrs/owqHH9aNjV6yvCpTLqoT3YHxiqSD28K3uxZJc0T3N91gq+hj4/pRlVabpqmdx 7bGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=felV7hbd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a170902f55100b001ae453d07a3si75561plf.539.2023.05.22.19.58.23; Mon, 22 May 2023 19:58:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=felV7hbd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234575AbjEWClT (ORCPT + 99 others); Mon, 22 May 2023 22:41:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230402AbjEWClR (ORCPT ); Mon, 22 May 2023 22:41:17 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14AE9CD for ; Mon, 22 May 2023 19:41:17 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-64d426e63baso3783199b3a.0 for ; Mon, 22 May 2023 19:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684809676; x=1687401676; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=GwvpwVxtF6IMtlvqhueSz34lEXXjDUBtDVPr+ojaxvw=; b=felV7hbd+ikFWUKwfJ5VzT38dKW2UXWH7WaC9TARuIDw79cmTmbndUO4frD8gYZSSN DKjpxk9W4pYfnJmsbiZLEJjfxuu6rwPjjtRegShY6rnxf3Cqlhn6e34dwJoKoTMijjZI b05Ce+xMb0KWJV/79iiGWLbH1uLh4Xy00HWIIY0DLvK5lpQrJCLIpzl1yZpGs7TZ9K6q bEyXxbM4wOMgJX90chbCq/EnPGRZ6IJQd+ZpSO2Mi7nW0qOrNHdbXx2QbN6l3D7MFzU9 IFlT8rvGS6CdNvns6a3uNP9CSxYd+/XQuKgPSGyCa316S4RRKq2uZJdmc49KZDNwUi87 yc/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684809676; x=1687401676; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GwvpwVxtF6IMtlvqhueSz34lEXXjDUBtDVPr+ojaxvw=; b=MhMHAYGm2743Ty3tB/pZeAm06b+dnskJHrUetAWPsRRurRb0CveYb5fy0s3YNemd8w RroZQf4iNu4XBZwu/R7KByEX+gfbYKwamaEqu8COnrq9xn/oicQHK6V/RvDFnsA/Pb8J LJhpcnEN4bHXmR7gp2NovYQEAPwEOmynkkTjlaaYYYx0XtfRDOJ37hWsrOEO3CkDEkFP IisMhCsJ8oHeFW4/rzpsU2MTfsKe7H9HvT4Dk3e38htYJRbzLD5k00mYR6MHwUVACIdP OKoiWa2xPQDcg/ItYzeuJPNaLRFOpJ+dHbzSYdRdX+H+zHvz78RGNdQX6IqrOXvagFhP a9KQ== X-Gm-Message-State: AC+VfDwSsBae3PqhfpKDa7oVZUniGsY3W8YGh03cyD4rqnPGi1uaNyfb +Sg12CfQV+/EewPkQewC9sY= X-Received: by 2002:a05:6a00:1486:b0:641:3bf8:6514 with SMTP id v6-20020a056a00148600b006413bf86514mr18087979pfu.10.1684809676152; Mon, 22 May 2023 19:41:16 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:39c]) by smtp.gmail.com with ESMTPSA id p18-20020aa78612000000b0063b7c42a070sm4734986pfn.68.2023.05.22.19.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 19:41:15 -0700 (PDT) Sender: Tejun Heo Date: Mon, 22 May 2023 16:41:14 -1000 From: Tejun Heo To: Muchun Song Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev Subject: Re: [PATCH v2] kernfs: fix missing kernfs_idr_lock to remove an ID from the IDR Message-ID: References: <20230523024017.24851-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523024017.24851-1-songmuchun@bytedance.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023 at 10:40:17AM +0800, Muchun Song wrote: > The root->ino_idr is supposed to be protected by kernfs_idr_lock, fix > it. > > Fixes: 488dee96bb62 ("kernfs: allow creating kernfs objects with arbitrary uid/gid") > Signed-off-by: Muchun Song Acked-by: Tejun Heo Thanks. -- tejun