Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 20:33:59 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Verma, Vishal L" <vishal.l.verma@intel.com>,
        "Schofield, Alison" <alison.schofield@intel.com>
CC:     "Jiang, Dave" <dave.jiang@intel.com>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Weight, Russell H" <russell.h.weight@intel.com>,
        "bwidawsk@kernel.org" <bwidawsk@kernel.org>,
        "dave@stgolabs.net" <dave@stgolabs.net>,
        "Weiny, Ira" <ira.weiny@intel.com>
Subject: Re: [PATCH 3/4] cxl: add a firmware update mechanism using the sysfs
 firmware loader
Message-ID: <646c34278f161_33fb3294ce@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230421-vv-fw_update-v1-0-22468747d72f@intel.com>
 <20230421-vv-fw_update-v1-3-22468747d72f@intel.com>
 <ZGblx0pCpJPvCS7M@aschofie-mobl2>
 <2bf4a3a8f34e71aa2b2be2b88fe22f58004eb699.camel@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2bf4a3a8f34e71aa2b2be2b88fe22f58004eb699.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?ymDGL/qOrFRP+ljQZhUtgguFxRUxMzBap8bRxf8OmWPgLM1L2guOoYH1nz?=
 =?iso-8859-1?Q?U0gVlQ9QMK/k7YjQsxcUzQMPnD2FUWYDnLojVLK9tWPBjABSggoWmJ3Z29?=
 =?iso-8859-1?Q?sAPMFCKT68lvWBdWIFi8/iGtwmhlSyQkGM5s2j7cfOTnWdruG9Sbd2xymK?=
 =?iso-8859-1?Q?2IbnYgTn+KKK9UiLhm9bv8y9LdPZrwpi1crnRa9J760YA9W9ISWQo+p5TY?=
 =?iso-8859-1?Q?Yc31RiC9G6Lvbe/RH6oJGtfezE276Og3cptt7JQl8WQhX/UqdQYi5Eq+vQ?=
 =?iso-8859-1?Q?zEiR8oNv13sRUBPjFP5J834Zamwz/F46pf+45La44WyFCfSCFBLMdQ0tYS?=
 =?iso-8859-1?Q?w4Oef5B/y5TlyGUE5EQtsBlcgQDNHB2kaBARW+EWl3uPiWgGNgHK+/4xVM?=
 =?iso-8859-1?Q?NfLYXn7rIlvAwi4T1I1NtEOoQju6IR/cLxwGGCK9ijZrOLp9a6IqIoWmUn?=
 =?iso-8859-1?Q?hc/GFL5ubIcKtibJH7JxUScHpt1mKCJNAShCEv6QYVgJGTFGJhXCQdjF4v?=
 =?iso-8859-1?Q?erJqKl9a87ewFsQugPbhz0+jSsbDfaISwunzjIAdj1KEJMmGnkkCv/OhmM?=
 =?iso-8859-1?Q?sixWtsWBuaoJ1qaZ/9q9VUxq9zOqt+RelQU1ZPlXMXtPEvsh9n6zeFx+mN?=
 =?iso-8859-1?Q?RmmXyvHorVYmafRwUtGcVThnJSBkbp7emVqYjDquBafb/0DTBfXIJo+oo0?=
 =?iso-8859-1?Q?AK/AxtdkfFJ2KISoXT4VPj2pETHZAmc72/89ejRcmYglbh5fctxzhvU0yY?=
 =?iso-8859-1?Q?HTl4/mORovi/fdzTlRjYs2XECJY1Z6Ql875Hlg3QJJG16JN6pwrtOv1aQr?=
 =?iso-8859-1?Q?YAMExnIyDJd0kk847LCnFKqonDYguEn7S6MacegxFU0tqBwq6hLBjEtI1m?=
 =?iso-8859-1?Q?2nJugsulS+srR49kFYQaJxSwCOOVmr9JXjyIzbgU5XW95sd704bBpnWVrQ?=
 =?iso-8859-1?Q?nmSR5X0bvDuqu1ts9ru+WrlkdniQgb9XVybOuO0wlvH/3TmlGi66Id58CF?=
 =?iso-8859-1?Q?DpdM5ydH2+WK/ecDIeG/Wt5o0+kh9pbhWgcYNk+fw7TiMF5VLmMRljzd6/?=
 =?iso-8859-1?Q?fbo8aZGPR6XNNBAVKrOCPTnUlvw//ZZ/R2Ioxh21/apESyEnxV2TABqkw5?=
 =?iso-8859-1?Q?VsuxTgKDC+0NC1bM3aqopIRDlQxgMzge5cdYyP2Dp8/CyGq36zHj09i/D1?=
 =?iso-8859-1?Q?hvcaF6RKngzABgdwG2Hfs4i+LkIjEAQU+JQQwYzDQXR4z6VgKmHGORGASU?=
 =?iso-8859-1?Q?AS9D3migpT4xY6vU5Hw9IyOZ7qoD3liKemjOpBM2V0jVwVIjHY5pZL+9V2?=
 =?iso-8859-1?Q?A7l7AZh+VYZw36x/bOTQHtaNFOHRAXXKKCfOmrHi+rOHWntBZQ/jhNhvzj?=
 =?iso-8859-1?Q?SmnST5TXwFij3LTX8nkn00jTtR6ux4nvxSbIv8YzDmhexJ1yUY+/BcDxmv?=
 =?iso-8859-1?Q?mGk0hjPDS6PDv56MuwVelAT8CT2Zo/h6WNNXybu8ceXD9GG2c9Co5jU6Ha?=
 =?iso-8859-1?Q?2gyT2FWqQ4tXRQ4cTg3zXAxF8bczGoGMOyoupMEAX9B34RODv9RWZt0/t1?=
 =?iso-8859-1?Q?Vst589MebU0XBuv3Fmh9VGMe69dD8S/nyjnTImwfvufgLY1cO3Fqp4UACG?=
 =?iso-8859-1?Q?/hOfouDCtMGBC0D+V7UACoozHQ+/lxaC64JheOpwKOZYNTSUORlkWZTg?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1c2b2ef-8ea7-4111-dc80-08db5b3e8d2c
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 03:34:02.0915
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lQWv27N6kHZHDDNbM8OqGBkyiwgBHDHw9OVJlVcFhzevR/kzNhXUXrD+P7DJ4t1h+09PTSYu3wIQybK4WFy1X0CS4Tl4nXy1mv6bc25iw5E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5883
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Verma, Vishal L wrote:
> On Thu, 2023-05-18 at 19:58 -0700, Alison Schofield wrote:
> > > 
> > > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> > > index 8c3302fc7738..0ecee5b558f4 100644
> > > --- a/drivers/cxl/cxlmem.h
> > > +++ b/drivers/cxl/cxlmem.h
> > 
> > snip
> > 
> > > + * Get Firmware Info
> > > + * CXL rev 3.0 section 8.2.9.3.1; Table 8-56
> > > + */
> > > +struct cxl_mbox_get_fw_info {
> > > +???????u8 num_slots;
> > > +???????u8 slot_info;
> > > +???????u8 activation_cap;
> > > +???????u8 reserved[13];
> > > +???????char slot_1_revision[0x10];
> > > +???????char slot_2_revision[0x10];
> > > +???????char slot_3_revision[0x10];
> > > +???????char slot_4_revision[0x10];
> > 
> > The practice here is to use decimals [16]
> 
> I looked around, and see cxl_identify, cxl_event_mem_module, and
> cxl_event_dram all have a few hex ones thrown in each. So I looked to
> the spec to see if there was any consistency there, and unfortunately
> it isn't either. The spec does say 'Length in bytes' 16 for these fw
> revision fields though, so I think it makes sense changing these to
> decimal..

I had asked for decimal in the event and poison bits, but yes, we are not
consistent. Those ones stand out because even the spec has them as
decimal. Not a deal breaker either way.