Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 20:30:58 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Vishal Verma <vishal.l.verma@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Russ Weight <russell.h.weight@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>
Subject: RE: [PATCH 4/4] tools/testing/cxl: add firmware update emulation to
 CXL memdevs
Message-ID: <646c3372b3330_33fb3294b2@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230421-vv-fw_update-v1-0-22468747d72f@intel.com>
 <20230421-vv-fw_update-v1-4-22468747d72f@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230421-vv-fw_update-v1-4-22468747d72f@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i3kQNrM+DaGX4JHbsOL+63po2GG2BgdKkQrSxYyLSJbL+RtXhlicm2vC/C2b?=
 =?us-ascii?Q?hIxweXWmAFXp00WSz+qunHzoaACVjA+GBiFbg4n6djUWgSZjusnOcZG1hMNc?=
 =?us-ascii?Q?muvH4tbbuSC6aDqo0LLiu5aHSzC6VH5tt7bYHqImQ04lNbOA2s2QZfGADJkl?=
 =?us-ascii?Q?7iCochkC6uOf7UaGIFiqkPW7GtVBUYsiCqjTszAmz6KqldfLXsrcr32u65O3?=
 =?us-ascii?Q?v6y2IWtSkmf1W9Cwxl7v2qLCnb+LzA249bnoFrValXvUWBD+hUqi8D61WbrU?=
 =?us-ascii?Q?tcq8I0Lh0o6IZlws/3AOjQjAsOA2Me/HYxLsoWjmgZJD3qT7c+ifALWDYOSr?=
 =?us-ascii?Q?I5bL1QDkyz31AuOfJ2r4vqFysY68EnOmtuy184gN7cW3eCLQpJ8tDN5tjy7Q?=
 =?us-ascii?Q?7sQVLw/zS1nzov+SvptCD+XqRLrgjzY7p8SoPwJtdUieCVnBxr2+DY0EpqT4?=
 =?us-ascii?Q?IEmithsCoML+pcYbln0xuCUNFioNXUWRM4vfI0Hbu0fcMYYPKhQJr8X9Ia4L?=
 =?us-ascii?Q?XwvPbeJF9g2vePJlD6uP/7AgdEQeyfVpBv7MsdPkklldvfUwlSbcAqHf0g8T?=
 =?us-ascii?Q?RLBYG2MPOjPRdppgBQ2ByX4OmW/CS9CWNwYF9Blr0ISrnj9G/BLR8iH7OdS5?=
 =?us-ascii?Q?HkNTr2U3DSnjI53yhK9k17CFLHMCblkryaocD2itpxK6qnWUBBqfiADaRRyV?=
 =?us-ascii?Q?T6tYKlzJ3aebbO019cK40EH+T2Tnfe/EiUmtcgvcN6tw3XWsGVI0tI/bf+EC?=
 =?us-ascii?Q?40rxWXOX32/Lgq9GOal60VcMMeJC4VYy9GEw/1JliZESUJMk9FsP88/xtrEi?=
 =?us-ascii?Q?8hB5hfL/UqKrnNWHimN7mGDF9rYDrORei0pd6Xf45SRRlSzVsGQcEWs+vbxn?=
 =?us-ascii?Q?XcjG70/cMsllDpqNzgg6n8OKNGQIvq2PHEcPaG1P7eBsmRnIEdmvRvpzEsDv?=
 =?us-ascii?Q?f6auoGBHKXuAo/srGGayVfX7CXd3O3DJLqWpHQlFAnP1v47kArgVr82ZsmSX?=
 =?us-ascii?Q?ZqD73U/a85Ni/kgi6k/GGkzFzCdLHxXFPTPTmnD8Ret6JITxVg82qIb+iCAx?=
 =?us-ascii?Q?96bPZ/n6LzrunztF27PVqilSe6TQrPqxMcITSKkJcDjYSaY9wpUSjMzcKc6q?=
 =?us-ascii?Q?W+faeFkAZJB04+C1EFjFf02zhMTmVoS6wXl9XOzk9GGWiGjfEK7gYk3oMLic?=
 =?us-ascii?Q?uBg26VhnFhOUjWo/SuYko5hVKpZYvT7fauesV4b7OsBeJbfQmsMoflsRyIq1?=
 =?us-ascii?Q?bKBkTV57mhIdXzNwlKsK5XQvuf3JbcM1HczPk3gKQURc0u5gWw1uTNGdZriJ?=
 =?us-ascii?Q?9qGTacS+lxx6K/WNeB5Z8MO9UYdUiFix96hzo6nVCpOjPZCdYYIBypIcTCLX?=
 =?us-ascii?Q?4URl2jemjo63++CouQH3HDEv4rZmd1w5z0F9qGVSfRALzrZvxCEumjxOC5xM?=
 =?us-ascii?Q?AqjiyRi2QCmVRF6OVJP3X2FBiA+QzKhS9fIsxC/5YZMtkcPyUMs2omBj1X8u?=
 =?us-ascii?Q?rSVQUcBouKOto2BwTUpLQg/r8z0uiJE4e6hkWt1ZoBLWRnMh2ArS+kAqdQwx?=
 =?us-ascii?Q?iHwaWnjkQXxyVze9ucSNj+WHl6KJ1riSIa1lwZBmqgvfdPED2+hweOWhGwLJ?=
 =?us-ascii?Q?3Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d98f4499-0129-475f-e401-08db5b3e2182
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 03:31:01.3550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OCFdPNk0EMPpbHXZgukFR+vVaJHlIWsoJFFhr34u1VklHpWu/CWc64IDn13diuoZJ4kkbd1DOvmOWYeNa6rTn7voF6NYVuKfOJqyIpSiVs0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5883
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Vishal Verma wrote:
> Add emulation for the 'Get FW Info', 'Transfer FW', and 'Activate FW'
> CXL mailbox commands to the cxl_test emulated memdevs to enable
> end-to-end unit testing of a firmware update flow. For now, only
> advertise an 'offline activation' capability as that is all the CXL
> memdev driver currently implements.
> 
> Add some canned values for the serial number fields, and create a
> platform device sysfs knob to calculate the sha256sum of the firmware
> image that was received, so a unit test can compare it with the original
> file that was uploaded.
> 

Looks good.