Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3789735rwd; Mon, 22 May 2023 21:05:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4SDl9lPs2GAIfMdF53VG/0RKKQmEo6BpxN1j026YDkZIY+1Tveubom93Z4MNmsOrsfi3HR X-Received: by 2002:aa7:88d5:0:b0:645:8a69:faad with SMTP id k21-20020aa788d5000000b006458a69faadmr17380885pff.14.1684814713924; Mon, 22 May 2023 21:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684814713; cv=none; d=google.com; s=arc-20160816; b=l4Md1Vn39hhWIa10M3mNAKXdeFebrEYqOVlj+CSdeOoP7J/hlkrmGKObyB2ZsNu+Q1 s8kIfjF/5Xh48e0VCgZTBWtSC40zzQ6GhOnwwVkT34mgwi2sr2qNTebrzMuB7i4e98vf EHvqGXaOAzRQUJz640IMj5/+/I8+6xR/z6vqnRhk50CIyTXJoXp1jXB2B/1tXFIXUHUD daZJYhLkjeWcGlCZGHPajN+VtTKKQcEqoSA+6K2j8zDFldrcUnv53moCXlhqtgfGQKCK F5+8gjwjGKvwLAiaDqRgF6EMKmYxCzY7MdJhmwQ+0q0mfYckUapK2kyf0LEjTq6stfJ8 exog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XOwI9zzx3UJYobf96lJIEe8i6rhkj/gDLVlyWRH4kEo=; b=XItYUDyxjq8HmXWT7w9lPDa8WFIqNeFZPnU4U9BA2xcADO/OCkU5cC3UFOTqXINYA0 WOrtsiWr430RJMXUQKmG9puUzYx9vEH9n1dj1gNxVzKC0bMwg5dmJHEcnQYZh/sqzxqV s4tk/Vs38wx9cS+Cbs8ESqnOIkqgwSX2jsaI6YAUATlR7wCDPeZV+I9aup7VaFh/ace0 Fn+5zRly9O8KTIePos7H7S/5LzemmTfxkH+rlsERmtlMUZswo5BLCEAqqfPId+JUgSum CiLP1u8Ip2JiEM4u0RWJJwxF2d+YkqUOL+tslLDiSs8/wvouZRAWKEb4p8X8Pbai4Ows Y2fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GO05ctuD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u189-20020a6385c6000000b00534913a5303si5908274pgd.540.2023.05.22.21.05.01; Mon, 22 May 2023 21:05:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GO05ctuD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232664AbjEWD4e (ORCPT + 99 others); Mon, 22 May 2023 23:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234347AbjEWD4b (ORCPT ); Mon, 22 May 2023 23:56:31 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D15120; Mon, 22 May 2023 20:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684814183; x=1716350183; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kv+U3eR2t5jXrzu7bhE+tT5rUsZNuQI3uVH6Dk7rusQ=; b=GO05ctuDT4THeaWR4P76lv2IV/SZoF76y7xB2Jly9HMlpTXuGZTFlck8 rtPDaZCCN4Eo7oL9FiYUucqUBMCFm30oMSAd0e/B0L4zvvjLrR2DL1Th8 T+AJpMbYfEVCrcKz10zEyM6GpeAWXznbAXt/75Ub8pjV1tNrSS7k8IFPb rVGU13lFpavVZi3DcXMzLB87ULmsDGnie4TfGL7yVZrwFFKqHwT99N+Ju vMwSbG7OOGR9AN0C3U+Na1GyiYs+bRz6SygABKbGSmRYr9p7VlAMegcjD gM5po7dlI2WicW2UPJJdQRW+SFvaotJv/VtMo4D2PKJpSmm7l6mqy83vj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="342577144" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="342577144" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 20:56:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="681240866" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="681240866" Received: from ganyifangubuntu20-ilbpg12.png.intel.com ([10.88.229.31]) by orsmga006.jf.intel.com with ESMTP; 22 May 2023 20:56:19 -0700 From: Gan Yi Fang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Michael Sit Wei Hong , Gan Yi Fang Subject: [PATCH net 1/1] net: stmmac: Remove redundant checking for rx_coalesce_usecs Date: Mon, 22 May 2023 23:55:48 -0400 Message-Id: <20230523035548.188651-1-yi.fang.gan@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The datatype of rx_coalesce_usecs is u32, always larger or equal to zero. Previous checking does not include value 0, this patch removes the checking to handle the value 0. Signed-off-by: Gan Yi Fang --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 35c8dd92d369..6ed0e683b5e0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -917,7 +917,7 @@ static int __stmmac_set_coalesce(struct net_device *dev, else if (queue >= max_cnt) return -EINVAL; - if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) { + if (priv->use_riwt) { rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv); if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT)) -- 2.34.1