Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 00:19:37 -0400
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     Boqun Feng <boqun.feng@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Brian Foster <bfoster@redhat.com>,
        Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v2] locking: SIX locks (shared/intent/exclusive)
Message-ID: <ZGw+2abYSDohPG2E@moria.home.lan>
References: <20230522171314.1953699-1-kent.overstreet@linux.dev>
 <ZGvnJZYQfAmgdsqr@boqun-archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZGvnJZYQfAmgdsqr@boqun-archlinux>
Precedence: bulk

On Mon, May 22, 2023 at 03:05:25PM -0700, Boqun Feng wrote:
> > + * bits 29-30		has read waiters
> > + * bits 30-31		has intent waiters
> > + * bits 31-32		has write waiters
> > + */
> > +
> > +#define SIX_LOCK_HELD_read_OFFSET	0
> > +#define SIX_LOCK_HELD_read		~(~0U << 26)
> > +#define SIX_LOCK_HELD_intent		(1U << 26)
> > +#define SIX_LOCK_HELD_write		(1U << 27)
> > +#define SIX_LOCK_WAITING_read		(1U << (28 + SIX_LOCK_read))
> > +#define SIX_LOCK_WAITING_intent		(1U << (28 + SIX_LOCK_intent))
> > +#define SIX_LOCK_WAITING_write		(1U << (28 + SIX_LOCK_write))
> > +#define SIX_LOCK_NOSPIN			(1U << 31)
> 
> ^ NOSPIN is the 31st bit.

Thanks - I think I'll just delete that comment, it's out of date and
the state bits have simplified a bit :)