Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Gan, Yi Fang" <yi.fang.gan@intel.com>
To:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Looi, Hong Aun" <hong.aun.looi@intel.com>,
        "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>
Subject: RE: [PATCH net 1/1] net: stmmac: Remove redundant checking for
 rx_coalesce_usecs
Thread-Topic: [PATCH net 1/1] net: stmmac: Remove redundant checking for
 rx_coalesce_usecs
Thread-Index: AQHZjSqMA2vw48oBS0GjjLvxixFw6a9nXhhQ
Date:   Tue, 23 May 2023 06:05:25 +0000
Message-ID: <DM6PR11MB33060877F8CE38E1BA65EEA8B9409@DM6PR11MB3306.namprd11.prod.outlook.com>
References: <20230523035548.188651-1-yi.fang.gan@intel.com>
In-Reply-To: <20230523035548.188651-1-yi.fang.gan@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NYwgFF70RmFw62JbrwKDIP7EZpMXvXyO0/fwJld3+4p8kaqDKca0DQo5OqQJ?=
 =?us-ascii?Q?dokmPglURA+wd99boSTY5Q/B7yPELXhfR1yTTDWk/CiR8zOEi1NcCyx0JOnK?=
 =?us-ascii?Q?+D67YYZIyci6hVqTyXGBXUliPeKBtquBAZSIQpijj+aFWlO8x2rU7xsUvCpz?=
 =?us-ascii?Q?R0tHQg0iIIiBxS55VPfrwA80pzNcNrwByNNWEOj7js6DdU/vES4gN473u8N4?=
 =?us-ascii?Q?Hcv3M4u78fTn60n0K11xzEOBP5Vr+cg36tbMDU3Zy3hKF7bFlH1ORNIIMtLK?=
 =?us-ascii?Q?HqavqzhjZf4AgE5tEFbRIJKNsC+cf/gCTZ81ZrkU9aTKn1MSRpoljxsoX60l?=
 =?us-ascii?Q?+SkZsRthkuvTZThg8+Yj6lnj/bGzayK6koc9jYnu8fFaCJsLrY2dPZqe7X+M?=
 =?us-ascii?Q?WpJdTpkkXLUYLLcYkDLj7l8lhrowvCgsWNiDUGkZ6WfQjQayUly762sS0DPW?=
 =?us-ascii?Q?ZdEyfIMg36BjtXZ0DcILMM+LU8Qx6/Hq7gsF613KsUQfjzDRYtfJ+vQ6s1f6?=
 =?us-ascii?Q?HrRtESDNiFc7LwGVX9MNvwDVzen8+Na5WUT0/mFR61ZfAWLQO38NYzIPvDKq?=
 =?us-ascii?Q?hKFhURhqXy700di6W4vL7dLoxHPe0rrjz5KTYGK+sPklH3dHAYT46rsb3AMa?=
 =?us-ascii?Q?aACW00Yl+LDNpiLEctA5mqdW5tce7pg8tXRPdyjUHh51GkymA2fJ6xlFKOwy?=
 =?us-ascii?Q?CsmKdKaeJB0vzQYbddf5aXpBV7jfjOEQ2p8+wIuOMxJx++keAIL9EHnhjdO9?=
 =?us-ascii?Q?zR7IaC0efNU0/Kv3c1QETzzrWqo0k8ZNQX24JXj0RJ+dsGpCWhVZEy5azxcY?=
 =?us-ascii?Q?ii3u5MYjB0TtV8BJfJBCYYfc1rjRF5r2BunUDLHHga5c1PoFU8brg2+I5Ixx?=
 =?us-ascii?Q?caWfoWBdj4afY15ZDOQm5DXTLm4fwARGCP9JhI0nU6SecvgYqj4b9xGZZjmf?=
 =?us-ascii?Q?gHTgUXxEK25Fose5wzCmuEnSQYEZtQC0efqUkOIqJ2JDpbKShLfMo227BSkN?=
 =?us-ascii?Q?5AaiCsnPeXG/p90y/rDTAgeWj/3jIXeOG8D63r8oBEkIXxtlYH2LZ3yBlLPx?=
 =?us-ascii?Q?4K3/OpJ8CnfjRaKmHtNDpZoGDgihSzOPGf2EDs4TVplsXQ8wHqMvss11qjYN?=
 =?us-ascii?Q?itvlEtC43Ujuea8taaJNigWp44wNL48MHkh53LBY4aKmxgFZTnw5AsXiPZtG?=
 =?us-ascii?Q?UkX25iKQ8+1EHX5CLv27RmjDxbloIbtO4DZs7jph6kRi/6sqBRZAoEkV54/m?=
 =?us-ascii?Q?Aa+I5WtD8cTmSvGJgwd2u9tGUgwcCPl5un5w5sfVtwVWiJKbWIwymxuSxjQS?=
 =?us-ascii?Q?mugYlaDJUcYD/p9UVTbTsJvbMu4MvOHzKWlg8HZxKRaLDFvsRrm2u6kjq566?=
 =?us-ascii?Q?bYlv/P2npOD0m2VNDeymHeed7gWMqYS+dC3tVCTcY4wpT9BmiemjKiacV75e?=
 =?us-ascii?Q?T+gZW6o7HqR5gKZAuUlZ1oDdbVrIiWGnejYAqHMltk0mXyXzbIrofdG6lql2?=
 =?us-ascii?Q?/mzWkz1KhVGO0QtsuU3yThO1F2kZBBzqKwktaPB9FgrmpI7b6LLr9ttJo7Qz?=
 =?us-ascii?Q?sglGmfY1e/LgbjdSEhQXpmtokbLkcyGQPEKyH5Q3?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3306.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5b3e58e-19f5-424b-fd44-08db5b53b354
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2023 06:05:25.1579
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kFmykcD8bZx6Lbxkg7rxRIV6l3RScgSp1TJPS5/EzZBG5NDLWjLabYZKw0EKbaJYBJfNsuzBWAcsuDjd31CWuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8196
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Gan, Yi Fang <yi.fang.gan@intel.com>
> Sent: Tuesday, 23 May, 2023 11:56 AM
> To: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue
> <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David S .
> Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>
> Cc: netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Looi,=
 Hong
> Aun <hong.aun.looi@intel.com>; Sit, Michael Wei Hong
> <michael.wei.hong.sit@intel.com>; Gan, Yi Fang <yi.fang.gan@intel.com>
> Subject: [PATCH net 1/1] net: stmmac: Remove redundant checking for
> rx_coalesce_usecs
>=20
> The datatype of rx_coalesce_usecs is u32, always larger or equal to zero.
> Previous checking does not include value 0, this patch removes the checki=
ng to
> handle the value 0.
>=20
> Signed-off-by: Gan Yi Fang <yi.fang.gan@intel.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index 35c8dd92d369..6ed0e683b5e0 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -917,7 +917,7 @@ static int __stmmac_set_coalesce(struct net_device
> *dev,
>  	else if (queue >=3D max_cnt)
>  		return -EINVAL;
>=20
> -	if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) {
> +	if (priv->use_riwt) {
>  		rx_riwt =3D stmmac_usec2riwt(ec->rx_coalesce_usecs, priv);
>=20
>  		if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT))
> --
> 2.34.1

Hi All,

Please ignore this message. The patch is targeted for net-next instead of n=
et.
Will resend for net-next.


Best Regards,
Gan Yi Fang