Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3888109rwd; Mon, 22 May 2023 23:14:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5GhrdYRYzzdi1gT2MOu9muGz0Eqi4mQR3EvwFm1JEpcjmp0y38eZ2qhSURgap7LBRzz1/D X-Received: by 2002:a17:903:22cf:b0:1ae:73b8:747e with SMTP id y15-20020a17090322cf00b001ae73b8747emr16873334plg.31.1684822459312; Mon, 22 May 2023 23:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684822459; cv=none; d=google.com; s=arc-20160816; b=oUCYyuSSZkwfP0hFr4B0zkzn0SyIrEal43sFbMLntfq9YqqxHW8TrzOTj5to/HL/8Q TkEEbXGplaR62u8rO8RVqZFvrCpUv43G90fNFRmP5wJPtpCs2hLTXSogDNrrMb1Ds3pQ 9E8x+w6zVRQ61A/YhxavK8PtDrOF+05iA47ZIvrD4dD2aHESg6bQ0tDq7BDn5fOEr3pb 1UbLJqQllOw6d2RY/Ppzrzjr6tAoJee9mVYU0TRXiK4vuWsds9HcDC1vSCM4ZqKja+bK bieSsMLFZMtd7b7J/VcYoExfwN4f8eZmgVf7FGc9Fotaw+JyW2zXpUJVLTPE0m9bHx5o e2RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Cu3w1DuGiZvnpJp9hA5iYO4+S8ACeWvD7fPOFwTEApY=; b=mzEj/6jq3fgwKndZBnsMPBOSEDUlCumAZkw2T9h8dOOnwgTmGf3G9SnyBHsGQ2pRdB KBo7wXpe66kYEbaOaDBS2warg3Z2mXzF2D7xFnzIrMMnFbZaxiKE2E2t/0q9GEyi3Hmi 6QOADO/gGODFug45XjJkDxCSq2VFpBoN82B/2c1AqTSt8aQSneGEtD/Kutu+trcLPhpK 1Nn3OcD/shC3bdHfJcCuUUlTeUEhNxh4pbrSD7u6e91BvGMzZHoB0nEP5YxierGMMTEx P5D0nFv/nUhtISJbSFti+oG8gmq6WT/E4IXMD3Jv20APGHNoM1OHLK4MFcc7OEcMzU1m LjMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yqbjnNtx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jb15-20020a170903258f00b001aad9b73ff2si257129plb.285.2023.05.22.23.14.05; Mon, 22 May 2023 23:14:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yqbjnNtx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234877AbjEWGGf (ORCPT + 99 others); Tue, 23 May 2023 02:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234849AbjEWGGd (ORCPT ); Tue, 23 May 2023 02:06:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE2A119 for ; Mon, 22 May 2023 23:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Cu3w1DuGiZvnpJp9hA5iYO4+S8ACeWvD7fPOFwTEApY=; b=yqbjnNtxq4kJd6ZUyHm1A6FgpK f3mEjqf0oiObOjorBNIiMxBafBzrZOcfm9AL5HUs8MSc7h9EFNBoUD/wNNUXDeJKwI2jtFQMbCzRG TNj7ItekEawlS6puU8HbyzgU6az3ABNbb6NNP/zK7mS7nuPDc80N8Xiw9blCTbzt5bS2V1ZyrGSnB l8PREeawaUl8mwsa/G7MeONzthvCiuHyPtR2b5N6nvTkZbW+ZohuqIyRzFHzjmv3B08N8+7JL7Dyi mKugWQjK7DKbKTpmuWW+BK5d0Q5Ajk8wHWfN1etrjwoYH1q/l9u/k7FNdUb9i3apkkNruud7OL4xp vqqFKAzg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1LAF-0092Qc-1T; Tue, 23 May 2023 06:06:31 +0000 Date: Mon, 22 May 2023 23:06:31 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-3-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 01:08:42PM +0200, Uladzislau Rezki (Sony) wrote: > static __always_inline int > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > - struct vmap_area *va, unsigned long nva_start_addr, > - unsigned long size) > +va_clip(struct rb_root *root, struct list_head *head, > + struct vmap_area *va, unsigned long nva_start_addr, > + unsigned long size) Same comment as before, not going to repeat it for futher reviews. Otherwise looks good: Reviewed-by: Christoph Hellwig