Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 22:55:54 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Kees Cook <keescook@chromium.org>
Cc:     Song Liu <song@kernel.org>, Christoph Hellwig <hch@infradead.org>,
        linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] md/raid5: Convert stripe_head's "dev" to flexible
 array member
Message-ID: <ZGxVatFgD1u1x+5c@infradead.org>
References: <20230522212114.gonna.589-kees@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230522212114.gonna.589-kees@kernel.org>
Precedence: bulk

On Mon, May 22, 2023 at 02:21:15PM -0700, Kees Cook wrote:
> -	} dev[1]; /* allocated with extra space depending of RAID geometry */
> +	} dev[]; /* allocated with extra space depending of RAID geometry */

I still think this should be:

	/* allocated depending of RAID geometry */

now or dropped entirely, as the extra only made sense when it always
had that magic one.

The actual code changes looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>